Compare commits

...

1 Commits

Author SHA1 Message Date
infra-sre 4b592c8f9c fix(tests): align test_sop_checklist.py with parse_directives return type
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Blocked by required conditions
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 30s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 39s
CI / Detect changes (pull_request) Successful in 1m24s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 23s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 33s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m25s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 1m30s
qa-review / approved (pull_request) Failing after 36s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m37s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m49s
security-review / approved (pull_request) Failing after 40s
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m46s
CI / Python Lint & Test (pull_request) Successful in 8m9s
CI / Canvas (Next.js) (pull_request) Failing after 14m8s
CI / all-required (pull_request) Failing after 14m21s
CI / Platform (Go) (pull_request) Successful in 19m3s
gate-check-v3 / gate-check (pull_request) Successful in 23s
sop-tier-check / tier-check (pull_request) Successful in 21s
sop-checklist / all-items-acked (pull_request) Successful in 24s
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Failing after 1m59s
audit-force-merge / audit (pull_request) Waiting to run
The test helper parse_ack_revoke was still unpacking a 2-tuple
(directives, na_directives) from parse_directives, but the function
was updated to return a single list[tuple[str,str,str]]. Also fixed
test_empty_body which asserted ([], []) instead of [].

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-15 15:42:45 +00:00
+5 -5
View File
@@ -135,9 +135,9 @@ class TestParseDirectives(unittest.TestCase):
self.aliases = _numeric_aliases()
def parse_ack_revoke(self, body):
directives, na_directives = sop.parse_directives(body, self.aliases)
self.assertEqual(na_directives, [])
return directives
# parse_directives returns a combined list of (kind, slug, note) tuples.
# Return it directly; the old two-list interface no longer applies.
return sop.parse_directives(body, self.aliases)
def test_simple_ack(self):
d = self.parse_ack_revoke("/sop-ack comprehensive-testing")
@@ -201,8 +201,8 @@ class TestParseDirectives(unittest.TestCase):
self.assertEqual(len(d), 1)
def test_empty_body(self):
self.assertEqual(sop.parse_directives("", self.aliases), ([], []))
self.assertEqual(sop.parse_directives(None, self.aliases), ([], []))
self.assertEqual(sop.parse_directives("", self.aliases), [])
self.assertEqual(sop.parse_directives(None, self.aliases), [])
def test_normalization_applied(self):
# /sop-ack Comprehensive_Testing → canonical comprehensive-testing