fix(handlers): log DB scan/exec errors previously silently ignored

- approvals.go Create: log parent workspace lookup Scan error
  (DB failure now surfaces instead of silently skipping escalation)
- approvals.go ListAll: log auto-expire ExecContext error
  (stale approvals no longer silently accumulate on DB failure)
- terminal.go HandleConnect: log instance_id lookup Scan error
  (workspace not found now surfaces instead of falling to local Docker silently)
- terminal.go handleLocalConnect: log workspace name lookup Scan error
  (name lookup failure now surfaces instead of being silently skipped)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

workspace-server/internal/handlers/approvals.go

@@ -60,7 +60,9 @@ func (h *ApprovalsHandler) Create(c *gin.Context) {
 
 	// Auto-escalate to parent
 	var parentID *string
-	db.DB.QueryRowContext(ctx, `SELECT parent_id FROM workspaces WHERE id = $1`, workspaceID).Scan(&parentID)
+	if err := db.DB.QueryRowContext(ctx, `SELECT parent_id FROM workspaces WHERE id = $1`, workspaceID).Scan(&parentID); err != nil {
+		log.Printf("CreateApproval parent lookup error workspace=%s: %v", workspaceID, err)
+	}
 	if parentID != nil {
 		h.broadcaster.RecordAndBroadcast(ctx, string(events.EventApprovalEscalated), *parentID, map[string]interface{}{
 			"approval_id":       approvalID,
@@ -80,10 +82,12 @@ func (h *ApprovalsHandler) ListAll(c *gin.Context) {
 	ctx := c.Request.Context()
 
 	// Auto-expire stale approvals (older than 10 min)
-	db.DB.ExecContext(ctx, `
+	if _, err := db.DB.ExecContext(ctx, `
 		UPDATE approval_requests SET status = 'denied', decided_by = 'auto-expired', decided_at = now()
 		WHERE status = 'pending' AND created_at < now() - interval '10 minutes'
-	`)
+	`); err != nil {
+		log.Printf("ListAll auto-expire error: %v", err)
+	}
 
 	rows, err := db.DB.QueryContext(ctx, `
 		SELECT a.id, a.workspace_id, w.name, a.action, a.reason, a.status, a.created_at

workspace-server/internal/handlers/instructions.go

@@ -248,6 +248,9 @@ func (h *InstructionsHandler) Resolve(c *gin.Context) {
 		b.WriteString(content)
 		b.WriteString("\n\n")
 	}
+	if rowsErr := rows.Err(); rowsErr != nil {
+		log.Printf("ResolveInstructions rows.Err workspace=%s: %v", workspaceID, rowsErr)
+	}
 
 	c.JSON(http.StatusOK, gin.H{
 		"workspace_id": workspaceID,
@@ -258,6 +261,7 @@ func (h *InstructionsHandler) Resolve(c *gin.Context) {
 func scanInstructions(rows interface {
 	Next() bool
 	Scan(dest ...interface{}) error
+	Err() error
 }) []Instruction {
 	var instructions []Instruction
 	for rows.Next() {
@@ -269,6 +273,9 @@ func scanInstructions(rows interface {
 		}
 		instructions = append(instructions, inst)
 	}
+	if scanErr := rows.Err(); scanErr != nil {
+		log.Printf("scanInstructions rows.Err: %v", scanErr)
+	}
 	if instructions == nil {
 		instructions = []Instruction{}
 	}

workspace-server/internal/handlers/terminal.go

@@ -109,9 +109,11 @@ func (h *TerminalHandler) HandleConnect(c *gin.Context) {
 	// provisionWorkspaceCP → migration 038). Null instance_id means the
 	// workspace runs as a local Docker container on this tenant.
 	var instanceID string
-	db.DB.QueryRowContext(ctx,
+	if err := db.DB.QueryRowContext(ctx,
 		`SELECT COALESCE(instance_id, '') FROM workspaces WHERE id = $1`,
-		workspaceID).Scan(&instanceID)
+		workspaceID).Scan(&instanceID); err != nil {
+		log.Printf("HandleConnect instanceID lookup error workspace=%s: %v", workspaceID, err)
+	}
 
 	if instanceID != "" {
 		h.handleRemoteConnect(c, workspaceID, instanceID)
@@ -144,7 +146,9 @@ func (h *TerminalHandler) handleLocalConnect(c *gin.Context, workspaceID string)
 	// Look up workspace name for manual container naming
 	var wsName string
 	if _, err := h.docker.Ping(ctx); err == nil {
-		db.DB.QueryRowContext(ctx, `SELECT LOWER(REPLACE(name, ' ', '-')) FROM workspaces WHERE id = $1`, workspaceID).Scan(&wsName)
+		if err := db.DB.QueryRowContext(ctx, `SELECT LOWER(REPLACE(name, ' ', '-')) FROM workspaces WHERE id = $1`, workspaceID).Scan(&wsName); err != nil {
+			log.Printf("handleLocalConnect wsName lookup error workspace=%s: %v", workspaceID, err)
+		}
 		if wsName != "" {
 			candidates = append(candidates, wsName)
 		}