Compare commits

...

2 Commits

Author SHA1 Message Date
core-fe 98e3852544 fix(canvas/mobile): WCAG 2.4.7 focus-visible rings on MobileCanvas buttons
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
CI / Detect changes (pull_request) Successful in 5s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 15s
E2E API Smoke Test / detect-changes (pull_request) Successful in 4s
E2E Chat / detect-changes (pull_request) Successful in 4s
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 4s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 3s
Harness Replays / detect-changes (pull_request) Successful in 3s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 4s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
gate-check-v3 / gate-check (pull_request) Successful in 3s
qa-review / approved (pull_request) Failing after 3s
security-review / approved (pull_request) Failing after 2s
CI / Platform (Go) (pull_request) Successful in 5m3s
sop-tier-check / tier-check (pull_request) Successful in 4s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
sop-checklist / na-declarations (pull_request) N/A: (none)
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
CI / Canvas (Next.js) (pull_request) Successful in 6m27s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Harness Replays / Harness Replays (pull_request) Successful in 2s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 1s
CI / Python Lint & Test (pull_request) Successful in 6m57s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 5m6s
E2E Chat / E2E Chat (pull_request) Failing after 4m35s
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 7m2s
audit-force-merge / audit (pull_request) Waiting to run
- Add focus-visible outline ring to 3 inline-styled buttons:
  - Reset zoom button (aria-label="Reset zoom")
  - Agent node button (aria-label={Open ${name}})
  - Spawn FAB (aria-label="Spawn new agent")
- Focus ring uses var(--accent, #3b82f6) to match existing design tokens.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-17 06:34:42 +00:00
core-fe 57946e105a fix(canvas): WCAG 2.4.7 focus-visible on AttachmentViews download + remove buttons
- AttachmentChip: add aria-label + keep title on download button, focus-visible ring
- PendingAttachment: add focus-visible ring on remove button

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-17 06:34:42 +00:00
2 changed files with 21 additions and 2 deletions
@@ -171,6 +171,20 @@ export function MobileCanvas({
onTouchMove={onTouchMove}
onTouchEnd={onTouchEnd}
>
<style>{`
.mobile-canvas__reset-btn:focus-visible {
outline: 2px solid var(--accent, #3b82f6);
outline-offset: 2px;
}
.mobile-canvas__node-btn:focus-visible {
outline: 2px solid var(--accent, #3b82f6);
outline-offset: 2px;
}
.mobile-canvas__spawn-btn:focus-visible {
outline: 2px solid var(--accent, #3b82f6);
outline-offset: 2px;
}
`}</style>
{/* Dotted grid background — fills the viewport, doesn't transform */}
<div
style={{
@@ -205,6 +219,7 @@ export function MobileCanvas({
type="button"
onClick={resetView}
aria-label="Reset zoom"
className="mobile-canvas__reset-btn"
style={{
position: "absolute",
right: 14,
@@ -271,6 +286,8 @@ export function MobileCanvas({
<button
key={l.agent.id}
type="button"
aria-label={`Open ${l.agent.name}`}
className="mobile-canvas__node-btn"
onClick={() => onOpen(l.agent.id)}
style={{
position: "absolute",
@@ -376,6 +393,7 @@ export function MobileCanvas({
type="button"
onClick={onSpawn}
aria-label="Spawn new agent"
className="mobile-canvas__spawn-btn"
style={{
position: "absolute",
right: 24,
@@ -33,7 +33,7 @@ export function PendingAttachmentPill({
<button
onClick={onRemove}
aria-label={`Remove ${file.name}`}
className="ml-0.5 text-ink-mid hover:text-ink transition-colors shrink-0"
className="ml-0.5 text-ink-mid hover:text-ink transition-colors shrink-0 focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1"
>
<svg width="10" height="10" viewBox="0 0 16 16" fill="none" aria-hidden="true">
<path d="M4 4l8 8M12 4l-8 8" stroke="currentColor" strokeWidth="1.6" strokeLinecap="round" />
@@ -63,7 +63,8 @@ export function AttachmentChip({
<button
onClick={() => onDownload(attachment)}
title={`Download ${attachment.name}`}
className={`flex items-center gap-1.5 rounded-md border px-2 py-1 text-[10px] transition-colors max-w-full ${toneClasses}`}
aria-label={`Download ${attachment.name}`}
className={`flex items-center gap-1.5 rounded-md border px-2 py-1 text-[10px] transition-colors max-w-full focus-visible:outline-none focus-visible:ring-2 focus-visible:ring-accent focus-visible:ring-offset-1 ${toneClasses}`}
>
<FileGlyph className="shrink-0 opacity-70" />
<span className="truncate">{attachment.name}</span>