Compare commits

...

1 Commits

Author SHA1 Message Date
fullstack-engineer 2a833d5bc1 fix(handlers): add missing rows.Err() checks to MemoryHandler.List and EventsHandler
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 18s
Harness Replays / detect-changes (pull_request) Successful in 19s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 25s
gate-check-v3 / gate-check (pull_request) Successful in 26s
CI / Detect changes (pull_request) Successful in 1m12s
qa-review / approved (pull_request) Successful in 23s
security-review / approved (pull_request) Successful in 22s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m21s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m23s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m9s
Harness Replays / Harness Replays (pull_request) Successful in 11s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m36s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 16s
CI / Python Lint & Test (pull_request) Successful in 14s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 14s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6m31s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 7m7s
CI / Platform (Go) (pull_request) Failing after 11m58s
CI / Canvas (Next.js) (pull_request) Successful in 12m11s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Successful in 1s
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
After `for rows.Next()` loops in List functions, add the safety-net
rows.Err() check to detect iteration errors. This was systematically
added to approvals.go, tokens.go, instructions.go in PRs #1130/#1150
— memory.go and events.go were missed.

- memory.go: MemoryHandler.List
- events.go: EventsHandler.List + ListByWorkspace

Closes #1171.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-15 11:20:41 +00:00
2 changed files with 11 additions and 0 deletions
@@ -49,6 +49,10 @@ func (h *EventsHandler) List(c *gin.Context) {
"created_at": createdAt,
})
}
if err := rows.Err(); err != nil {
log.Printf("Events list rows.Err: %v", err)
}
c.JSON(http.StatusOK, events)
}
@@ -87,5 +91,9 @@ func (h *EventsHandler) ListByWorkspace(c *gin.Context) {
"created_at": createdAt,
})
}
if err := rows.Err(); err != nil {
log.Printf("Events list-by-workspace rows.Err: %v", err)
}
c.JSON(http.StatusOK, events)
}
@@ -54,6 +54,9 @@ func (h *MemoryHandler) List(c *gin.Context) {
entry.Value = json.RawMessage(value)
entries = append(entries, entry)
}
if err := rows.Err(); err != nil {
log.Printf("Memory list rows.Err: %v", err)
}
c.JSON(http.StatusOK, entries)
}