Compare commits

...

2 Commits

Author SHA1 Message Date
core-uiux a71a683cf9 fix(canvas): remove duplicate SearchDialog mount from desktop page.tsx
security-review / approved (pull_request) Failing after 32s
qa-review / approved (pull_request) Failing after 34s
sop-checklist-gate / gate (pull_request) Successful in 30s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 47s
gate-check-v3 / gate-check (pull_request) Successful in 1m1s
CI / Detect changes (pull_request) Successful in 1m13s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 24s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
CI / Platform (Go) (pull_request) Failing after 5m47s
CI / Canvas (Next.js) (pull_request) Successful in 7m17s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / Python Lint & Test (pull_request) Failing after 7m31s
CI / all-required (pull_request) Failing after 1s
sop-tier-check / tier-check (pull_request) Failing after 11m48s
audit-force-merge / audit (pull_request) Has been skipped
SearchDialog is already rendered inside Canvas.tsx (line 374).
Adding it to page.tsx created a redundant second instance on desktop.
Mobile shell (MobileApp.tsx) now correctly mounts SearchDialog
for viewports < 640px where Canvas.tsx is never rendered.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 11:23:14 +00:00
core-uiux 5be6681fae feat(canvas): mount SearchDialog in desktop + mobile canvas shells
Adds Cmd+K workspace search to both canvas entry points:
- page.tsx: mounts SearchDialog in the desktop shell
- MobileApp.tsx: mounts SearchDialog in the mobile shell

Phase 20.3: closes the "Workspace search (Cmd+K)" requirement.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 11:23:14 +00:00
@@ -20,6 +20,7 @@ import { MobileMe } from "./MobileMe";
import { MobileSpawn } from "./MobileSpawn";
import { usePalette } from "./palette";
import { MobileAccentProvider } from "./palette-context";
import { SearchDialog } from "@/components/SearchDialog";
type Route = "home" | "canvas" | "detail" | "chat" | "comms" | "me";
@@ -204,6 +205,8 @@ export function MobileApp() {
{showTabBar && <TabBar dark={dark} active={activeTab} onChange={onTabChange} />}
{showSpawn && <MobileSpawn dark={dark} onClose={() => setShowSpawn(false)} />}
<SearchDialog />
</main>
</MobileAccentProvider>
);