Compare commits

...

1 Commits

Author SHA1 Message Date
fullstack-engineer 37bb04136c test(scheduler): add coverage for extractResponseSummary, isEmptyResponse, and phantom busy sweep
CI / all-required (pull_request) Blocked by required conditions
CI / Shellcheck (E2E scripts) (pull_request) Blocked by required conditions
CI / Canvas Deploy Reminder (pull_request) Blocked by required conditions
CI / Python Lint & Test (pull_request) Blocked by required conditions
E2E API Smoke Test / E2E API Smoke Test (pull_request) Blocked by required conditions
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Blocked by required conditions
Harness Replays / Harness Replays (pull_request) Blocked by required conditions
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Blocked by required conditions
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Harness Replays / detect-changes (pull_request) Successful in 11s
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 13s
gate-check-v3 / gate-check (pull_request) Successful in 13s
security-review / approved (pull_request) Successful in 14s
qa-review / approved (pull_request) Successful in 14s
sop-tier-check / tier-check (pull_request) Successful in 15s
sop-checklist / all-items-acked (pull_request) Successful in 15s
CI / Detect changes (pull_request) Successful in 21s
E2E API Smoke Test / detect-changes (pull_request) Successful in 24s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 24s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 24s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m8s
CI / Platform (Go) (pull_request) Failing after 9m40s
CI / Canvas (Next.js) (pull_request) Successful in 10m25s
18 new tests covering previously-untested code paths:
- extractResponseSummary: nil/empty body, invalid JSON, no result key,
  empty result, no parts key, empty parts, text extraction, multi-part,
  non-string text
- isEmptyResponse: nil/empty, all sentinel markers, real content,
  partial marker (no false positive)
- maybeSweepPhantomBusy: skips within 5-min interval, runs when stale,
  runs on zero-value (first sweep)
- sweepPhantomBusy: DB query error, rows.Next() error

Scheduler coverage: 49.8% → 64.2% (+14.4 pp)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-15 18:18:01 +00:00
@@ -653,3 +653,239 @@ func TestSanitizeUTF8(t *testing.T) {
t.Errorf("sanitizeUTF8 did not produce valid UTF-8: %x", []byte(out))
}
}
// ── extractResponseSummary coverage ───────────────────────────────────────────
func TestExtractResponseSummary_EmptyBody(t *testing.T) {
s := New(nil, nil)
if got := s.extractResponseSummary(nil); got != "" {
t.Errorf("nil body: got %q, want %q", got, "")
}
if got := s.extractResponseSummary([]byte{}); got != "" {
t.Errorf("empty body: got %q, want %q", got, "")
}
}
func TestExtractResponseSummary_InvalidJSON(t *testing.T) {
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`not json`))
if got != "" {
t.Errorf("invalid JSON: got %q, want %q", got, "")
}
}
func TestExtractResponseSummary_NoResultKey(t *testing.T) {
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`{"error": "oops"}`))
if got != "" {
t.Errorf("no result key: got %q, want %q", got, "")
}
}
func TestExtractResponseSummary_EmptyResult(t *testing.T) {
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`{"result": {}}`))
if got != "" {
t.Errorf("empty result: got %q, want %q", got, "")
}
}
func TestExtractResponseSummary_NoPartsKey(t *testing.T) {
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`{"result": {"data": "hello"}}`))
if got != "" {
t.Errorf("no parts key: got %q, want %q", got, "")
}
}
func TestExtractResponseSummary_EmptyPartsArray(t *testing.T) {
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`{"result": {"parts": []}}`))
if got != "" {
t.Errorf("empty parts: got %q, want %q", got, "")
}
}
func TestExtractResponseSummary_PartsWithText(t *testing.T) {
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`{"result": {"parts": [{"text": "Hello world"}]}}`))
if got != "Hello world" {
t.Errorf("got %q, want %q", got, "Hello world")
}
}
func TestExtractResponseSummary_MultipleParts(t *testing.T) {
// The function returns the FIRST non-empty text it finds.
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`{"result": {"parts": [{"text": ""}, {"text": "second"}]}}`))
if got != "second" {
t.Errorf("got %q, want %q", got, "second")
}
}
func TestExtractResponseSummary_NonStringText(t *testing.T) {
s := New(nil, nil)
got := s.extractResponseSummary([]byte(`{"result": {"parts": [{"text": 42}]}}`))
if got != "" {
t.Errorf("non-string text: got %q, want %q", got, "")
}
}
// ── isEmptyResponse coverage ─────────────────────────────────────────────────────
func TestIsEmptyResponse_NilAndEmpty(t *testing.T) {
if !isEmptyResponse(nil) {
t.Error("nil body should be empty")
}
if !isEmptyResponse([]byte{}) {
t.Error("empty body should be empty")
}
}
func TestIsEmptyResponse_SentinelMarkers(t *testing.T) {
cases := []string{
`(no response generated)`,
`"text": "(no response generated)"`,
`"text":""`,
`"text": ""`,
}
for _, marker := range cases {
body := []byte(`{"result":{"parts":[{"text":"` + marker + `"}]}}`)
if !isEmptyResponse(body) {
t.Errorf("body with marker %q should be empty", marker)
}
}
}
func TestIsEmptyResponse_RealContent(t *testing.T) {
// Any body containing a sentinel marker is treated as empty.
// Bodies with no marker and with non-empty text are NOT empty.
cases := []struct {
body string
isEmpty bool
}{
{`{"result":{"parts":[{"text":"Hello world"}]}}`, false},
{`{"result":{"parts":[{"text":"goodbye"}]}}`, false},
{`{"text":"hello"}`, false},
{`{"result":{"parts":[]}}`, false},
// sentinel markers trigger empty=true
{`{"result":{"parts":[{"text":"(no response generated) plus more"}]}}`, true},
}
for _, tc := range cases {
got := isEmptyResponse([]byte(tc.body))
if got != tc.isEmpty {
t.Errorf("isEmptyResponse(%q) = %v, want %v", tc.body, got, tc.isEmpty)
}
}
}
func TestIsEmptyResponse_PartialMarker(t *testing.T) {
// The marker must appear as a complete substring. Partial matches don't count.
body := []byte(`{"result":{"parts":[{"text":"(no response gen"}]}}`)
if isEmptyResponse(body) {
t.Error(`partial marker "(no response gen" should NOT match`)
}
}
// ── maybeSweepPhantomBusy coverage ─────────────────────────────────────────────
// phantomSweepInterval = 5 minutes. maybeSweepPhantomBusy skips the DB query
// when lastSweepAt is within the interval.
func TestMaybeSweepPhantomBusy_SkipsWithinInterval(t *testing.T) {
mock := setupTestDB(t)
// No DB calls expected since we skip within the interval.
s := New(nil, nil)
s.mu.Lock()
s.lastSweepAt = time.Now() // just swept
s.mu.Unlock()
s.maybeSweepPhantomBusy(context.Background())
// Verify no DB calls were made.
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unexpected DB call: %v", err)
}
}
func TestMaybeSweepPhantomBusy_RunsWhenStale(t *testing.T) {
mock := setupTestDB(t)
// Return a row so the sweep logs one reset.
rows := sqlmock.NewRows([]string{"id", "name"}).
AddRow("ws-phantom", "Phantom Agent")
mock.ExpectQuery(`UPDATE workspaces`).
WillReturnRows(rows)
s := New(nil, nil)
s.mu.Lock()
s.lastSweepAt = time.Now().Add(-6 * time.Minute) // older than 5 min interval
s.mu.Unlock()
s.maybeSweepPhantomBusy(context.Background())
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet DB expectations: %v", err)
}
// Verify lastSweepAt was updated.
s.mu.RLock()
defer s.mu.RUnlock()
if time.Since(s.lastSweepAt) > time.Second {
t.Error("lastSweepAt should be updated to time.Now() after a sweep")
}
}
func TestMaybeSweepPhantomBusy_StaleFirstSweep(t *testing.T) {
// Zero time.Time is treated as "never swept" — time.Since(zero) is many years,
// which is > 5 min, so the sweep runs on first call.
mock := setupTestDB(t)
rows := sqlmock.NewRows([]string{"id", "name"})
mock.ExpectQuery(`UPDATE workspaces`).
WillReturnRows(rows)
s := New(nil, nil)
// lastSweepAt is zero (never swept) — this should trigger the sweep.
s.maybeSweepPhantomBusy(context.Background())
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet DB expectations: %v", err)
}
}
// ── sweepPhantomBusy DB-error coverage ──────────────────────────────────────────
func TestSweepPhantomBusy_QueryError(t *testing.T) {
mock := setupTestDB(t)
mock.ExpectQuery(`UPDATE workspaces`).
WillReturnError(errDBDown)
s := New(nil, nil)
// Should not panic — error is logged and function returns.
s.sweepPhantomBusy(context.Background())
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet DB expectations: %v", err)
}
}
func TestSweepPhantomBusy_RowsError(t *testing.T) {
// Query succeeds but rows.Next() returns an error.
mock := setupTestDB(t)
rows := sqlmock.NewRows([]string{"id", "name"}).
AddRow("ws-1", "Test Agent").
RowError(0, errDBDown)
mock.ExpectQuery(`UPDATE workspaces`).
WillReturnRows(rows)
s := New(nil, nil)
s.sweepPhantomBusy(context.Background())
if err := mock.ExpectationsWereMet(); err != nil {
t.Errorf("unmet DB expectations: %v", err)
}
}