molecule-code-reviewer
  • Joined on 2026-06-02
molecule-code-rev… pushed to main at molecule-ai/molecule-core 2026-06-09 17:23:20 +00:00
b1c623210c Merge pull request 'feat(prod-deploy): tolerate a quarantined straggler minority in the fleet rollout' (#2484) from fix/deploy-straggler-tolerance into main
a7bdb8d860 feat(prod-deploy): tolerate a quarantined straggler minority in the fleet rollout
Compare 2 commits »
molecule-code-rev… merged pull request molecule-ai/molecule-core#2484 2026-06-09 17:23:16 +00:00
feat(prod-deploy): tolerate a quarantined straggler minority in the fleet rollout
molecule-code-rev… merged pull request molecule-ai/molecule-core#2472 2026-06-09 15:51:44 +00:00
fix(canvas): envelope flies dot→dot with a grow-then-shrink arc
molecule-code-rev… pushed to main at molecule-ai/molecule-core 2026-06-09 15:51:42 +00:00
675ab9df83 Merge pull request 'fix(canvas): envelope flies dot→dot with a grow-then-shrink arc' (#2472) from fix/envelope-anchor-dot-and-scale into main
4f0f7b24c3 fix(canvas): envelope flies dot→dot with a grow-then-shrink arc
Compare 2 commits »
molecule-code-rev… approved molecule-ai/molecule-core#2414 2026-06-07 22:43:58 +00:00
fix(workspace): recover status from "failed" on live heartbeat

APPROVED on bde3248d2d02ec03fa868d41968cd71a82c994e5 — rebased onto clean main (earlier red was a clobbered base from a cross-branch cp; now purely additive, full handlers suite green locally).

molecule-code-rev… approved molecule-ai/molecule-core#2414 2026-06-07 22:11:20 +00:00
fix(workspace): recover status from "failed" on live heartbeat

APPROVED — recovers a slow-but-healthy workspace from a premature provision-timeout 'failed' flip. Mechanism named (minimax preflight > 10m budget); a live heartbeat is authoritative. Guarded transition; mirrors the existing provisioning/awaiting_agent recoveries. Tested.

molecule-code-rev… approved molecule-ai/molecule-core#2410 2026-06-07 21:07:42 +00:00
fix(workspace): round-trip compute.provider (+ data_persistence) in GET

APPROVED — round-trips compute.provider + data_persistence in GET (were forwarded but dropped from serialization). Makes the core#2404 provider badge functional. Omit-when-empty preserves byte-identical output for existing rows (exact-JSON test unchanged). 2 new regression tests green.

molecule-code-rev… approved molecule-ai/molecule-core#2404 2026-06-07 20:30:56 +00:00
feat(canvas): surface + select per-workspace cloud provider

APPROVED — re-approve on 88a310f367030ff6b98bd7e737f7c83f90af4bc2 (added SaaS picker test coverage). Build + vitest green.

molecule-code-rev… approved molecule-ai/molecule-core#2404 2026-06-07 20:22:08 +00:00
feat(canvas): surface + select per-workspace cloud provider

APPROVED — surfaces the per-workspace cloud provider in the canvas (read-only badge + SaaS-only create picker). Backend already supports compute.provider end-to-end; this is the UI layer. Correctly preserves provider on Container-Config Save (avoids wiping the persisted value) and gates both the picker and the payload field on isSaaS. Build + full vitest green.

chore: pin runtime 0.3.10 (cross-cloud register fix)

Pin runtime 0.3.10 (cross-cloud fix #96). One-line .runtime-version bump.

chore: bump 0.3.10 to publish the cross-cloud register fix (#96)

Version bump 0.3.9→0.3.10 to publish #96 (cross-cloud fix). Trivial.

fix(register): advertise platform-injected MOLECULE_WORKSPACE_URL for cross-cloud (runtime#95)

Small, safe, unit-tested: resolve_workspace_url prefers a platform-injected MOLECULE_WORKSPACE_URL (verbatim) else the existing HOSTNAME/ip fallback — same-cloud workspaces unchanged. Fixes the cross-cloud register-400 (runtime#95). CI green.

fix(publish-platform-agent): provenance/sbom off so the image lands in ECR

Workflow-only fix: provenance/sbom off so buildx pushes a plain manifest ECR surfaces (vs the OCI index that left the fresh repo empty). Correct + minimal. Approving.

fix(publish-platform-agent): keep molecule-ai/ namespace in ECR repo_path

Confirmed root cause: double-strip dropped the molecule-ai/ namespace so describe/create != push target; build+smoke already proven to pass in the failed run. One-line fix (strip host only) + repo pre-created. Approving.

feat(platform-agent): build the dedicated image in this repos publish pipeline (Phase 3b, re-homed)

Independent review confirmed: re-homes 3b into this repos existing publish pipeline (reuses ECR creds + runners, no new secret); Dockerfile FROM the just-pushed base, Node 20 pinned, molecule-mcp from the anonymous org npm registry on PATH; publish decoupled from activation (no auto-promote); only 2 new/append files, no config/providers change. Substantive CI green; providers-projection drift is pre-existing on main (non-required). Approving.

molecule-code-rev… approved molecule-ai/molecule-core#2382 2026-06-06 23:25:11 +00:00
feat(approval-gate): wire gateDestructive into live destructive handlers (Phase 4b)

Independent review confirmed: scope is centralized + default-off (MOLECULE_PLATFORM_APPROVAL_GATE) + org-token-only (org_token_id), so ordinary workspace/CP callers are byte-identical; nil EventEmitter handled (pending row still persisted); context-sensitive request_hash (key/name); 3 unit tests + existing suites green. Approving.

molecule-code-rev… approved molecule-ai/molecule-core#2371 2026-06-06 22:13:47 +00:00
feat: install platform agent as org root (Phase 1)

Independent review confirmed: install op idempotently makes the platform agent the org root, re-parents the existing root, and migrates the 2 org-anchor tables (org_api_tokens + org_plugin_allowlist) in one tx; real-PG integration test proves re-parent + anchor migration + orgRootID/sameOrg resolution + idempotency; allowlisted in the bulk-INSERT guard. Required checks green. Approving.

molecule-code-rev… approved molecule-ai/molecule-core#2372 2026-06-06 18:23:18 +00:00
feat: approval-gate infrastructure for destructive ops (Phase 4)

Independent review confirmed: race-safe consume via FOR UPDATE SKIP LOCKED, dedup via conditional INSERT, context-isolated request_hash, best-effort broadcast, infra-only (no live wiring). Real-PG integration proves the full single-use cycle. Approving.

molecule-code-rev… approved molecule-ai/molecule-core#2361 2026-06-06 18:22:03 +00:00
feat: platform-agent participant kind (Phase 0)

Independent review confirmed: backward-compatible migration (NOT VALID then VALIDATE), COALESCE upsert never downgrades a platform row, 409 on constraint violation, real-PG integration test proves the platform=root invariant. Build+tests green. Approving.