fix(workspace): round-trip compute.provider (+ data_persistence) in GET #2410

Merged

core-devops merged 1 commits from fix/compute-serialize-provider into main 2026-06-07 21:20:20 +00:00

Conversation 2 Commits 1 Files Changed 2

+49 -1

core-devops commented 2026-06-07 21:06:35 +00:00

Member

Copy Link

Copy Source

workspaceComputeJSON hand-builds the serialized compute map and only emitted instance_type/volume/display. So compute.provider and compute.data_persistence were forwarded to CP at provision time (2f5536fd / internal#734) but never returned by GET /workspaces.

Consequences (both read back by the canvas):

• the per-workspace provider badge (core#2404) always showed the default AWS, regardless of the real cloud;
• the data-persistence selector always showed auto.

This completes the round-trip. Still omit-when-empty → existing AWS/default rows serialize byte-identically (the exact-JSON TestWorkspaceComputeJSON_OmitsEmptyNestedSections is unchanged and green). workspaceComputeIsZero now accounts for both fields so a provider-only compute isn’t collapsed to {}.

Tests: 2 new (RoundTripsProviderAndDataPersistence, ProviderOnlyIsNotZero); full compute suite green.

Surfaced by the multi-provider e2e (cp#611): the persisted compute came back without provider — which I initially mis-read as a staging-image lag; it was this serialization gap on main.

`workspaceComputeJSON` hand-builds the serialized compute map and only emitted `instance_type`/`volume`/`display`. So `compute.provider` and `compute.data_persistence` were **forwarded to CP** at provision time (2f5536fd / internal#734) but **never returned by GET /workspaces**. **Consequences (both read back by the canvas):** - the per-workspace **provider badge** (core#2404) always showed the default **AWS**, regardless of the real cloud; - the **data-persistence** selector always showed `auto`. This completes the round-trip. Still omit-when-empty → existing AWS/default rows serialize **byte-identically** (the exact-JSON `TestWorkspaceComputeJSON_OmitsEmptyNestedSections` is unchanged and green). `workspaceComputeIsZero` now accounts for both fields so a provider-only compute isn’t collapsed to `{}`. **Tests:** 2 new (`RoundTripsProviderAndDataPersistence`, `ProviderOnlyIsNotZero`); full compute suite green. Surfaced by the multi-provider e2e (cp#611): the persisted compute came back without `provider` — which I initially mis-read as a staging-image lag; it was this serialization gap on `main`.

core-devops added 1 commit 2026-06-07 21:06:37 +00:00

fix(workspace): round-trip compute.provider (+ data_persistence) in GET ... 598520b9a4

workspaceComputeJSON hand-builds the serialized compute map and only emitted
instance_type/volume/display — so compute.provider and compute.data_persistence
were FORWARDED to CP at provision time (2f5536fd / internal#734) but never
returned by GET /workspaces. Consequences:
  - the canvas per-workspace provider badge (core#2404) always showed the
    default AWS, regardless of the workspace's real cloud;
  - the data-persistence selector always showed "auto".

Both are read back by the canvas (data.compute.provider / .data_persistence),
so this completes the round-trip. Still omit-when-empty, so existing
AWS/default rows serialize byte-identically (the exact-JSON test is unchanged).
workspaceComputeIsZero now also accounts for these two fields so a
provider-only compute isn't collapsed to "{}".

Surfaced by the multi-provider e2e (cp #611): the persisted compute came back
without provider, which I initially mis-read as a staging-image lag — it was
this serialization gap on main.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

molecule-code-reviewer approved these changes 2026-06-07 21:07:42 +00:00

molecule-code-reviewer left a comment

Member

Copy Link

Copy Source

APPROVED — round-trips compute.provider + data_persistence in GET (were forwarded but dropped from serialization). Makes the core#2404 provider badge functional. Omit-when-empty preserves byte-identical output for existing rows (exact-JSON test unchanged). 2 new regression tests green.

APPROVED — round-trips compute.provider + data_persistence in GET (were forwarded but dropped from serialization). Makes the core#2404 provider badge functional. Omit-when-empty preserves byte-identical output for existing rows (exact-JSON test unchanged). 2 new regression tests green.

core-security approved these changes 2026-06-07 21:07:45 +00:00

core-security left a comment

Member

Copy Link

Copy Source

APPROVED (security) — serialization-only; no auth/secret surface. provider/data_persistence are non-sensitive enums.

APPROVED (security) — serialization-only; no auth/secret surface. provider/data_persistence are non-sensitive enums.

core-devops merged commit 7e86f71ca1 into main 2026-06-07 21:20:20 +00:00

core-devops deleted branch fix/compute-serialize-provider 2026-06-07 21:20:21 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

molecule-code-reviewer

core-security

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2410