molecule-ai/molecule-core
52
0
Fork 2
Code Issues 182 Pull Requests 52 Actions Packages Projects Releases Wiki Activity

test(e2e): make org-template import spec fail-closed (#2809) #2811

Closed
agent-dev-a wants to merge 1 commits from fix/2809-org-template-import-fail-closed into main
pull from: fix/2809-org-template-import-fail-closed
merge into: molecule-ai:main
Conversation 0 Commits 1 Files Changed 1
+24 -11
agent-dev-a commented 2026-06-14 01:47:08 +00:00
Member
Copy Link
Copy Source

What

Closes #2809.

canvas/e2e/org-template-import.spec.ts skipped both tests whenever /org/templates returned an empty list, silently removing the only browser-level coverage for the org-template import surface.

  • Added a suite-level beforeAll that fetches /org/templates and asserts at least one template exists, failing with a clear setup-error message instead of skipping.
  • Removed the per-test test.skip(orgs.length === 0) guards.
  • Shared the fetched org list between tests.

Component-level empty-state tests continue to cover the no-templates UI path; this E2E now requires a populated template registry (consistent with tests/e2e/test_dev_mode.sh).

Approach

Chose the fail-closed precondition route rather than filesystem seeding because /org/templates is a static directory scan and the E2E job is expected to run after the template registry is populated by the existing setup flow.

Test plan

  • npx eslint e2e/org-template-import.spec.ts passes.
  • Full Playwright run requires the E2E Chat job infra; the change will be exercised by CI.

Fixes #2809

🤖 Generated with Claude Code

## What Closes #2809. `canvas/e2e/org-template-import.spec.ts` skipped both tests whenever `/org/templates` returned an empty list, silently removing the only browser-level coverage for the org-template import surface. - Added a suite-level `beforeAll` that fetches `/org/templates` and asserts at least one template exists, failing with a clear setup-error message instead of skipping. - Removed the per-test `test.skip(orgs.length === 0)` guards. - Shared the fetched org list between tests. Component-level empty-state tests continue to cover the no-templates UI path; this E2E now requires a populated template registry (consistent with `tests/e2e/test_dev_mode.sh`). ## Approach Chose the fail-closed precondition route rather than filesystem seeding because `/org/templates` is a static directory scan and the E2E job is expected to run after the template registry is populated by the existing setup flow. ## Test plan - `npx eslint e2e/org-template-import.spec.ts` passes. - Full Playwright run requires the E2E Chat job infra; the change will be exercised by CI. Fixes #2809 🤖 Generated with [Claude Code](https://claude.com/claude-code)
agent-dev-a added 1 commit 2026-06-14 01:47:08 +00:00
test(e2e): make org-template import spec fail-closed (#2809)
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
security-review / approved (pull_request_target) Failing after 7s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 12s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 5s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
E2E Chat / detect-changes (pull_request) Successful in 30s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 19s
Details
qa-review / approved (pull_request_target) Failing after 21s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 24s
Details
CI / Detect changes (pull_request) Successful in 33s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 37s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 34s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Platform (Go) (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 42s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 34s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
CI / Canvas (Next.js) (pull_request) Successful in 3m55s
Details
CI / Canvas Deploy Status (pull_request) Successful in 0s
Details
CI / all-required (pull_request) Successful in 3s
Details
df0dbe9bf6 
canvas/e2e/org-template-import.spec.ts skipped both tests whenever
/org/templates returned an empty list, silently removing the only
browser-level coverage for the org-template import surface.

- Add a suite-level beforeAll that fetches /org/templates and asserts at
  least one template exists, failing with a clear setup-error message
  instead of skipping.
- Remove the per-test test.skip(orgs.length === 0) guards.
- Share the fetched org list between tests.

Component-level empty-state tests continue to cover the no-templates UI
path; this E2E now requires a populated template registry.

Fixes #2809

Co-Authored-By: Claude <noreply@anthropic.com>
agent-dev-a closed this pull request 2026-06-14 01:49:39 +00:00
Some optional checks failed
CI / Python Lint & Test (pull_request) Successful in 5s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 9s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 10s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Harness Replays / detect-changes (pull_request) Successful in 7s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
security-review / approved (pull_request_target) Failing after 7s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 12s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Required
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 5s
Required
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 19s
Details
E2E Chat / detect-changes (pull_request) Successful in 30s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 19s
Details
qa-review / approved (pull_request_target) Failing after 21s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 24s
Details
CI / Detect changes (pull_request) Successful in 33s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 37s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 34s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Platform (Go) (pull_request) Successful in 4s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 3s
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 42s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 34s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
CI / Canvas (Next.js) (pull_request) Successful in 3m55s
Details
CI / Canvas Deploy Status (pull_request) Successful in 0s
Details
CI / all-required (pull_request) Successful in 3s
Required
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2811
Delete Branch "fix/2809-org-template-import-fail-closed"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?