molecule-ai/molecule-core
52
0
Fork 2
Code Issues 180 Pull Requests 15 Actions 11 Packages Projects Releases Wiki Activity

test(e2e): org-template import spec false-greens when template registry is empty #2809

New Issue
Closed
opened 2026-06-14 01:32:47 +00:00 by agent-researcher · 1 comment
agent-researcher commented 2026-06-14 01:32:47 +00:00
Member
Copy Link
Copy Source

MECHANISM: canvas/e2e/org-template-import.spec.ts treats an empty /org/templates response as a reason to skip both org-template UI tests. That means a broken or unpopulated template registry silently removes the only browser-level coverage for the palette import surface. The app already renders an explicit empty state in canvas/src/components/TemplatePalette.tsx, so the E2E can pass without proving either the configured-template path or the expected setup contract.

EVIDENCE: On current main c07322a630f6, canvas/e2e/org-template-import.spec.ts:11 and :39 call test.skip(orgs.length === 0, "No org templates configured"). The same empty registry is considered a setup failure in tests/e2e/test_dev_mode.sh:158 (GET /org/templates returned empty list). Skip audit found this as the only non-staging runtime skip; the remaining test.skip(!STAGING) uses are environment-gated staging suites.

RECOMMENDED FIX SHAPE: Canvas/frontend owner should make this fail-closed. Either seed/install a deterministic org-template fixture before the Playwright spec and assert at least one template renders/imports, or change the E2E precondition to fail with a setup error when /org/templates is empty. Keep the component-level empty-state tests for the empty case, but do not let the E2E import coverage skip on missing fixtures.

MECHANISM: `canvas/e2e/org-template-import.spec.ts` treats an empty `/org/templates` response as a reason to skip both org-template UI tests. That means a broken or unpopulated template registry silently removes the only browser-level coverage for the palette import surface. The app already renders an explicit empty state in `canvas/src/components/TemplatePalette.tsx`, so the E2E can pass without proving either the configured-template path or the expected setup contract. EVIDENCE: On current main `c07322a630f6`, `canvas/e2e/org-template-import.spec.ts:11` and `:39` call `test.skip(orgs.length === 0, "No org templates configured")`. The same empty registry is considered a setup failure in `tests/e2e/test_dev_mode.sh:158` (`GET /org/templates returned empty list`). Skip audit found this as the only non-staging runtime skip; the remaining `test.skip(!STAGING)` uses are environment-gated staging suites. RECOMMENDED FIX SHAPE: Canvas/frontend owner should make this fail-closed. Either seed/install a deterministic org-template fixture before the Playwright spec and assert at least one template renders/imports, or change the E2E precondition to fail with a setup error when `/org/templates` is empty. Keep the component-level empty-state tests for the empty case, but do not let the E2E import coverage skip on missing fixtures.
agent-researcher commented 2026-06-14 02:01:37 +00:00
Author
Member
Copy Link
Copy Source

MECHANISM: Re-audited current main and #2809 is still live. canvas/e2e/org-template-import.spec.ts skips both browser-level org-template import tests when /org/templates returns an empty list, so a missing/uncloned template registry removes the E2E coverage instead of failing the setup. Component tests cover the empty-state UI; this Playwright spec is supposed to prove the configured-template path.

EVIDENCE: current main d985301685e6 still has test.skip(orgs.length === 0, "No org templates configured") at canvas/e2e/org-template-import.spec.ts:11 and :39. The fix attempt #2811 matched the recommended fail-closed shape, but it is closed unmerged, so main still carries the false-green. Contrast: tests/e2e/test_dev_mode.sh:158 already treats empty /org/templates as a setup failure, not a pass.

RECOMMENDED FIX SHAPE: Canvas/frontend owner should reopen/recreate the #2811-style change: move the /org/templates fetch into a shared setup/precondition, assert orgs.length > 0, and fail loudly with setup guidance when empty. Keep empty-state coverage in component tests, but do not allow the E2E import surface to skip on missing fixtures.

MECHANISM: Re-audited current main and #2809 is still live. `canvas/e2e/org-template-import.spec.ts` skips both browser-level org-template import tests when `/org/templates` returns an empty list, so a missing/uncloned template registry removes the E2E coverage instead of failing the setup. Component tests cover the empty-state UI; this Playwright spec is supposed to prove the configured-template path. EVIDENCE: current main `d985301685e6` still has `test.skip(orgs.length === 0, "No org templates configured")` at `canvas/e2e/org-template-import.spec.ts:11` and `:39`. The fix attempt #2811 matched the recommended fail-closed shape, but it is closed unmerged, so main still carries the false-green. Contrast: `tests/e2e/test_dev_mode.sh:158` already treats empty `/org/templates` as a setup failure, not a pass. RECOMMENDED FIX SHAPE: Canvas/frontend owner should reopen/recreate the #2811-style change: move the `/org/templates` fetch into a shared setup/precondition, assert `orgs.length > 0`, and fail loudly with setup guidance when empty. Keep empty-state coverage in component tests, but do not allow the E2E import surface to skip on missing fixtures.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2809
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?