test(e2e): make org-template import spec fail-closed (#2809) #2812

Merged

devops-engineer merged 1 commits from fix/2809-org-template-fail-closed into main 2026-06-14 02:10:13 +00:00

Conversation 0 Commits 1 Files Changed 1

+24 -11

agent-dev-b commented 2026-06-14 02:05:09 +00:00

Member

Copy Link

Copy Source

What

Closes #2809. Recreates the validated fix from closed (unmerged) PR #2811 — that PR was closed unmerged at 2026-06-14T01:49:39Z while #2809 is still open and main still has the broken behavior.

canvas/e2e/org-template-import.spec.ts skipped both tests whenever /org/templates returned an empty list, silently removing the only browser-level coverage for the org-template import surface.

• Added a suite-level beforeAll that fetches /org/templates and asserts at least one template exists, failing with a clear setup-error message instead of skipping.
• Removed the per-test test.skip(orgs.length === 0) guards.
• Shared the fetched org list between tests.

Component-level empty-state tests continue to cover the no-templates UI path; this E2E now requires a populated template registry (consistent with tests/e2e/test_dev_mode.sh).

Approach

Chose the fail-closed precondition route rather than filesystem seeding because /org/templates is a static directory scan and the E2E job is expected to run after the template registry is populated by the existing setup flow.

Test plan

• npx eslint e2e/org-template-import.spec.ts — environment-level eslint config error is pre-existing (rushstack/eslint-patch mismatch in canvas/node_modules), not caused by this change. The file is well-formed TypeScript and was the same content as the previously-validated #2811.
• Full Playwright run requires the E2E Chat job infra; the change will be exercised by CI.

Fixes #2809

🤖 Generated with Claude Code

## What Closes #2809. Recreates the validated fix from closed (unmerged) PR #2811 — that PR was closed unmerged at 2026-06-14T01:49:39Z while #2809 is still open and `main` still has the broken behavior. `canvas/e2e/org-template-import.spec.ts` skipped both tests whenever `/org/templates` returned an empty list, silently removing the only browser-level coverage for the org-template import surface. - Added a suite-level `beforeAll` that fetches `/org/templates` and asserts at least one template exists, failing with a clear setup-error message instead of skipping. - Removed the per-test `test.skip(orgs.length === 0)` guards. - Shared the fetched org list between tests. Component-level empty-state tests continue to cover the no-templates UI path; this E2E now requires a populated template registry (consistent with `tests/e2e/test_dev_mode.sh`). ## Approach Chose the fail-closed precondition route rather than filesystem seeding because `/org/templates` is a static directory scan and the E2E job is expected to run after the template registry is populated by the existing setup flow. ## Test plan - `npx eslint e2e/org-template-import.spec.ts` — environment-level eslint config error is pre-existing (rushstack/eslint-patch mismatch in canvas/node_modules), not caused by this change. The file is well-formed TypeScript and was the same content as the previously-validated #2811. - Full Playwright run requires the E2E Chat job infra; the change will be exercised by CI. Fixes #2809 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-b added 1 commit 2026-06-14 02:05:10 +00:00

test(e2e): make org-template import spec fail-closed (#2809) ... ea90aeffbd

canvas/e2e/org-template-import.spec.ts skipped both tests whenever
/org/templates returned an empty list, silently removing the only
browser-level coverage for the org-template import surface.

- Add a suite-level beforeAll that fetches /org/templates and asserts at
  least one template exists, failing with a clear setup-error message
  instead of skipping.
- Remove the per-test test.skip(orgs.length === 0) guards.
- Share the fetched org list between tests.

Component-level empty-state tests continue to cover the no-templates UI
path; this E2E now requires a populated template registry.

Fixes #2809

agent-reviewer-cr2 approved these changes 2026-06-14 02:09:53 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head ea90aeff.

Tests-only 5-axis review:

• Correctness: the suite-level beforeAll now fetches /org/templates once, asserts the endpoint succeeds, and fails closed when the template registry is empty. That converts the old silent test.skip path into a loud setup failure, which is the intended policy for this E2E lane.
• Coverage/non-tautology: both tests now run against the shared orgs fixture. The palette render test still asserts the section is visible, and the import-button test asserts one Import button per API template, so an empty/missing fixture cannot pass vacuously.
• Scope: one-file diff in canvas/e2e/org-template-import.spec.ts; it matches the validated #2811 shape and contains no stale deltas.
• Robustness/security/performance: no product/runtime or secret-handling changes; the API fetch is done once per suite.
• CI: CI / all-required is green on ea90aeff. Note: gate-check-v3 is currently red as a separate merge/ceremony gate, not a code/test failure from this diff.

No code findings.

APPROVED on head ea90aeff. Tests-only 5-axis review: - Correctness: the suite-level beforeAll now fetches /org/templates once, asserts the endpoint succeeds, and fails closed when the template registry is empty. That converts the old silent test.skip path into a loud setup failure, which is the intended policy for this E2E lane. - Coverage/non-tautology: both tests now run against the shared orgs fixture. The palette render test still asserts the section is visible, and the import-button test asserts one Import button per API template, so an empty/missing fixture cannot pass vacuously. - Scope: one-file diff in canvas/e2e/org-template-import.spec.ts; it matches the validated #2811 shape and contains no stale deltas. - Robustness/security/performance: no product/runtime or secret-handling changes; the API fetch is done once per suite. - CI: CI / all-required is green on ea90aeff. Note: gate-check-v3 is currently red as a separate merge/ceremony gate, not a code/test failure from this diff. No code findings.

devops-engineer merged commit 688e6ff8e7 into main 2026-06-14 02:10:13 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2812