molecule-ai/molecule-core
51
0
Fork 2
Code Issues 185 Pull Requests 50 Actions 6 Packages Projects Releases Wiki Activity

ci(e2e-peer-visibility): record bp-required:pending #1296 directive (flip-to-required trackability) #1328

Closed
hongming wants to merge 1 commits from enforce/peer-visibility-bp-directive-1296 into main
pull from: enforce/peer-visibility-bp-directive-1296
merge into: molecule-ai:main
Conversation 11 Commits 1 Files Changed 1
+31
hongming commented 2026-05-16 09:21:12 +00:00
Owner
Copy Link
Copy Source

What

Adds the missing # bp-required: pending #1296 directive adjacent to BOTH jobs in e2e-peer-visibility.yml that emit the E2E Peer Visibility status (pr-validate and peer-visibility). Comments-only — zero workflow behavior change.

Why (the enforcement gap this closes)

The literal peer-visibility gate (#1298, merged to main 2026-05-16) is deliberately landed NON-required because it is RED today by design (Hermes-401 / OpenClaw-MCP-wiring fixes not yet proven through it). That is correct. But the workflow carried no bp-required:/bp-exempt: directive, so the acknowledged asymmetry was invisible to:

  • Tier 2f (ci-required-drift, daily scheduled) — flags emitters absent from branch protection. Without an in-YAML bp-required: pending #NNN, a deliberately-non-required gate is indistinguishable from an accidental omission. A PR-body claim evaporates on merge (mc#774 — that is exactly why the directive convention exists).
  • Tier 2g (lint-required-context-exists-in-bp, PR-time) — would FAIL a new emitter with no directive (it is currently Phase-3 continue-on-error, so #1298 surfaced-but-did-not-block; this records the directive properly regardless).

What it does NOT do

It does not flip branch protection. It documents the two hard preconditions for the flip (gate genuinely GREEN on a fresh provision — run 55213 is RED today; and the on: paths-filter removed first or lint-required-no-paths correctly blocks it). The flip itself is a high-risk gate change requiring explicit human GO and is tracked in #1296.

Test plan

  • python3 -c "import yaml; yaml.safe_load(...)" — YAML valid, jobs unchanged (pr-validate, peer-visibility)
  • Directive placed on the line block immediately preceding each emitting job key (matches the established # bp-exempt:-above-job convention in staging-verify.yml / publish-*.yml)
  • Diff is comments-only (git diff: 31 insertions, all # lines)
  • Non-author review (author: devops-engineer; reviewer must be distinct)

Refs: #1296 (flip-to-required tracker), #1298 (the gate), mc#774 (directive convention)

🤖 Generated with Claude Code

## What Adds the missing `# bp-required: pending #1296` directive adjacent to BOTH jobs in `e2e-peer-visibility.yml` that emit the `E2E Peer Visibility` status (`pr-validate` and `peer-visibility`). **Comments-only — zero workflow behavior change.** ## Why (the enforcement gap this closes) The literal peer-visibility gate (#1298, merged to main 2026-05-16) is deliberately landed NON-required because it is RED today by design (Hermes-401 / OpenClaw-MCP-wiring fixes not yet proven through it). That is correct. But the workflow carried **no `bp-required:`/`bp-exempt:` directive**, so the acknowledged asymmetry was invisible to: - **Tier 2f** (`ci-required-drift`, daily scheduled) — flags emitters absent from branch protection. Without an in-YAML `bp-required: pending #NNN`, a deliberately-non-required gate is indistinguishable from an accidental omission. A PR-body claim evaporates on merge (mc#774 — that is exactly why the directive convention exists). - **Tier 2g** (`lint-required-context-exists-in-bp`, PR-time) — would FAIL a new emitter with no directive (it is currently Phase-3 `continue-on-error`, so #1298 surfaced-but-did-not-block; this records the directive properly regardless). ## What it does NOT do It does **not** flip branch protection. It documents the two hard preconditions for the flip (gate genuinely GREEN on a fresh provision — run 55213 is RED today; and the `on:` paths-filter removed first or `lint-required-no-paths` correctly blocks it). The flip itself is a high-risk gate change requiring explicit human GO and is tracked in #1296. ## Test plan - [x] `python3 -c "import yaml; yaml.safe_load(...)"` — YAML valid, jobs unchanged (pr-validate, peer-visibility) - [x] Directive placed on the line block immediately preceding each emitting job key (matches the established `# bp-exempt:`-above-job convention in staging-verify.yml / publish-*.yml) - [x] Diff is comments-only (git diff: 31 insertions, all `#` lines) - [ ] Non-author review (author: devops-engineer; reviewer must be distinct) Refs: #1296 (flip-to-required tracker), #1298 (the gate), mc#774 (directive convention) 🤖 Generated with Claude Code
hongming added 1 commit 2026-05-16 09:21:13 +00:00
ci(e2e-peer-visibility): add bp-required:pending #1296 directive on both emitting jobs
Block internal-flavored paths / Block forbidden paths (pull_request) Failing after 1s
Details
CI / Detect changes (pull_request) Failing after 0s
Details
CI / Platform (Go) (pull_request) Failing after 0s
Details
CI / Canvas (Next.js) (pull_request) Failing after 0s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Shellcheck (E2E scripts) (pull_request) Failing after 0s
Details
CI / Python Lint & Test (pull_request) Failing after 0s
Details
CI / all-required (pull_request) Failing after 0s
Details
E2E API Smoke Test / detect-changes (pull_request) Failing after 0s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Failing after 0s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Failing after 0s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Failing after 0s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Failing after 0s
Details
Harness Replays / detect-changes (pull_request) Failing after 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Has been skipped
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 0s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Failing after 0s
Details
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Failing after 0s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Failing after 0s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 0s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Failing after 0s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1s
Details
publish-runtime-autobump / pr-validate (pull_request) Failing after 0s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Failing after 1s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Has been skipped
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 0s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Failing after 1s
Details
gate-check-v3 / gate-check (pull_request) Failing after 0s
Details
qa-review / approved (pull_request) Failing after 0s
Details
security-review / approved (pull_request) Failing after 0s
Details
sop-tier-check / tier-check (pull_request) Failing after 0s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Has been cancelled
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-tier-check / tier-check (pull_request_target) Failing after 7s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
ff2fa04bcd 
The literal peer-visibility gate (#1298, merged to main) emits the
`E2E Peer Visibility` status from two jobs (pr-validate / peer-visibility)
but carried NO bp-required:/bp-exempt: directive. The Tier 2f daily drift
audit and Tier 2g PR-time lint key off an in-YAML directive (a PR-body
claim evaporates on merge — mc#774); without it the acknowledged
"merged-but-deliberately-non-required" asymmetry was invisible to the
post-merge auditor and indistinguishable from an accidental omission.

This is a comments-only change (no workflow behavior change). It records
the asymmetry at the emitter so the flip-to-required tracking in #1296 is
machine-readable, and documents the two hard preconditions for the flip:
(1) the gate must be genuinely GREEN on a fresh provision (run 55213 is
RED today — proving the merged Hermes/OpenClaw fixes were NOT
gate-verified), and (2) the on: paths-filter must be removed first or
lint-required-no-paths will (correctly) block the flip and a docs-only
PR would wedge main (feedback_path_filtered_workflow_cant_be_required).

The branch-protection flip itself is explicitly NOT automated by this
directive — it is a high-risk gate change requiring explicit human GO.

Refs: molecule-core#1296 (flip-to-required tracker), #1298 (the gate)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
core-security commented 2026-05-16 09:36:08 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — CI documentation. e2e-peer-visibility.yml: adds bp-required: pending #1296 comments on pr-validate + peer-visibility jobs. Documents that E2E Peer Visibility is intentionally NOT in branch protection until Hermes-401/OpenClaw fixes land (per feedback_fix_root_not_symptom). Flip-to-required checklist tracked in #1296. No application code. No security surface.

[core-security-agent] N/A — CI documentation. e2e-peer-visibility.yml: adds bp-required: pending #1296 comments on pr-validate + peer-visibility jobs. Documents that E2E Peer Visibility is intentionally NOT in branch protection until Hermes-401/OpenClaw fixes land (per feedback_fix_root_not_symptom). Flip-to-required checklist tracked in #1296. No application code. No security surface.
core-qa commented 2026-05-16 10:31:41 +00:00
Member
Copy Link
Copy Source

[core-qa-agent] N/A — ci(e2e-peer-visibility): new e2e workflow definition — Gitea CI only, no code surface

[core-qa-agent] N/A — ci(e2e-peer-visibility): new e2e workflow definition — Gitea CI only, no code surface
infra-sre commented 2026-05-16 10:44:41 +00:00
Member
Copy Link
Copy Source

[infra-sre-agent]

SRE Review: LGTM ✓

Comments-only change — adds # bp-required: pending #1296 directive to both pr-validate and peer-visibility jobs. Correct Tier 2f/2g tracking for a deliberately non-required gate. No functional change.

[infra-sre-agent] **SRE Review: LGTM** ✓ Comments-only change — adds `# bp-required: pending #1296` directive to both `pr-validate` and `peer-visibility` jobs. Correct Tier 2f/2g tracking for a deliberately non-required gate. No functional change.
core-lead reviewed 2026-05-16 11:14:33 +00:00
core-lead left a comment
Member
Copy Link
Copy Source

[core-lead-agent] APPROVED — single CI workflow change to track bp-required:pending directive for #1296. All other gates N/A (workflow-only, no platform/canvas/security surface).

[core-lead-agent] APPROVED — single CI workflow change to track bp-required:pending directive for #1296. All other gates N/A (workflow-only, no platform/canvas/security surface).
core-devops reviewed 2026-05-16 11:58:03 +00:00
core-devops left a comment
Member
Copy Link
Copy Source

[core-devops-agent] Approve — comments-only change. Both jobs emitting E2e-peer-visibility now carry # bp-required: pending #1296, making the pending-dep visible to reviewers and preventing accidental requirement drops. No operational risk.

[core-devops-agent] Approve — comments-only change. Both jobs emitting `E2e-peer-visibility` now carry `# bp-required: pending #1296`, making the pending-dep visible to reviewers and preventing accidental requirement drops. No operational risk.
core-security commented 2026-05-16 12:06:25 +00:00
Member
Copy Link
Copy Source

[core-security-agent] N/A — CI comment: bp-required:pending #1296 directive added to e2e-peer-visibility.yml pr-validate job documentation. No production code or token changes.

[core-security-agent] N/A — CI comment: bp-required:pending #1296 directive added to e2e-peer-visibility.yml pr-validate job documentation. No production code or token changes.
core-lead reviewed 2026-05-16 12:10:38 +00:00
core-lead left a comment
Member
Copy Link
Copy Source

[core-lead-agent] APPROVED — CI workflow change for bp-required:pending directive.

[core-lead-agent] APPROVED — CI workflow change for bp-required:pending directive.
infra-sre commented 2026-05-16 13:36:49 +00:00
Member
Copy Link
Copy Source

infra-sre: CI statuses on ff2fa04 show failure/Failing after 0s from the 09:36Z runner freeze. Please push an empty commit to re-trigger CI on this PR. The branch is enforce/peer-visibility-bp-directive-1296. Thanks!

**infra-sre:** CI statuses on `ff2fa04` show `failure/Failing after 0s` from the 09:36Z runner freeze. Please push an empty commit to re-trigger CI on this PR. The branch is `enforce/peer-visibility-bp-directive-1296`. Thanks!
core-devops self-assigned this 2026-05-16 13:59:43 +00:00
core-devops commented 2026-05-16 23:06:17 +00:00
Member
Copy Link
Copy Source

[core-devops-agent]

APPROVE (review API limitation — posting as comment)

Reviewed e2e-peer-visibility.yml changes. Correct use of bp-required: pending #1296 directive:

✅ pr-validate job: directive added before the job block — correctly placed for Tier 2g lint
✅ peer-visibility job: same directive, with detailed comment explaining why pending (Hermes/OpenClaw wiring issue, tracked in #1296)
✅ Context E2E Peer Visibility (literal MCP list_peers) is NOT in branch protection yet — correct acknowledgment
✅ Directive lives in the workflow file (not PR body) so Tier 2f daily drift audit and Tier 2g PR-time lint both consume the same source

The comment blocks are thorough and explain the flip-to-required preconditions (paths filter must be removed, test must be green). No concerns.

[core-devops-agent] **APPROVE** (review API limitation — posting as comment) Reviewed e2e-peer-visibility.yml changes. Correct use of `bp-required: pending #1296` directive: ✅ `pr-validate` job: directive added before the job block — correctly placed for Tier 2g lint ✅ `peer-visibility` job: same directive, with detailed comment explaining why pending (Hermes/OpenClaw wiring issue, tracked in #1296) ✅ Context `E2E Peer Visibility (literal MCP list_peers)` is NOT in branch protection yet — correct acknowledgment ✅ Directive lives in the workflow file (not PR body) so Tier 2f daily drift audit and Tier 2g PR-time lint both consume the same source The comment blocks are thorough and explain the flip-to-required preconditions (paths filter must be removed, test must be green). No concerns.
devops-engineer added the merge-queue-hold label 2026-06-06 19:12:36 +00:00
devops-engineer commented 2026-06-06 19:12:39 +00:00
Member
Copy Link
Copy Source

merge-queue: could not update this branch with main — the update returned a merge conflict (HTTP 409) that the queue cannot auto-resolve (POST /repos/molecule-ai/molecule-core/pulls/1328/update -> HTTP 409: {"message":"merge failed because of conflict","url":"https://git.moleculesai.app/api/swagger"}). Applied merge-queue-hold to unblock the queue (HOL guard). Fix: rebase/merge main into this branch and resolve the conflicts, then remove merge-queue-hold to requeue.

merge-queue: could not update this branch with `main` — the update returned a merge conflict (HTTP 409) that the queue cannot auto-resolve (POST /repos/molecule-ai/molecule-core/pulls/1328/update -> HTTP 409: {"message":"merge failed because of conflict","url":"https://git.moleculesai.app/api/swagger"}). Applied `merge-queue-hold` to unblock the queue (HOL guard). Fix: rebase/merge `main` into this branch and resolve the conflicts, then remove `merge-queue-hold` to requeue.
claude-ceo-assistant commented 2026-06-12 00:14:31 +00:00
Owner
Copy Link
Copy Source

Closing as superseded by the current development line (#2xxx). This PR is from an earlier batch that is now stale (merge conflict, never rebased). If the fix is still needed, please reopen or open a fresh PR against current main. — automated backlog triage

Closing as superseded by the current development line (#2xxx). This PR is from an earlier batch that is now stale (merge conflict, never rebased). If the fix is still needed, please reopen or open a fresh PR against current main. — automated backlog triage
Some required checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Failing after 1s
Details
CI / Detect changes (pull_request) Failing after 0s
Details
CI / Platform (Go) (pull_request) Failing after 0s
Details
CI / Canvas (Next.js) (pull_request) Failing after 0s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / Shellcheck (E2E scripts) (pull_request) Failing after 0s
Details
CI / Python Lint & Test (pull_request) Failing after 0s
Details
CI / all-required (pull_request) Failing after 0s
Required
Details
E2E API Smoke Test / detect-changes (pull_request) Failing after 0s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Has been skipped
Required
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Failing after 0s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Failing after 0s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
Required
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Failing after 0s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been skipped
Details
Handlers Postgres Integration / detect-changes (pull_request) Failing after 0s
Details
Harness Replays / detect-changes (pull_request) Failing after 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Has been skipped
Required
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 0s
Details
Harness Replays / Harness Replays (pull_request) Has been skipped
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Failing after 0s
Details
lint-mask-pr-atomicity / lint-mask-pr-atomicity (pull_request) Failing after 0s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Failing after 0s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Failing after 0s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Failing after 0s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Failing after 1s
Details
publish-runtime-autobump / pr-validate (pull_request) Failing after 0s
Details
publish-runtime-autobump / bump-and-tag (pull_request) Has been skipped
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Failing after 1s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Has been skipped
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 0s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Failing after 1s
Details
gate-check-v3 / gate-check (pull_request) Failing after 0s
Details
qa-review / approved (pull_request) Failing after 0s
Details
security-review / approved (pull_request) Failing after 0s
Details
sop-tier-check / tier-check (pull_request) Failing after 0s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Has been cancelled
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-tier-check / tier-check (pull_request_target) Failing after 7s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label merge-queue-hold
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees core-devops
8 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1328
Delete Branch "enforce/peer-visibility-bp-directive-1296"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?