test(handlers): add unit tests for buildCloneURL and setIfEmpty (#881) #891

Closed
fullstack-engineer wants to merge 2 commits from feat/881-untested-helpers into staging

2 Commits

Author SHA1 Message Date
0de7bbba19 test(handlers): add unit tests for buildCloneURL and setIfEmpty
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
CI / Detect changes (pull_request) Successful in 1m35s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m37s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
CI / Python Lint & Test (pull_request) Successful in 5s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m3s
CI / Platform (Go) (pull_request) Failing after 2m25s
CI / Canvas (Next.js) (pull_request) Failing after 13m35s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Failing after 6s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
audit-force-merge / audit (pull_request) Has been skipped
- buildCloneURL (artifacts.go): 4 cases covering normal URL construction,
  special characters in token, empty token, and empty repo name.
- setIfEmpty (agent_git_identity.go): 5 cases covering new key insertion,
  existing key preservation, empty-string value preservation, nil map
  safety, and multi-key interaction.

Found by gap analysis across workspace-server/internal/handlers.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 20:54:25 +00:00
718b7e6455 test(canvas): add FilesTab tree + component coverage — 36 cases
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 21s
Harness Replays / detect-changes (pull_request) Successful in 26s
CI / Detect changes (pull_request) Successful in 1m36s
qa-review / approved (pull_request) Failing after 27s
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m35s
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m38s
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m30s
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m27s
security-review / approved (pull_request) Failing after 27s
gate-check-v3 / gate-check (pull_request) Successful in 57s
sop-checklist-gate / gate (pull_request) Successful in 29s
sop-tier-check / tier-check (pull_request) Successful in 25s
Harness Replays / Harness Replays (pull_request) Successful in 8s
CI / Platform (Go) (pull_request) Successful in 11s
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
CI / Python Lint & Test (pull_request) Successful in 11s
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 11s
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 13m41s
CI / Canvas (Next.js) (pull_request) Failing after 15m4s
CI / Canvas Deploy Reminder (pull_request) Has been skipped
CI / all-required (pull_request) Failing after 10s
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Add tree.test.ts (25 cases): buildTree and getIcon pure functions from
FilesTab/tree.ts. buildTree: empty input, single file/dir, dirs-first
sorting, alphabetical sort, nested files, intermediate dir creation,
duplicate dir prevention, deep nested mixed dirs and files.
getIcon: all 9 file-type extensions, case-insensitive, default fallback.

Add FilesTab.test.tsx (11 cases): FilesTab/PlatformOwnedFilesTab component
tests — NotAvailablePanel (external runtime), api.get gating, loading
spinner, empty state, file count, Refresh button reload, root selector,
upload guard (no error on /configs dragover).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
2026-05-13 19:44:29 +00:00