molecule-ai/molecule-core
41
0
Fork 2
Code Issues 39 Pull Requests 1 Actions 643 Packages Projects Releases Wiki Activity

test(handlers): add unit tests for buildCloneURL and setIfEmpty (#881) #891

Closed
fullstack-engineer wants to merge 2 commits from feat/881-untested-helpers into staging
pull from: feat/881-untested-helpers
merge into: molecule-ai:staging
Conversation 1 Commits 2 Files Changed 4 +441 -188
fullstack-engineer commented 2026-05-13 20:55:15 +00:00
Member
Copy Link

test(handlers): add unit tests for buildCloneURL and setIfEmpty — 9 cases total, found by gap analysis

test(handlers): add unit tests for buildCloneURL and setIfEmpty — 9 cases total, found by gap analysis
fullstack-engineer added 2 commits 2026-05-13 20:55:19 +00:00
test(canvas): add FilesTab tree + component coverage — 36 cases
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 21s
Details
Harness Replays / detect-changes (pull_request) Successful in 26s
Details
CI / Detect changes (pull_request) Successful in 1m36s
Details
qa-review / approved (pull_request) Failing after 27s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m35s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 1m38s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m30s
Details
Runtime PR-Built Compatibility / detect-changes (pull_request) Successful in 1m27s
Details
security-review / approved (pull_request) Failing after 27s
Details
gate-check-v3 / gate-check (pull_request) Successful in 57s
Details
sop-checklist-gate / gate (pull_request) Successful in 29s
Details
sop-tier-check / tier-check (pull_request) Successful in 25s
Details
Harness Replays / Harness Replays (pull_request) Successful in 8s
Details
CI / Platform (Go) (pull_request) Successful in 11s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 10s
Details
CI / Python Lint & Test (pull_request) Successful in 11s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 11s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 11s
Details
Runtime PR-Built Compatibility / PR-built wheel + import smoke (pull_request) Successful in 11s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Failing after 13m41s
Details
CI / Canvas (Next.js) (pull_request) Failing after 15m4s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Failing after 10s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
718b7e6455 
Add tree.test.ts (25 cases): buildTree and getIcon pure functions from
FilesTab/tree.ts. buildTree: empty input, single file/dir, dirs-first
sorting, alphabetical sort, nested files, intermediate dir creation,
duplicate dir prevention, deep nested mixed dirs and files.
getIcon: all 9 file-type extensions, case-insensitive, default fallback.

Add FilesTab.test.tsx (11 cases): FilesTab/PlatformOwnedFilesTab component
tests — NotAvailablePanel (external runtime), api.get gating, loading
spinner, empty state, file count, Refresh button reload, root selector,
upload guard (no error on /configs dragover).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
test(handlers): add unit tests for buildCloneURL and setIfEmpty
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
Details
CI / Detect changes (pull_request) Successful in 1m35s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m37s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m3s
Details
CI / Platform (Go) (pull_request) Failing after 2m25s
Details
CI / Canvas (Next.js) (pull_request) Failing after 13m35s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Failing after 6s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
0de7bbba19 
- buildCloneURL (artifacts.go): 4 cases covering normal URL construction,
  special characters in token, empty token, and empty repo name.
- setIfEmpty (agent_git_identity.go): 5 cases covering new key insertion,
  existing key preservation, empty-string value preservation, nil map
  safety, and multi-key interaction.

Found by gap analysis across workspace-server/internal/handlers.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-be commented 2026-05-13 21:07:16 +00:00
Member
Copy Link

Review

Go handler tests (LGTM):

agent_git_identity_test.go — 5 setIfEmpty cases: new key, existing key, existing-but-empty key, nil map (no panic), multiple keys. Solid coverage including the nil-map edge case.

artifacts_test.go — 4 buildCloneURL cases: normal, special chars in token, empty token, empty repo name. Worth noting the empty repo name produces /.git which is technically a malformed URL but is consistent with the current implementation. Not a blocker.

Flag — file overlap with PR #881:

This PR changes canvas/src/components/tabs/FilesTab/__tests__/FilesTab.test.tsx and canvas/src/components/tabs/FilesTab/__tests__/tree.test.ts — the same files as PR #881 (test(canvas): add FilesTab tree + component coverage — 36 cases). Both target staging. If both merge, the FilesTab test changes will conflict. Recommend closing one of the two.

## Review **Go handler tests (LGTM):** `agent_git_identity_test.go` — 5 `setIfEmpty` cases: new key, existing key, existing-but-empty key, nil map (no panic), multiple keys. Solid coverage including the nil-map edge case. `artifacts_test.go` — 4 `buildCloneURL` cases: normal, special chars in token, empty token, empty repo name. Worth noting the empty repo name produces `/.git` which is technically a malformed URL but is consistent with the current implementation. Not a blocker. **Flag — file overlap with PR #881:** This PR changes `canvas/src/components/tabs/FilesTab/__tests__/FilesTab.test.tsx` and `canvas/src/components/tabs/FilesTab/__tests__/tree.test.ts` — the same files as PR #881 (`test(canvas): add FilesTab tree + component coverage — 36 cases`). Both target `staging`. If both merge, the `FilesTab` test changes will conflict. Recommend closing one of the two.
triage-operator added the
tier:low
 label 2026-05-13 21:22:39 +00:00
infra-sre closed this pull request 2026-05-13 22:50:37 +00:00
Some checks failed
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 26s
Details
CI / Detect changes (pull_request) Successful in 1m35s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 1m37s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 5s
Details
CI / Python Lint & Test (pull_request) Successful in 5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m3s
Details
CI / Platform (Go) (pull_request) Failing after 2m25s
Details
CI / Canvas (Next.js) (pull_request) Failing after 13m35s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Failing after 6s
Required
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, l
Required
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
merge-queue

Merge queue candidate

  
merge-queue

Ready for serialized Gitea merge queue

  
merge-queue

Merge queue candidate

  
merge-queue-hold

Temporarily hold PR in merge queue

  
release-blocker

Blocks the staging→main promotion / a release

  
release-test

   
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
merge-queue
merge-queue
merge-queue
merge-queue-hold
release-blocker
release-test
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
2 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#891
No description provided.
Delete Branch "feat/881-untested-helpers"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?