fix(ci): sop-tier-check gracefully handles empty/invalid token (staging) #636

infra-runtime-be · 2026-05-12T01:53:47Z

infra-runtime-be commented

2026-05-12 01:53:47 +00:00

Summary

Same fix as PR #635 (main branch) — applies the token-graceful handling
to staging branch sop-tier-check.sh.

When SOP_TIER_CHECK_TOKEN is empty/invalid, three API calls exit the
script with code 1 before SOP_FAIL_OPEN=1 can be evaluated:
whoami, teams-list, and reviews. Fix: add || true to jq pipelines
and set +e/set -e guards around curl calls.

Changes

File	Change
`.gitea/scripts/sop-tier-check.sh`	`

References

PR #635 (main branch fix)
sop-tier-check failure on staging PRs #617, #621, #587, #562

## Summary Same fix as PR #635 (main branch) — applies the token-graceful handling to staging branch sop-tier-check.sh. When SOP_TIER_CHECK_TOKEN is empty/invalid, three API calls exit the script with code 1 before SOP_FAIL_OPEN=1 can be evaluated: `whoami`, `teams-list`, and `reviews`. Fix: add `|| true` to jq pipelines and `set +e`/`set -e` guards around curl calls. ## Changes | File | Change | |---|---| | `.gitea/scripts/sop-tier-check.sh` | `|| true` on jq pipelines; `set +e`/`set -e` guards; SOP_FAIL_OPEN checks on whoami, teams-list, reviews | ## References - PR #635 (main branch fix) - sop-tier-check failure on staging PRs #617, #621, #587, #562

infra-runtime-be added 1 commit 2026-05-12 01:53:47 +00:00

fix(ci): sop-tier-check gracefully handles empty/invalid token

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s

Details

sop-tier-check / tier-check (pull_request) Successful in 3s

Details

audit-force-merge / audit (pull_request) Successful in 2s

Details

1156aa3eea

SOP_FAIL_OPEN=1 was not preventing CI failures because three API calls
with `set -euo pipefail` would abort the script before reaching the
SOP_FAIL_OPEN eval block. Same fix as main branch PR #635.

Refs: sop-tier-check failure on staging PRs #617, #621, #587, #562

infra-runtime-be added the

tier:low

label 2026-05-12 01:53:52 +00:00

infra-runtime-be merged commit c7bb65cd2a into staging

2026-05-12 01:54:08 +00:00

infra-runtime-be referenced this issue from a commit

2026-05-12 01:54:09 +00:00

Merge pull request 'fix(ci): sop-tier-check gracefully handles empty/invalid token (staging)' (#636) from fix/sop-tier-check-token-graceful-staging into staging

infra-runtime-be referenced this issue from a commit

2026-05-12 01:57:18 +00:00

chore: re-trigger sop-tier-check after token-graceful fix [skip ci]

infra-runtime-be referenced this issue from a commit