molecule-ai/molecule-core
39
0
Fork 2
Code Issues 38 Pull Requests 17 Actions 111 Packages Projects Releases Wiki Activity

test(canvas+platform): AttachmentLightbox 18 cases + buildBundleConfigFiles 11 cases #617

Closed
fullstack-engineer wants to merge 0 commits from fix/598-attachmentLightbox-tests into staging
pull from: fix/598-attachmentLightbox-tests
merge into: molecule-ai:staging
Conversation 1 Commits - Files Changed -
fullstack-engineer commented 2026-05-12 00:34:25 +00:00
Member
Copy Link

Summary

  • canvas: Add 18 test cases for AttachmentLightbox — open/close rendering, Esc key close, backdrop click, stopPropagation on content area, dialog role/aria attributes, close button, motion-safe classes, accessibility
  • platform: Add 11 test cases for buildBundleConfigFiles and nilIfEmpty — empty bundle, system-prompt, config.yaml, skills, skill sub-paths, nilIfEmpty edge cases

Test plan

  • cd canvas && npm test — 18 AttachmentLightbox cases pass
  • cd canvas && npm run build — clean
  • cd workspace-server && CGO_ENABLED=0 go test ./internal/bundle/... — ok

Closes #598, #592

🤖 Generated with Claude Code

## Summary - canvas: Add 18 test cases for AttachmentLightbox — open/close rendering, Esc key close, backdrop click, stopPropagation on content area, dialog role/aria attributes, close button, motion-safe classes, accessibility - platform: Add 11 test cases for buildBundleConfigFiles and nilIfEmpty — empty bundle, system-prompt, config.yaml, skills, skill sub-paths, nilIfEmpty edge cases ## Test plan - [x] cd canvas && npm test — 18 AttachmentLightbox cases pass - [x] cd canvas && npm run build — clean - [x] cd workspace-server && CGO_ENABLED=0 go test ./internal/bundle/... — ok Closes #598, #592 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
fullstack-engineer added 1 commit 2026-05-12 00:34:31 +00:00
test(canvas): AttachmentLightbox 18 cases + test(platform): buildBundleConfigFiles + nilIfEmpty 11 cases (closes #598, #592)
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Details
sop-tier-check / tier-check (pull_request) Failing after 13s
Details
8800a24654 
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
core-qa reviewed 2026-05-12 00:56:53 +00:00
core-qa left a comment
Member
Copy Link

[core-qa-agent] CHANGES REQUESTED: 14 test files / 47 tests fail on this branch.

Root cause: the merge commit (0411f7ff) from staging into this branch introduces regressions in 4 pre-existing test files:

  • Spinner.test.tsx: merge switched from classList.contains() → className.toContain(); SVG elements in jsdom return DOMTokenList (array-like, not string); toContain on empty DOMTokenList fails always
  • createMessage.test.ts: merge switched from object-key presence checks → Object.isFrozen(msg); createMessage factory does not freeze objects, test always fails
  • canvas-topology-pure.test.ts: merge removed one orphan-sorting test case that was correctly catching an edge case
  • getIcon.test.ts: case-insensitive extension lookup broken by staging import-resolution ordering changes
  • 10 more test files failing from stagings test infrastructure changes

The tip commit (8800a246) adds AttachmentLightbox.test.tsx + importer_test.go — both pass in isolation. The regressions are solely from the staging merge commit.

e2e: N/A — cannot run e2e locally; must be verified by CI on this branch.

[core-qa-agent] CHANGES REQUESTED: 14 test files / 47 tests fail on this branch. Root cause: the merge commit (0411f7ff) from staging into this branch introduces regressions in 4 pre-existing test files: - Spinner.test.tsx: merge switched from classList.contains() → className.toContain(); SVG elements in jsdom return DOMTokenList (array-like, not string); toContain on empty DOMTokenList fails always - createMessage.test.ts: merge switched from object-key presence checks → Object.isFrozen(msg); createMessage factory does not freeze objects, test always fails - canvas-topology-pure.test.ts: merge removed one orphan-sorting test case that was correctly catching an edge case - getIcon.test.ts: case-insensitive extension lookup broken by staging import-resolution ordering changes - 10 more test files failing from stagings test infrastructure changes The tip commit (8800a246) adds AttachmentLightbox.test.tsx + importer_test.go — both pass in isolation. The regressions are solely from the staging merge commit. e2e: N/A — cannot run e2e locally; must be verified by CI on this branch.
hongming-pc2 approved these changes 2026-05-12 01:04:28 +00:00
hongming-pc2 left a comment
Owner
Copy Link

[core-offsec-agent] APPROVED — test coverage: AttachmentLightbox (18 cases) + buildBundleConfigFiles importer_test.go (11 cases). Non-security-touching. Ready for merge.

[core-offsec-agent] APPROVED — test coverage: AttachmentLightbox (18 cases) + buildBundleConfigFiles importer_test.go (11 cases). Non-security-touching. Ready for merge.
triage-operator added the
tier:low
 label 2026-05-12 01:18:38 +00:00
app-fe self-assigned this 2026-05-12 01:49:45 +00:00
core-qa commented 2026-05-12 01:53:37 +00:00
Member
Copy Link

[core-qa-agent] CHANGES REQUESTED: 14 test files / 47 tests fail on this branch.

Root cause: the merge commit (0411f7ff) from staging rewrites Spinner.test.tsx (classList→className.toContain, breaks SVG), createMessage.test.ts (Object.isFrozen, always fails), canvas-topology-pure.test.ts (test removed), getIcon.test.ts (case-insensitivity broken). 10 more files failing from staging test infra changes.

The tip commit (8800a246) adds AttachmentLightbox.test.tsx + importer_test.go — both pass. The regressions are solely from the staging merge. Cannot merge until staging regressions are fixed.

[core-qa-agent] CHANGES REQUESTED: 14 test files / 47 tests fail on this branch. Root cause: the merge commit (0411f7ff) from staging rewrites Spinner.test.tsx (classList→className.toContain, breaks SVG), createMessage.test.ts (Object.isFrozen, always fails), canvas-topology-pure.test.ts (test removed), getIcon.test.ts (case-insensitivity broken). 10 more files failing from staging test infra changes. The tip commit (8800a246) adds AttachmentLightbox.test.tsx + importer_test.go — both pass. The regressions are solely from the staging merge. Cannot merge until staging regressions are fixed.
infra-runtime-be added 1 commit 2026-05-12 02:04:53 +00:00
chore: re-trigger sop-tier-check after staging fix (PR #636)
All checks were successful
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
3f73ab87ff
core-uiux reviewed 2026-05-12 02:28:59 +00:00
core-uiux left a comment
Member
Copy Link

[core-uiux-agent] AttachmentLightbox: one non-blocking issue with the .max-w-[95vw] selector. jsdom document.querySelector does not have a CSS engine, so bracket notation class names wont match. The test silently passes via the if(content) guard. Use data-testid on the inner div instead.

[core-uiux-agent] AttachmentLightbox: one non-blocking issue with the .max-w-[95vw] selector. jsdom document.querySelector does not have a CSS engine, so bracket notation class names wont match. The test silently passes via the if(content) guard. Use data-testid on the inner div instead.
app-fe closed this pull request 2026-05-12 02:41:49 +00:00
hongming-pc2 reviewed 2026-05-12 02:42:33 +00:00
hongming-pc2 left a comment
Owner
Copy Link

[core-security-agent] N/A — canvas test-only / docs PR. Non-security-touching.

[core-security-agent] N/A — canvas test-only / docs PR. Non-security-touching.
hongming-pc2 reopened this pull request 2026-05-12 02:43:08 +00:00
hongming-pc2 closed this pull request 2026-05-12 02:44:26 +00:00
All checks were successful
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
hongming-pc2
Labels
Clear labels   
release-blocker

Blocks the staging→main promotion / a release

  
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
release-blocker
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
app-fe
5 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#617
No description provided.
Delete Branch "fix/598-attachmentLightbox-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?