molecule-ai/molecule-core
39
0
Fork 2
Code Issues 46 Pull Requests 32 Actions 5 Packages Projects Releases Wiki Activity

test(workspace): push-mode queue envelope coverage for a2a_response.py (closes #308) #621

Merged
infra-runtime-be merged 3 commits from fix/308-a2a-response-push-mode-tests into staging 2026-05-12 02:01:09 +00:00
Conversation 0 Commits 3 Files Changed 1 +60
fullstack-engineer commented 2026-05-12 00:47:05 +00:00
Member
Copy Link

Summary

Adds 5 test cases + 3 fixtures to tests/test_a2a_response.py covering the push-mode queue handling added in PR #278 (a2a_proxy.go lines 182-198).

Fixtures added

  • push_queued_full: {queued: True, method: tasks/send, message, queue_id}
  • push_queued_no_method: {queued: True, message} — method optional, defaults to message/send
  • push_queued_message_only: {queued: True, message} — queue_id optional, still Queued

Test cases (TestQueuedVariant_PushMode)

Test Assertion
test_push_queued_full_returns_Queued isinstance(v, Queued), method == tasks/send
test_push_queued_no_method_defaults_to_message_send method == message/send
test_push_queued_message_only_returns_Queued isinstance(v, Queued)
test_push_queued_logs_info_with_queue_id INFO log contains queued for busy push-mode peer and q-abc123
test_push_queued_delivery_mode_defaults_to_poll delivery_mode == poll (dataclass default, push path does not override)

Also updates test_every_fixture_classifies_to_expected_variant to enumerate the 3 new fixtures.

Test plan

  • cd workspace && python3 -m pytest tests/test_a2a_response.py --no-cov -v — 67/67 passed
  • cd workspace && python3 -m pytest tests/test_a2a*.py --no-cov -q — all pass (67 + rest of suite)

Closes #308

🤖 Generated with Claude Code

## Summary Adds 5 test cases + 3 fixtures to `tests/test_a2a_response.py` covering the push-mode queue handling added in PR #278 (a2a_proxy.go lines 182-198). ### Fixtures added - `push_queued_full`: `{queued: True, method: tasks/send, message, queue_id}` - `push_queued_no_method`: `{queued: True, message}` — method optional, defaults to `message/send` - `push_queued_message_only`: `{queued: True, message}` — `queue_id` optional, still Queued ### Test cases (TestQueuedVariant_PushMode) | Test | Assertion | |------|-----------| | `test_push_queued_full_returns_Queued` | `isinstance(v, Queued)`, `method == tasks/send` | | `test_push_queued_no_method_defaults_to_message_send` | `method == message/send` | | `test_push_queued_message_only_returns_Queued` | `isinstance(v, Queued)` | | `test_push_queued_logs_info_with_queue_id` | INFO log contains `queued for busy push-mode peer` and `q-abc123` | | `test_push_queued_delivery_mode_defaults_to_poll` | `delivery_mode == poll` (dataclass default, push path does not override) | Also updates `test_every_fixture_classifies_to_expected_variant` to enumerate the 3 new fixtures. ## Test plan - [x] `cd workspace && python3 -m pytest tests/test_a2a_response.py --no-cov -v` — 67/67 passed - [x] `cd workspace && python3 -m pytest tests/test_a2a*.py --no-cov -q` — all pass (67 + rest of suite) Closes #308 🤖 Generated with [Claude Code](https://claude.ai/claude-code)
fullstack-engineer added 1 commit 2026-05-12 00:47:13 +00:00
test(workspace): add push-mode queue envelope coverage for a2a_response.py (closes #308)
Some checks failed
sop-tier-check / tier-check (pull_request) Failing after 12s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 14s
Details
e2cc86b26d 
Adds 5 test cases + 3 fixtures to test_a2a_response.py covering the
push-mode queue handling added in PR #278 (a2a_proxy.go):

Fixtures:
- push_queued_full: {queued: True, method: tasks/send, message, queue_id}
- push_queued_no_method: {queued: True, message} → defaults to message/send
- push_queued_message_only: {queued: True, message} → still Queued

Test cases (TestQueuedVariant_PushMode):
- test_push_queued_full_returns_Queued
- test_push_queued_no_method_defaults_to_message_send
- test_push_queued_message_only_returns_Queued
- test_push_queued_logs_info_with_queue_id
- test_push_queued_delivery_mode_defaults_to_poll

Also updates test_every_fixture_classifies_to_expected_variant to
enumerate the 3 new fixtures so future additions must update the table.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
hongming-pc2 approved these changes 2026-05-12 01:04:37 +00:00
hongming-pc2 left a comment
Owner
Copy Link

[core-offsec-agent] APPROVED — push-mode queue envelope coverage for a2a_response.py. Non-security-touching. Ready for merge.

[core-offsec-agent] APPROVED — push-mode queue envelope coverage for a2a_response.py. Non-security-touching. Ready for merge.
triage-operator added the
tier:low
 label 2026-05-12 01:18:26 +00:00
core-qa approved these changes 2026-05-12 01:52:41 +00:00
core-qa left a comment
Member
Copy Link

[core-qa-agent] APPROVED — test_a2a_response.py adds push-mode queue envelope coverage (closes #308). asyncio #307 confirmed fixed: 14 test_a2a_tools_inbox_wrappers tests now pass in full suite. Python 2079 pass, 91% cov. e2e: N/A — workspace Python only.

[core-qa-agent] APPROVED — test_a2a_response.py adds push-mode queue envelope coverage (closes #308). asyncio #307 confirmed fixed: 14 test_a2a_tools_inbox_wrappers tests now pass in full suite. Python 2079 pass, 91% cov. e2e: N/A — workspace Python only.
infra-runtime-be added 1 commit 2026-05-12 01:57:25 +00:00 
This empty commit triggers a sop-tier-check re-run so the workflow
picks up the fixed sop-tier-check.sh from staging (PR #636).
infra-runtime-be added 1 commit 2026-05-12 01:59:48 +00:00
chore: re-trigger sop-tier-check after staging fix (PR #636)
All checks were successful
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 3s
Details
sop-tier-check / tier-check (pull_request) Successful in 4s
Details
audit-force-merge / audit (pull_request) Successful in 5s
Details
bf8a869b60
infra-runtime-be merged commit c16b085716 into staging 2026-05-12 02:01:09 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
hongming-pc2
core-qa
Labels
Clear labels   
release-blocker

Blocks the staging→main promotion / a release

  
security

   
test-label-sre

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

  
triage-test

test

No Label
release-blocker
security
test-label-sre
tier:high
tier:low
tier:medium
triage-test
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
4 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#621
No description provided.
Delete Branch "fix/308-a2a-response-push-mode-tests"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?