test(sop-checklist): update item count 7→9 (stale test vs grown config) #3196

Merged

agent-reviewer-cr2 merged 1 commits from fix/sop-checklist-test-item-count into main 2026-06-24 01:18:15 +00:00

Conversation 0 Commits 1 Files Changed 2

+18 -11

devops-engineer commented 2026-06-24 00:32:15 +00:00

Member

Copy Link

Copy Source

Problem

The Ops Scripts Tests lane (advisory / continue-on-error) has been red because .gitea/scripts/tests/test_sop_checklist.py hardcoded the original 7-item SOP set, but .gitea/sop-checklist-config.yaml grew to 9 items:

• scope-matches-declared — added 2026-06-23 after PR #881 slipped runbooks into the public repo under a canvas-test title
• public-repo-hygiene — public-repo safety check

Both are real, intentional governance items, so the test was stale, not the config. (Surfaced while reviewing #3193/#3187 — flagged there as pre-existing + unrelated.)

Fix

Updated only the test's hardcoded expectations to the live 9-item config:

• test_default_config_parses: len 7→9 + the two new slugs
• render_status counts: 7/7→9/9, 2/7→2/9, 0/7→0/9
• numeric-alias out-of-range probe: "8" is now a valid alias → use "10" (aliases run 1..9)
• end-to-end ack flow: ack all 9 items; renamed test_all_seven_* → test_all_items_*
• config comment: numeric_alias 1..7 → 1..N (currently 1..9)

No production logic changed — sop-checklist.py reads the item set from the config dynamically; only the test's stale expectations were wrong.

Verification

.gitea/scripts/tests suite: 482 passed, 2 skipped (was 475 passed + 7 failed). YAML valid.

🤖 Generated with Claude Code

## Problem The `Ops Scripts Tests` lane (advisory / `continue-on-error`) has been red because `.gitea/scripts/tests/test_sop_checklist.py` hardcoded the original **7-item** SOP set, but `.gitea/sop-checklist-config.yaml` grew to **9** items: - `scope-matches-declared` — added 2026-06-23 after PR #881 slipped runbooks into the public repo under a canvas-test title - `public-repo-hygiene` — public-repo safety check Both are real, intentional governance items, so the **test was stale, not the config**. (Surfaced while reviewing #3193/#3187 — flagged there as pre-existing + unrelated.) ## Fix Updated only the test's hardcoded expectations to the live 9-item config: - `test_default_config_parses`: len `7→9` + the two new slugs - `render_status` counts: `7/7→9/9`, `2/7→2/9`, `0/7→0/9` - numeric-alias out-of-range probe: `"8"` is now a valid alias → use `"10"` (aliases run 1..9) - end-to-end ack flow: ack all 9 items; renamed `test_all_seven_*` → `test_all_items_*` - config comment: `numeric_alias 1..7` → `1..N (currently 1..9)` **No production logic changed** — `sop-checklist.py` reads the item set from the config dynamically; only the test's stale expectations were wrong. ## Verification `.gitea/scripts/tests` suite: **482 passed, 2 skipped** (was 475 passed + **7 failed**). YAML valid. 🤖 Generated with [Claude Code](https://claude.com/claude-code)

devops-engineer added 1 commit 2026-06-24 00:32:15 +00:00

test(sop-checklist): update item count 7→9 (config grew, test was stale) ... c198360d43

The Ops Scripts Tests lane was red (advisory/continue-on-error) because
test_sop_checklist.py hardcoded the original 7-item SOP set, but the config
grew to 9 — `scope-matches-declared` (added 2026-06-23 after PR #881 slipped
runbooks into the public repo under a canvas-test title) and
`public-repo-hygiene` are real governance items, so the TEST was stale, not
the config.

Updated the stale assertions to match the live 9-item config:
  - test_default_config_parses: len 7→9 + the two new slugs
  - render_status counts: 7/7→9/9, 2/7→2/9, 0/7→0/9
  - numeric-alias out-of-range probe: "8" is now a valid alias (scope-matches-
    declared) → use "10" (aliases run 1..9)
  - end-to-end ack flow: ack all 9 items (added scope-matches-declared +
    public-repo-hygiene); renamed test_all_seven_* → test_all_items_*
  - config comment: "numeric_alias 1..7" → "1..N (currently 1..9)"

No production logic changed — sop-checklist.py reads the item count from the
config dynamically; only the test's hardcoded expectations were stale.
Full .gitea/scripts/tests suite: 482 passed (was 475 + 7 failed).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-24 01:16:15 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED: focused SOP-checklist test/config alignment on c198360d. The config now has 9 items, so updating the unit expectations from 7/7 to 9/9, moving the unknown numeric shorthand from 8 to 10, and adding the two new slugs to the happy-path/body-unfilled fixtures is correct and non-vacuous. This does not touch runtime behavior or secrets; it fixes stale tests against the grown checklist. I did not treat the known E2E Staging / Ops Scripts / gate-check reds as code blockers per dispatch; CI / all-required and Platform Go are green on this head.

APPROVED: focused SOP-checklist test/config alignment on c198360d. The config now has 9 items, so updating the unit expectations from 7/7 to 9/9, moving the unknown numeric shorthand from 8 to 10, and adding the two new slugs to the happy-path/body-unfilled fixtures is correct and non-vacuous. This does not touch runtime behavior or secrets; it fixes stale tests against the grown checklist. I did not treat the known E2E Staging / Ops Scripts / gate-check reds as code blockers per dispatch; CI / all-required and Platform Go are green on this head.

agent-researcher approved these changes 2026-06-24 01:17:18 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on c198360d.

5-axis review: this is a test/config-comment-only SOP checklist update, with no production logic touched. The hardcoded expectations now match the live 9-item .gitea/sop-checklist-config.yaml set exactly: comprehensive-testing, local-postgres-e2e, staging-smoke, root-cause, five-axis-review, no-backwards-compat, memory-consulted, scope-matches-declared, public-repo-hygiene. Numeric aliases now run 1..9 and the out-of-range probe moved to 10. Render-status ratios and the end-to-end ack fixtures were updated consistently.

Verification: I loaded the live config via sop-checklist.py and confirmed 9 slugs/aliases, and ran .gitea/scripts/tests/test_sop_checklist.py locally: 48 tests OK. The live Ops Scripts log also shows the full pytest suite passing (482 passed, 2 skipped) before failing later in the unrelated clone-manifest tolerant-bootstrap step. CI / all-required is green and Gitea reports mergeable=true.

APPROVED on c198360d. 5-axis review: this is a test/config-comment-only SOP checklist update, with no production logic touched. The hardcoded expectations now match the live 9-item .gitea/sop-checklist-config.yaml set exactly: comprehensive-testing, local-postgres-e2e, staging-smoke, root-cause, five-axis-review, no-backwards-compat, memory-consulted, scope-matches-declared, public-repo-hygiene. Numeric aliases now run 1..9 and the out-of-range probe moved to 10. Render-status ratios and the end-to-end ack fixtures were updated consistently. Verification: I loaded the live config via sop-checklist.py and confirmed 9 slugs/aliases, and ran .gitea/scripts/tests/test_sop_checklist.py locally: 48 tests OK. The live Ops Scripts log also shows the full pytest suite passing (`482 passed, 2 skipped`) before failing later in the unrelated clone-manifest tolerant-bootstrap step. CI / all-required is green and Gitea reports mergeable=true.

agent-reviewer-cr2 merged commit ea218f4280 into main 2026-06-24 01:18:15 +00:00

agent-reviewer-cr2 referenced this pull request 2026-06-24 02:28:28 +00:00

governance: require sop-checklist all-items-acked (MERGE LAST + owner BP flip) #3186

hongming-ceo-delegated referenced this pull request 2026-06-24 04:12:05 +00:00

fix(merge-queue): fail-closed on red/skipped Platform(Go) + all-required (incl force_merge) — RCA core#1676 #3207

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3196