governance: require sop-checklist all-items-acked (MERGE LAST + owner BP flip) #3186

Merged

devops-engineer merged 1 commits from governance/require-sop-checklist-all-items-acked into main 2026-06-24 02:30:54 +00:00

Conversation 0 Commits 1 Files Changed 1

+1

devops-engineer commented 2026-06-23 21:40:55 +00:00

Member

Copy Link

Copy Source

Adds sop-checklist / all-items-acked to the merge-blocking required-contexts list, so the review checklist (#3184 items #8 scope-matches + #9 public-repo-hygiene) becomes mandatory — reviewers must /sop-ack each one.

MERGE LAST. Land only after the in-flight batch (#3183 security delete, #3184 items, #3185 RFC) merges and after #3184 lands items 8/9 — otherwise every open PR fail-closes on un-acked items.

Owner step (hard enforcement): required-contexts.txt alone did NOT hard-block on #3181 (E2E-Concierge-Creates-Workspace is in the file but merged red because it's not in BP). To hard-enforce, the owner adds sop-checklist / all-items-acked (pull_request) to molecule-core branch-protection status_check_contexts. This PR is the documented-list companion to that BP flip.

Adds `sop-checklist / all-items-acked` to the merge-blocking required-contexts list, so the review checklist (#3184 items #8 scope-matches + #9 public-repo-hygiene) becomes mandatory — reviewers must `/sop-ack` each one. **MERGE LAST.** Land only after the in-flight batch (#3183 security delete, #3184 items, #3185 RFC) merges and after #3184 lands items 8/9 — otherwise every open PR fail-closes on un-acked items. **Owner step (hard enforcement):** required-contexts.txt alone did NOT hard-block on #3181 (E2E-Concierge-Creates-Workspace is in the file but merged red because it's not in BP). To hard-enforce, the owner adds `sop-checklist / all-items-acked (pull_request)` to molecule-core branch-protection status_check_contexts. This PR is the documented-list companion to that BP flip.

devops-engineer added 1 commit 2026-06-23 21:40:55 +00:00

governance: require sop-checklist / all-items-acked (merge-blocking list) ... ec882d0aba

Stages the checklist gate as a documented required context. MERGE LAST:
(1) after the in-flight batch (#3183/#3184/#3185) merges, and (2) after
#3184 lands items 8/9 — else all open PRs fail-closed. The HARD Gitea
enforcement is the owner adding this context to branch-protection
status_check_contexts (required-contexts.txt alone did not hard-block
E2E-Concierge-Creates-Workspace on #3181).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

devops-engineer added 1 commit 2026-06-23 21:40:56 +00:00

governance: require sop-checklist / all-items-acked (merge-blocking list) ... ec882d0aba

Stages the checklist gate as a documented required context. MERGE LAST:
(1) after the in-flight batch (#3183/#3184/#3185) merges, and (2) after
#3184 lands items 8/9 — else all open PRs fail-closed. The HARD Gitea
enforcement is the owner adding this context to branch-protection
status_check_contexts (required-contexts.txt alone did not hard-block
E2E-Concierge-Creates-Workspace on #3181).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

devops-engineer added the do-not-merge label 2026-06-23 21:41:12 +00:00

agent-reviewer-cr2 approved these changes 2026-06-24 02:28:28 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED: #3186 is a one-line governance change adding sop-checklist / all-items-acked to .gitea/required-contexts.txt. This matches the intended merge-lane hardening now that #3196 fixed the stale 7-vs-9 SOP checklist test expectations. No production code or secrets touched; performance impact is nil. The “MERGE LAST” note still matters operationally, but the current head is acceptable from a code-review standpoint.

APPROVED: #3186 is a one-line governance change adding `sop-checklist / all-items-acked` to .gitea/required-contexts.txt. This matches the intended merge-lane hardening now that #3196 fixed the stale 7-vs-9 SOP checklist test expectations. No production code or secrets touched; performance impact is nil. The “MERGE LAST” note still matters operationally, but the current head is acceptable from a code-review standpoint.

devops-engineer merged commit d38c2409c7 into main 2026-06-24 02:30:54 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label do-not-merge

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3186