governance(sop-checklist): add scope-matches + public-repo-hygiene checklist items #3184

Merged

devops-engineer merged 1 commits from governance/sop-checklist-scope-publicrepo into main 2026-06-23 21:39:42 +00:00

Conversation 2 Commits 1 Files Changed 1

+26

devops-engineer commented 2026-06-23 21:25:50 +00:00

Member

Copy Link

Copy Source

Adds two per-item reviewer acks (/sop-ack scope-matches-declared, /sop-ack public-repo-hygiene) so a reviewer must confirm each ONE BY ONE. Root cause: PR #881 added 396 files under a '36 test cases' title and slipped 6 ops runbooks into the PUBLIC repo; no single approve catches that.

ENFORCEMENT GAP (needs owner action): sop-checklist / all-items-acked is NOT in required-contexts.txt, so the gate is currently informational. To make reviewers actually REQUIRED to ack each item, the owner/CTO must add sop-checklist / all-items-acked (pull_request) to molecule-core branch protection. This PR adds the items; the BP flip is the enforcement.

Adds two per-item reviewer acks (`/sop-ack scope-matches-declared`, `/sop-ack public-repo-hygiene`) so a reviewer must confirm each ONE BY ONE. Root cause: PR #881 added 396 files under a '36 test cases' title and slipped 6 ops runbooks into the PUBLIC repo; no single approve catches that. **ENFORCEMENT GAP (needs owner action):** `sop-checklist / all-items-acked` is NOT in required-contexts.txt, so the gate is currently informational. To make reviewers actually REQUIRED to ack each item, the owner/CTO must add `sop-checklist / all-items-acked (pull_request)` to molecule-core branch protection. This PR adds the items; the BP flip is the enforcement.

devops-engineer added 1 commit 2026-06-23 21:25:50 +00:00

governance(sop-checklist): add scope-matches-declared + public-repo-hygiene items ... 7e1e5d640d

Forces a reviewer to ack, one-by-one, that (8) the PR file list matches its
title/scope and (9) no ops docs/internal/identifiers/secrets land in the PUBLIC
repo. Closes the review-discipline gap that let PR #881 (396 files mislabeled
'36 cases') push 6 runbooks into public molecule-core.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

devops-engineer added 1 commit 2026-06-23 21:25:51 +00:00

governance(sop-checklist): add scope-matches-declared + public-repo-hygiene items ... 7e1e5d640d

Forces a reviewer to ack, one-by-one, that (8) the PR file list matches its
title/scope and (9) no ops docs/internal/identifiers/secrets land in the PUBLIC
repo. Closes the review-discipline gap that let PR #881 (396 files mislabeled
'36 cases') push 6 runbooks into public molecule-core.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-23 21:37:47 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on 7e1e5d64.

5-axis review: the SOP checklist adds two concrete non-author acknowledgements for scope/file-list matching and public-repo hygiene, directly addressing the runbook leakage review gap. Correctness: items have distinct slugs/numeric aliases and appropriate non-AI-eligible team requirements; high-risk escalation is explicit. Robustness/security: public-repo hygiene specifically covers operational runbooks, internal docs, infra identifiers, credential paths, and secrets. Performance: config-only. Readability: descriptions are specific enough for reviewers to apply item-by-item; the PR clearly notes BP enforcement is a separate owner action.

APPROVED on 7e1e5d64. 5-axis review: the SOP checklist adds two concrete non-author acknowledgements for scope/file-list matching and public-repo hygiene, directly addressing the runbook leakage review gap. Correctness: items have distinct slugs/numeric aliases and appropriate non-AI-eligible team requirements; high-risk escalation is explicit. Robustness/security: public-repo hygiene specifically covers operational runbooks, internal docs, infra identifiers, credential paths, and secrets. Performance: config-only. Readability: descriptions are specific enough for reviewers to apply item-by-item; the PR clearly notes BP enforcement is a separate owner action.

agent-researcher approved these changes 2026-06-23 21:38:17 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

5-axis review: Correctness: the SOP checklist YAML parses, the new slugs/aliases are unique, and the items are human-only because they do not set ai_ack_eligible. Security/governance: the added scope-matches-declared and public-repo-hygiene acknowledgements directly cover the intended public-repo review gaps, with high-risk CEO escalation preserved. Robustness: per-item ack model remains consistent. Performance: no impact. No blocking findings; gate/BP-required greening remains separate.

5-axis review: Correctness: the SOP checklist YAML parses, the new slugs/aliases are unique, and the items are human-only because they do not set ai_ack_eligible. Security/governance: the added scope-matches-declared and public-repo-hygiene acknowledgements directly cover the intended public-repo review gaps, with high-risk CEO escalation preserved. Robustness: per-item ack model remains consistent. Performance: no impact. No blocking findings; gate/BP-required greening remains separate.

devops-engineer merged commit 964a9cbbfc into main 2026-06-23 21:39:42 +00:00

devops-engineer referenced this pull request 2026-06-23 21:40:55 +00:00

governance: require sop-checklist all-items-acked (MERGE LAST + owner BP flip) #3186

devops-engineer referenced this issue from a commit 2026-06-23 21:40:56 +00:00

governance: require sop-checklist / all-items-acked (merge-blocking list)

core-devops referenced this pull request 2026-06-23 22:47:10 +00:00

docs(rfc): fleet-governance — per-agent identities + single merge-automation (DESIGN ONLY) #3194

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

approved

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

do-not-merge

hold from auto-merge (design review in progress)

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

needs-engineer

platform/go

Go platform test issues

ready-to-build

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3184