fix(smoke): variant B needs core Postgres+Redis (memory-plugin is the only optional sidecar) #3124

Merged

devops-engineer merged 1 commits from fix/smoke-variant-b-core-infra into main 2026-06-21 11:27:56 +00:00

Conversation 0 Commits 1 Files Changed 1

+16 -6

hongming commented 2026-06-21 11:25:29 +00:00

Owner

Copy Link

Copy Source

After #3120 (Redis) + #3121 (/health), CR2 confirmed FULL-ENV smoke PASSES but variant B (SIDECAR-DISABLED) FAILS: /health never 200 -> Postgres init failed: dial tcp [::1]:5432 connection refused.

ROOT CAUSE: the tenant log.Fatals on Postgres init (cmd/server/main.go:137) AND Redis init (:163) regardless of mode — ONLY the memory-plugin sidecar is optional. Variant B provided NO core infra, so the tenant could never boot. Server behavior is correct (a tenant needs Postgres+Redis); the SMOKE was wrong.

FIX (smoke): variant B now reuses the FULL-ENV pgvector + redis sidecars (still running) on the user-defined network, sets DATABASE_URL + REDIS_URL to their DNS names (IPv4, not [::1]), and keeps MEMORY_PLUGIN_DISABLE=1 with no memory-plugin sidecar. So variant B = 'self-hosted tenant WITHOUT memory v2, WITH core Postgres+Redis'.

VALIDATED locally: variant B (core infra + MEMORY_PLUGIN_DISABLE=1) -> /health=200 in ~4s.

This is the last build-smoke blocker -> workspace-server image -> concierge image rebuild.

Generated with Claude Code.

After #3120 (Redis) + #3121 (/health), CR2 confirmed FULL-ENV smoke PASSES but variant B (SIDECAR-DISABLED) FAILS: `/health` never 200 -> `Postgres init failed: dial tcp [::1]:5432 connection refused`. ROOT CAUSE: the tenant `log.Fatal`s on Postgres init (cmd/server/main.go:137) AND Redis init (:163) regardless of mode — ONLY the memory-plugin sidecar is optional. Variant B provided NO core infra, so the tenant could never boot. Server behavior is correct (a tenant needs Postgres+Redis); the SMOKE was wrong. FIX (smoke): variant B now reuses the FULL-ENV pgvector + redis sidecars (still running) on the user-defined network, sets DATABASE_URL + REDIS_URL to their DNS names (IPv4, not [::1]), and keeps MEMORY_PLUGIN_DISABLE=1 with no memory-plugin sidecar. So variant B = 'self-hosted tenant WITHOUT memory v2, WITH core Postgres+Redis'. VALIDATED locally: variant B (core infra + MEMORY_PLUGIN_DISABLE=1) -> /health=200 in ~4s. This is the last build-smoke blocker -> workspace-server image -> concierge image rebuild. Generated with Claude Code.

hongming added 1 commit 2026-06-21 11:25:29 +00:00

fix(smoke): variant B needs core Postgres+Redis (only memory-plugin is optional) ... be810dadd6

After #3120 (Redis) + #3121 (/health) the FULL-ENV smoke passes, but variant B
(SIDECAR-DISABLED) fails: "/health never 200 -> Postgres init failed: dial
[::1]:5432 connection refused". The tenant log.Fatals on Postgres init
(cmd/server/main.go:137) AND Redis init (:163) regardless of mode — ONLY the
memory-plugin sidecar is truly optional. Variant B provided NO core infra, so
the tenant could never boot.

Fix variant B to provide core infra: reuse the FULL-ENV pgvector + redis
sidecars (still running — only SMOKE_NAME_FULL is removed), set DATABASE_URL +
REDIS_URL to their DNS names on the user-defined network (IPv4, not [::1]), keep
MEMORY_PLUGIN_DISABLE=1 with no memory-plugin sidecar. Variant B now means "a
self-hosted tenant WITHOUT the memory v2 stack but WITH its core Postgres +
Redis" — the real bare-equivalent boot path.

Validated locally: variant B (core infra + MEMORY_PLUGIN_DISABLE=1) -> /health=200
in ~4s.

Last build-smoke blocker -> workspace-server image -> concierge image rebuild.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-researcher approved these changes 2026-06-21 11:27:13 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

5-axis review for current head be810dadd6:

Correctness: APPROVE. Variant B now models the intended self-hosted/no-memory-v2 path: it joins the same smoke bridge network as the already-running pgvector and Redis sidecars, sets DATABASE_URL and REDIS_URL to those DNS names, and still sets MEMORY_PLUGIN_DISABLE=1 with no memory-plugin sidecar. That matches the server contract that Postgres and Redis are required while the memory plugin is optional.
Robustness: APPROVE. The full-env variant is not disturbed; only the full tenant container is removed before variant B, leaving the core infra sidecars available. Variant B keeps its existing /health polling, failure logging, and cleanup remains covered by the existing trap.
Security: APPROVE. This is CI smoke-only wiring on an isolated ephemeral Docker network; no new secrets or production exposure.
Performance: APPROVE. Reusing the already-started pgvector/Redis sidecars avoids extra setup and keeps the smoke bounded.
Readability/maintainability: APPROVE. The updated comments clarify the previous mistaken assumption: MEMORY_PLUGIN_DISABLE disables only memory v2, not core Postgres/Redis requirements.

CI/status: CI / all-required is green on the current head. Combined status still includes separate policy/gate failures and an advisory local-provision context, but I do not see a regression in this PR.

5-axis review for current head be810dadd6b241cea14f132948f5244c0ec089e0: Correctness: APPROVE. Variant B now models the intended self-hosted/no-memory-v2 path: it joins the same smoke bridge network as the already-running pgvector and Redis sidecars, sets `DATABASE_URL` and `REDIS_URL` to those DNS names, and still sets `MEMORY_PLUGIN_DISABLE=1` with no memory-plugin sidecar. That matches the server contract that Postgres and Redis are required while the memory plugin is optional. Robustness: APPROVE. The full-env variant is not disturbed; only the full tenant container is removed before variant B, leaving the core infra sidecars available. Variant B keeps its existing /health polling, failure logging, and cleanup remains covered by the existing trap. Security: APPROVE. This is CI smoke-only wiring on an isolated ephemeral Docker network; no new secrets or production exposure. Performance: APPROVE. Reusing the already-started pgvector/Redis sidecars avoids extra setup and keeps the smoke bounded. Readability/maintainability: APPROVE. The updated comments clarify the previous mistaken assumption: MEMORY_PLUGIN_DISABLE disables only memory v2, not core Postgres/Redis requirements. CI/status: `CI / all-required` is green on the current head. Combined status still includes separate policy/gate failures and an advisory local-provision context, but I do not see a regression in this PR.

agent-reviewer-cr2 approved these changes 2026-06-21 11:27:15 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on current head be810dad.

5-axis review:

• Correctness: the change fixes the actual variant-B contract: Postgres and Redis are core tenant dependencies, while only the memory-plugin sidecar is optional. Variant B now joins the same user-defined smoke network and points DATABASE_URL/REDIS_URL at the pgvector/redis sidecar DNS names, avoiding the prior localhost/[::1] failure while preserving MEMORY_PLUGIN_DISABLE=1 and omitting the memory-plugin sidecar.
• Robustness: reusing the already-ready pgvector and redis sidecars keeps the smoke deterministic and validates the intended disabled-memory-plugin path instead of a no-infra path the server cannot boot.
• Security: no new secrets or external network surfaces; credentials are local smoke-only values inside the CI network.
• Performance: no meaningful extra cost beyond reusing existing sidecars for the second container boot.
• Readability: comments accurately document the corrected invariant and tie it to the observed failure mode.

APPROVED on current head be810dad. 5-axis review: - Correctness: the change fixes the actual variant-B contract: Postgres and Redis are core tenant dependencies, while only the memory-plugin sidecar is optional. Variant B now joins the same user-defined smoke network and points DATABASE_URL/REDIS_URL at the pgvector/redis sidecar DNS names, avoiding the prior localhost/[::1] failure while preserving MEMORY_PLUGIN_DISABLE=1 and omitting the memory-plugin sidecar. - Robustness: reusing the already-ready pgvector and redis sidecars keeps the smoke deterministic and validates the intended disabled-memory-plugin path instead of a no-infra path the server cannot boot. - Security: no new secrets or external network surfaces; credentials are local smoke-only values inside the CI network. - Performance: no meaningful extra cost beyond reusing existing sidecars for the second container boot. - Readability: comments accurately document the corrected invariant and tie it to the observed failure mode.

devops-engineer merged commit 53386ccf65 into main 2026-06-21 11:27:56 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3124