fix(smoke): poll /health not /healthz (the route the server serves) #3121

Merged

devops-engineer merged 1 commits from fix/smoke-health-path-healthz-to-health into main 2026-06-21 11:03:22 +00:00

Conversation 2 Commits 1 Files Changed 1

+9 -9

hongming commented 2026-06-21 11:01:01 +00:00

Owner

Copy Link

Copy Source

CR2 found the next build-and-push smoke failure after #3120: full-env smoke gets /healthz 404 for 180s. ROOT CAUSE: the smoke polls /healthz but the workspace-server mounts ONLY /health (router.go:93 -> 200); there is no /healthz route. The tenant is up + serving — it's just route-not-found on the wrong path. SMOKE-PATH bug, not a server bug.

/health is canonical: the readiness canary (CanaryTenantURL), the EC2 boot probe (localhost:8080/health), and the server route all use it.

Fix: both smoke variants (A FULL-ENV, B SIDECAR-DISABLED) now poll /health. The memory-plugin sidecar check (/v1/health on :9100) is unchanged.

Unblocks: workspace-server image build -> platform-agent/concierge image rebuild.

Generated with Claude Code.

CR2 found the next build-and-push smoke failure after #3120: full-env smoke gets /healthz 404 for 180s. ROOT CAUSE: the smoke polls `/healthz` but the workspace-server mounts ONLY `/health` (router.go:93 -> 200); there is no `/healthz` route. The tenant is up + serving — it's just route-not-found on the wrong path. SMOKE-PATH bug, not a server bug. `/health` is canonical: the readiness canary (CanaryTenantURL), the EC2 boot probe (localhost:8080/health), and the server route all use it. Fix: both smoke variants (A FULL-ENV, B SIDECAR-DISABLED) now poll `/health`. The memory-plugin sidecar check (`/v1/health` on :9100) is unchanged. Unblocks: workspace-server image build -> platform-agent/concierge image rebuild. Generated with Claude Code.

hongming added 1 commit 2026-06-21 11:01:01 +00:00

fix(smoke): poll /health not /healthz (the route the server actually serves) ... 4ca15b0375

The publish-workspace-server-image build-and-push smoke gate polled
http://localhost:<port>/healthz, but the workspace-server mounts ONLY /health
(router.go:93 -> 200 {"status":"ok"}); there is no /healthz route. So the smoke
got 404 for 180s even though the tenant was up + serving — failing the build and
blocking the platform-agent/concierge image rebuild. (#3120 fixed the Redis
init; this is the next, distinct failure CR2 found.)

/health is canonical: the readiness canary (CanaryTenantURL), the EC2 boot probe
(localhost:8080/health), and the server route all use /health.

Change BOTH smoke variants (A: FULL ENV, B: SIDECAR-DISABLED) to poll /health.
The memory-plugin sidecar check (/v1/health on :9100) is unchanged.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

agent-researcher approved these changes 2026-06-21 11:02:52 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

5-axis review for current head 4ca15b0375:

Correctness: APPROVE. The workflow smoke probes now poll the canonical tenant /health route in both variants: FULL-ENV on localhost:18080/health and SIDECAR-DISABLED on localhost:18081/health. This matches the server/canary/EC2 readiness contract described in the PR and directly fixes the /healthz 404 smoke-path failure. The memory-plugin sidecar check remains on :19100/v1/health, which is the separate plugin health endpoint and should not be changed.
Robustness: APPROVE. Both smoke variants keep their existing retry budgets, fail-closed behavior, log capture, and cleanup; only the tenant health path and human-facing log strings changed.
Security: APPROVE. No auth, secret, network exposure, or runtime server behavior changes.
Performance: APPROVE. No added work; same polling cadence and timeout against the correct endpoint.
Readability/maintainability: APPROVE. Comments and error/success messages now align with the route actually being probed, reducing future RCA noise.

CI/status: CI / all-required is green on the current head and the template-delivery/local contexts visible in status are green or advisory. Combined status still includes separate policy/gate failures, but I do not see a code regression in this PR.

5-axis review for current head 4ca15b0375bfaf1743ab90a2cd5e8260c00124f5: Correctness: APPROVE. The workflow smoke probes now poll the canonical tenant `/health` route in both variants: FULL-ENV on `localhost:18080/health` and SIDECAR-DISABLED on `localhost:18081/health`. This matches the server/canary/EC2 readiness contract described in the PR and directly fixes the `/healthz` 404 smoke-path failure. The memory-plugin sidecar check remains on `:19100/v1/health`, which is the separate plugin health endpoint and should not be changed. Robustness: APPROVE. Both smoke variants keep their existing retry budgets, fail-closed behavior, log capture, and cleanup; only the tenant health path and human-facing log strings changed. Security: APPROVE. No auth, secret, network exposure, or runtime server behavior changes. Performance: APPROVE. No added work; same polling cadence and timeout against the correct endpoint. Readability/maintainability: APPROVE. Comments and error/success messages now align with the route actually being probed, reducing future RCA noise. CI/status: `CI / all-required` is green on the current head and the template-delivery/local contexts visible in status are green or advisory. Combined status still includes separate policy/gate failures, but I do not see a code regression in this PR.

agent-reviewer-cr2 approved these changes 2026-06-21 11:02:56 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on current head 4ca15b03.

5-axis review:
Correctness: this addresses the exact post-#3120 failure mode. The workspace-server smoke was polling /healthz, but the server exposes /health; the PR updates both FULL ENV (:18080) and SIDECAR-DISABLED (:18081) smoke curls and matching log strings to /health. The memory-plugin /v1/health check on :9100 is unchanged.
Robustness: both smoke variants retain their existing retry windows, cleanup, and failure diagnostics; only the canonical platform health path changes.
Security: no secrets, auth, network exposure, or runtime privileges change.
Performance: no runtime impact; CI-only polling path fix.
Readability: comments and notices now match the actual route being checked.

APPROVED on current head 4ca15b03. 5-axis review: Correctness: this addresses the exact post-#3120 failure mode. The workspace-server smoke was polling /healthz, but the server exposes /health; the PR updates both FULL ENV (:18080) and SIDECAR-DISABLED (:18081) smoke curls and matching log strings to /health. The memory-plugin /v1/health check on :9100 is unchanged. Robustness: both smoke variants retain their existing retry windows, cleanup, and failure diagnostics; only the canonical platform health path changes. Security: no secrets, auth, network exposure, or runtime privileges change. Performance: no runtime impact; CI-only polling path fix. Readability: comments and notices now match the actual route being checked.

devops-engineer merged commit ad26d6c600 into main 2026-06-21 11:03:22 +00:00

hongming referenced this pull request 2026-06-21 11:08:17 +00:00

chore(scripts): local-runnable tenant smoke (dev companion to CI gate) #3123

hongming referenced this issue from a commit 2026-06-21 11:08:19 +00:00

chore(scripts): local-runnable tenant smoke (dev companion to the CI gate)

hongming referenced this pull request 2026-06-21 11:25:29 +00:00

fix(smoke): variant B needs core Postgres+Redis (memory-plugin is the only optional sidecar) #3124

hongming referenced this issue from a commit 2026-06-21 11:25:30 +00:00

fix(smoke): variant B needs core Postgres+Redis (only memory-plugin is optional)

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3121