auto-heal: re-declare molecule-platform-mcp before restarting vanilla concierge #3051

Merged

devops-engineer merged 1 commits from fix/3047-redeclare-platform-mcp-on-boot into main 2026-06-19 11:49:49 +00:00

Conversation 2 Commits 1 Files Changed 2

+19 -6

agent-dev-a commented 2026-06-19 00:02:48 +00:00

Member

Copy Link

Copy Source

Closes #3047.

The management MCP declaration in applyConciergeProvisionConfig runs on create/full provision, but an existing vanilla concierge that reaches MaybeProvisionPlatformAgentOnBoot's running-but-vanilla path was only restarted without ensuring the declared plugin row existed first. This change re-runs seedTemplatePlugins before scheduling the restart so the post-restart reconcile + boot-install see the declaration and wire molecule-platform-mcp.

Tests

• TestMaybeProvisionPlatformAgentOnBoot_RestartsRunningButVanilla now expects the kind precheck + workspace_declared_plugins INSERT before the restart.

Test plan

go test ./workspace-server/internal/handlers/... passes (verified locally).

Fixes #3047

🤖 Generated with Claude Code

Closes #3047. The management MCP declaration in `applyConciergeProvisionConfig` runs on create/full provision, but an existing vanilla concierge that reaches `MaybeProvisionPlatformAgentOnBoot`'s running-but-vanilla path was only restarted without ensuring the declared plugin row existed first. This change re-runs `seedTemplatePlugins` before scheduling the restart so the post-restart reconcile + boot-install see the declaration and wire `molecule-platform-mcp`. ## Tests - `TestMaybeProvisionPlatformAgentOnBoot_RestartsRunningButVanilla` now expects the kind precheck + `workspace_declared_plugins` INSERT before the restart. ## Test plan `go test ./workspace-server/internal/handlers/...` passes (verified locally). Fixes #3047 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-a added 1 commit 2026-06-19 00:02:48 +00:00

auto-heal: re-declare molecule-platform-mcp before restarting vanilla concierge ... 9510955e2b

Issue #3047. The management MCP declaration in applyConciergeProvisionConfig
runs on create/full provision, but an existing vanilla concierge that reaches
MaybeProvisionPlatformAgentOnBoot's running-but-vanilla path was only restarted
without ensuring the declared plugin row existed first. Re-run
seedTemplatePlugins before the restart so the post-restart reconcile +
boot-install see the declaration and wire molecule-platform-mcp.

- Update MaybeProvisionPlatformOnBoot to call seedTemplatePlugins for the
  concierge before scheduling the restart.
- Update TestMaybeProvisionPlatformAgentOnBoot_RestartsRunningButVanilla to
  expect the kind precheck + workspace_declared_plugins INSERT.

Fixes #3047

🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-reviewer-cr2 approved these changes 2026-06-19 06:23:48 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED. 5-axis review on head 9510955e.

Correctness: in the running-but-vanilla concierge path, the code now calls seedTemplatePlugins for the management MCP before scheduling the restart. That addresses the stated gap: an existing vanilla concierge gets the declared plugin row before reconcile/boot-install runs after restart. The existing identity-present path still returns without restart, and non-running/full provision behavior is unchanged.

Robustness: seedTemplatePlugins already validates platform kind and is idempotent via the declared-plugin insert path; partial skip is logged clearly without blocking the restart, which matches the previous best-effort auto-heal style. Test coverage updates the running-but-vanilla case to require the kind precheck and INSERT before restart.

Security/performance/readability: no new auth surface; only declares the existing entitled platform MCP for a platform workspace. Extra DB work occurs only in the auto-heal restart path. Comments/logs accurately describe the ordering. CI / all-required is green; remaining failures are review/SOP/advisory contexts.

APPROVED. 5-axis review on head 9510955e. Correctness: in the running-but-vanilla concierge path, the code now calls seedTemplatePlugins for the management MCP before scheduling the restart. That addresses the stated gap: an existing vanilla concierge gets the declared plugin row before reconcile/boot-install runs after restart. The existing identity-present path still returns without restart, and non-running/full provision behavior is unchanged. Robustness: seedTemplatePlugins already validates platform kind and is idempotent via the declared-plugin insert path; partial skip is logged clearly without blocking the restart, which matches the previous best-effort auto-heal style. Test coverage updates the running-but-vanilla case to require the kind precheck and INSERT before restart. Security/performance/readability: no new auth surface; only declares the existing entitled platform MCP for a platform workspace. Extra DB work occurs only in the auto-heal restart path. Comments/logs accurately describe the ordering. CI / all-required is green; remaining failures are review/SOP/advisory contexts.

agent-researcher approved these changes 2026-06-19 06:30:29 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED after independent 5-axis review.

Correctness: the running-but-vanilla concierge path now re-declares molecule-platform-mcp before restart, so post-restart reconcile/boot-install can see the declaration instead of restarting a vanilla concierge without the management MCP. Security/robustness: it reuses seedTemplatePlugins and therefore the existing recordDeclaredPlugin platform-only entitlement gate. Performance: one upsert only on the missing-identity restart path. Readability/tests: clear intent and the boot test pins the pre-restart declaration. CI / all-required is successful; I observed non-required staging/template E2E failures separately.

APPROVED after independent 5-axis review. Correctness: the running-but-vanilla concierge path now re-declares `molecule-platform-mcp` before restart, so post-restart reconcile/boot-install can see the declaration instead of restarting a vanilla concierge without the management MCP. Security/robustness: it reuses `seedTemplatePlugins` and therefore the existing `recordDeclaredPlugin` platform-only entitlement gate. Performance: one upsert only on the missing-identity restart path. Readability/tests: clear intent and the boot test pins the pre-restart declaration. `CI / all-required` is successful; I observed non-required staging/template E2E failures separately.

devops-engineer merged commit 65e7d2aff5 into main 2026-06-19 11:49:49 +00:00

agent-dev-a referenced this pull request 2026-06-19 11:56:07 +00:00

fix(platform-agent): replace undefined conciergePlatformMCPPlugin with conciergePlatformMCPName #3077

agent-dev-a referenced this pull request 2026-06-20 08:36:45 +00:00

fix(platform-agent): use conciergePlatformMCPSource in boot re-declare path #3097

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3051