molecule-ai/molecule-core
53
0
Fork 2
Code Issues 190 Pull Requests 45 Actions 3 Packages Projects Releases Wiki Activity

fix(platform-agent): use conciergePlatformMCPSource in boot re-declare path #3097

Closed
agent-dev-a wants to merge 2 commits from fix/main-red-concierge-mcp-name into main
pull from: fix/main-red-concierge-mcp-name
merge into: molecule-ai:main
Conversation 0 Commits 2 Files Changed 2
+3 -3
agent-dev-a commented 2026-06-20 08:36:45 +00:00
Member
Copy Link
Copy Source

What

Fixes the undefined: conciergePlatformMCPPlugin build failure on main (65e7d2af) in the boot-time concierge re-declare path.

  • Replaces the undefined conciergePlatformMCPPlugin with conciergePlatformMCPSource in MaybeProvisionPlatformAgentOnBoot.
  • Updates the corresponding test expectation to the install name derived from the source (conciergePlatformMCPName).

seedTemplatePlugins expects plugin source URLs, not bare install names; it derives the install name via plugins.PluginNameFromSource. The primary provision path already passes conciergePlatformMCPSource; this change makes the boot re-declare path consistent.

Why

Main is red because #3051 added a call to the non-existent symbol conciergePlatformMCPPlugin in the running-but-vanilla concierge restart path.

Fixes #3051

Test plan

  • go build ./cmd/server (CI)
  • go test ./workspace-server/internal/handlers/ -run TestMaybeProvisionPlatformAgentOnBoot (CI)
  • No remaining references to conciergePlatformMCPPlugin

SOP checklist

  • Comprehensive testing performed: build+unit tests via CI; grep confirms no remaining conciergePlatformMCPPlugin references.
  • Local-postgres E2E run: N/A — Go handler-only change, no DB schema change.
  • Staging-smoke verified or pending: pending post-merge deploy pipeline.
  • Root-cause not symptom: undefined symbol conciergePlatformMCPPlugin left by #3051; replaced with existing conciergePlatformMCPSource.
  • Five-Axis review walked: minimal consistency fix, behavior matches primary provision path.
  • No backwards-compat shim / dead code added: no shim; uses existing constants.
  • Memory consulted: #3051/#3075 main-red regression notes.
## What Fixes the `undefined: conciergePlatformMCPPlugin` build failure on `main` (65e7d2af) in the boot-time concierge re-declare path. - Replaces the undefined `conciergePlatformMCPPlugin` with `conciergePlatformMCPSource` in `MaybeProvisionPlatformAgentOnBoot`. - Updates the corresponding test expectation to the install name derived from the source (`conciergePlatformMCPName`). `seedTemplatePlugins` expects plugin **source URLs**, not bare install names; it derives the install name via `plugins.PluginNameFromSource`. The primary provision path already passes `conciergePlatformMCPSource`; this change makes the boot re-declare path consistent. ## Why Main is red because #3051 added a call to the non-existent symbol `conciergePlatformMCPPlugin` in the running-but-vanilla concierge restart path. Fixes #3051 ## Test plan - `go build ./cmd/server` (CI) - `go test ./workspace-server/internal/handlers/ -run TestMaybeProvisionPlatformAgentOnBoot` (CI) - No remaining references to `conciergePlatformMCPPlugin` ## SOP checklist - **Comprehensive testing performed**: build+unit tests via CI; grep confirms no remaining `conciergePlatformMCPPlugin` references. - **Local-postgres E2E run**: N/A — Go handler-only change, no DB schema change. - **Staging-smoke verified or pending**: pending post-merge deploy pipeline. - **Root-cause not symptom**: undefined symbol `conciergePlatformMCPPlugin` left by #3051; replaced with existing `conciergePlatformMCPSource`. - **Five-Axis review walked**: minimal consistency fix, behavior matches primary provision path. - **No backwards-compat shim / dead code added**: no shim; uses existing constants. - **Memory consulted**: #3051/#3075 main-red regression notes.
agent-dev-a added 2 commits 2026-06-20 08:36:45 +00:00
fix(platform-agent): replace undefined conciergePlatformMCPPlugin with conciergePlatformMCPName
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 5s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 6s
Details
Harness Replays / detect-changes (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 8s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 17s
Details
template-delivery-e2e / detect-changes (pull_request) Successful in 13s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 15s
Details
PR Diff Guard / PR diff guard (pull_request) Successful in 15s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 20s
Details
E2E Chat / detect-changes (pull_request) Successful in 21s
Details
CI / Canvas Deploy Status (pull_request) Successful in 1s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 22s
Details
E2E Chat / E2E Chat (pull_request) Successful in 4s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 35s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 44s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 29s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1m19s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m24s
Details
CI / Platform (Go) (pull_request) Successful in 3m19s
Details
CI / all-required (pull_request) Successful in 5s
Details
qa-review / approved (pull_request_target) Approved via pull_request_review trigger
security-review / approved (pull_request_target) Approved via pull_request_review trigger
reserved-path-review / reserved-path-review (pull_request_review) Successful in 10s
Details
qa-review / approved (pull_request_review) Successful in 11s
Details
security-review / approved (pull_request_review) Successful in 11s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 15s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Workspace Requests (core#2606) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Has been cancelled
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been cancelled
Details
template-delivery-e2e / Template-asset delivery (fresh seo-agent — config+prompts via asset channel, seo-all via plugin reconcile) (pull_request) Successful in 7m11s
Details
424506da0d 
The running-but-vanilla concierge re-declare path referenced the old
symbol conciergePlatformMCPPlugin, which no longer exists. Use the
current constant conciergePlatformMCPName instead.

Fixes main-red regression at platform_agent.go:666/667.

Co-Authored-By: Claude <noreply@anthropic.com>
fix(platform-agent): pass source URL, not install name, to seedTemplatePlugins (CR review)\n\nseedTemplatePlugins expects plugin sources and derives the install name\nvia plugins.PluginNameFromSource. The boot re-declare path was passing\nthe bare install name (conciergePlatformMCPName), which would have been\nrecorded incorrectly. Use conciergePlatformMCPSource instead, matching\nthe primary provision path.\n\nCo-Authored-By: Claude <noreply@anthropic.com>
reserved-path-review / reserved-path-review (pull_request_review) Successful in 10s
Details
security-review / approved (pull_request_review) Successful in 11s
Details
qa-review / approved (pull_request_review) Successful in 11s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Workspace Requests (core#2606) (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 11s
Details
Harness Replays / detect-changes (pull_request) Successful in 10s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 17s
Details
qa-review / approved (pull_request_target) Failing after 9s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 9s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 17s
Details
security-review / approved (pull_request_target) Failing after 9s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
PR Diff Guard / PR diff guard (pull_request) Successful in 16s
Details
template-delivery-e2e / detect-changes (pull_request) Successful in 15s
Details
E2E Chat / detect-changes (pull_request) Successful in 21s
Details
CI / Detect changes (pull_request) Successful in 22s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 19s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Successful in 2s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 41s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 48s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 30s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 12s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 14s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1m24s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m22s
Details
CI / Platform (Go) (pull_request) Successful in 3m17s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
CI / all-required (pull_request) Successful in 3m6s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Successful in 7m22s
Details
template-delivery-e2e / Template-asset delivery (fresh seo-agent — config+prompts via asset channel, seo-all via plugin reconcile) (pull_request) Successful in 7m16s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 9m46s
Details
5f21ecbdf6
agent-dev-a requested review from agent-reviewer-cr2 2026-06-20 08:37:00 +00:00
agent-dev-a requested review from agent-researcher 2026-06-20 08:37:01 +00:00
agent-dev-a closed this pull request 2026-06-20 08:42:26 +00:00
Some required checks failed
reserved-path-review / reserved-path-review (pull_request_review) Successful in 10s
Details
security-review / approved (pull_request_review) Successful in 11s
Details
qa-review / approved (pull_request_review) Successful in 11s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge user_tasks (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Creates Workspace (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Workspace Requests (core#2606) (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge Platform Agent (pull_request) Has been skipped
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 7s
Details
E2E Peer Visibility (literal MCP list_peers) / detect-changes (pull_request) Successful in 11s
Details
Harness Replays / detect-changes (pull_request) Successful in 10s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Concierge (compile+skip) (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 11s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Has been skipped
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 17s
Details
qa-review / approved (pull_request_target) Failing after 9s
Required
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
Required
Details
reserved-path-review / reserved-path-review (pull_request_target) Successful in 9s
Required
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 17s
Details
security-review / approved (pull_request_target) Failing after 9s
Required
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Successful in 6s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
PR Diff Guard / PR diff guard (pull_request) Successful in 16s
Details
template-delivery-e2e / detect-changes (pull_request) Successful in 15s
Details
E2E Chat / detect-changes (pull_request) Successful in 21s
Details
CI / Detect changes (pull_request) Successful in 22s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 19s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Successful in 2s
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (stub) (pull_request) Successful in 41s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 48s
Required
Details
Local Provision Lifecycle E2E / Local Provision Lifecycle E2E (real image + MiniMax LLM, advisory) (pull_request) Successful in 30s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 12s
Details
gate-check-v3 / gate-check (pull_request_target) Failing after 14s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1m24s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2m22s
Required
Details
CI / Platform (Go) (pull_request) Successful in 3m17s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
CI / all-required (pull_request) Successful in 3m6s
Required
Details
E2E Staging SaaS (full lifecycle) / E2E Staging Platform Boot (pull_request) Successful in 7m22s
Details
template-delivery-e2e / Template-asset delivery (fresh seo-agent — config+prompts via asset channel, seo-all via plugin reconcile) (pull_request) Successful in 7m16s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 9m46s
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-reviewer-cr2
agent-researcher
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#3097
Delete Branch "fix/main-red-concierge-mcp-name"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?