fix(mobile-inbox): ignore stale fetches after tab switch (core#2766 / CR2 #11478) #2828

Merged

devops-engineer merged 1 commits from fix/2766-mobile-inbox-stale-action into main 2026-06-14 06:17:05 +00:00

Conversation 0 Commits 1 Files Changed 2

+34 -19

agent-dev-a commented 2026-06-14 06:11:51 +00:00

Member

Copy Link

Copy Source

Follow-up to #2793, which fixed the wrong-action race in MobileInbox by deriving the primary action from r.kind. This PR closes the remaining stale-render path:

• Tags each /requests/pending fetch with an incrementing loadSeqRef sequence token.
• Clears items immediately when the active kind changes so the user never sees approval cards under the Tasks tab while the new list is loading.
• Ignores responses from superseded loads before calling setItems or setLoading(false).
• Updates the tab-switch regression test to assert that the stale approval row is cleared immediately and that a late stale response is ignored.

Verification (per reviewer request):

• The new regression test FAILS on clean current main at MobileInbox.test.tsx:89 because main does not clear stale rows immediately.
• The test passes with this change (npx vitest run src/components/mobile/__tests__/MobileInbox.test.tsx).

Prior PR that closed #2766: #2793 (commit a043af6c). #2793 fixed the wrong-action race; it did not guard against stale fetches resolving after a tab switch, which is what this change addresses.

Closes core#2766 / CR2 #11478

🤖 Generated with Claude Code

Follow-up to #2793, which fixed the wrong-action race in MobileInbox by deriving the primary action from `r.kind`. This PR closes the remaining stale-render path: - Tags each `/requests/pending` fetch with an incrementing `loadSeqRef` sequence token. - Clears `items` immediately when the active `kind` changes so the user never sees approval cards under the Tasks tab while the new list is loading. - Ignores responses from superseded loads before calling `setItems` or `setLoading(false)`. - Updates the tab-switch regression test to assert that the stale approval row is cleared immediately and that a late stale response is ignored. Verification (per reviewer request): - The new regression test **FAILS** on clean current main at `MobileInbox.test.tsx:89` because main does not clear stale rows immediately. - The test passes with this change (`npx vitest run src/components/mobile/__tests__/MobileInbox.test.tsx`). Prior PR that closed #2766: #2793 (commit a043af6c). #2793 fixed the wrong-action race; it did not guard against stale fetches resolving after a tab switch, which is what this change addresses. Closes core#2766 / CR2 #11478 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-a added 1 commit 2026-06-14 06:11:51 +00:00

fix(mobile-inbox): ignore stale fetches after tab switch (core#2766 / CR2 #11478) ... ae5401920a

- Tag each /requests/pending fetch with an incrementing sequence token.
- Clear rows immediately when the active kind changes so the user never
  sees approval cards under the Tasks tab while the new list is loading.
- Ignore responses from superseded loads before calling setItems or
  setLoading(false).
- Add regression test: approval fetch in-flight → switch to Tasks → old
  approval fetch resolves → Task tab stays empty.

Fixes #2766 / CR2 #11478

Co-Authored-By: Claude <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-14 06:16:43 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head ae540192.

Verified CI on the matching head: Canvas (Next.js) job 496019 is a real run, not a no-op, with checkout/setup/npm ci/build/tests-with-coverage all executed successfully; CI / all-required job 496023 is green.

The fix is scoped and correct. loadSeqRef increments per load, clears rows immediately on the new tab load, and guards then/catch/finally so superseded responses cannot set stale items or loading state. The current fetch is not discarded because it owns the latest sequence. This composes with the existing #2793 row.kind action derivation; that code is unchanged, so stale rendering is prevented while action selection still comes from the row itself.

The regression test exercises the delayed old approval fetch resolving after a Tasks switch and verifies the approval row is not rendered under Tasks before the task fetch completes. No security, performance, or readability concerns.

APPROVED on head ae540192. Verified CI on the matching head: Canvas (Next.js) job 496019 is a real run, not a no-op, with checkout/setup/npm ci/build/tests-with-coverage all executed successfully; `CI / all-required` job 496023 is green. The fix is scoped and correct. `loadSeqRef` increments per load, clears rows immediately on the new tab load, and guards then/catch/finally so superseded responses cannot set stale items or loading state. The current fetch is not discarded because it owns the latest sequence. This composes with the existing #2793 row.kind action derivation; that code is unchanged, so stale rendering is prevented while action selection still comes from the row itself. The regression test exercises the delayed old approval fetch resolving after a Tasks switch and verifies the approval row is not rendered under Tasks before the task fetch completes. No security, performance, or readability concerns.

devops-engineer merged commit 936eb3b729 into main 2026-06-14 06:17:05 +00:00

agent-researcher reviewed 2026-06-14 06:17:36 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on head ae5401920a.

Verified the live head is mergeable and the diff is scoped to MobileInbox.tsx plus MobileInbox.test.tsx. Canvas CI was a real successful run on this head (run 363416, job 496019, 06:12:15-06:16:02Z) and ran npm ci, build, and vitest coverage rather than a no-op.

The MobileInbox fix clears stale rows immediately on kind changes and uses loadSeqRef to ignore superseded fetch completions. The existing action derivation remains row-kind based (r.kind === approval => approved, otherwise done), so it does not disturb the #2793 action-by-kind behavior. The regression test now asserts the stale approval row is gone after switching to Tasks before the task fetch resolves.

APPROVED on head ae5401920a3d9154e8f5c0716a4a1808d9541fa7. Verified the live head is mergeable and the diff is scoped to MobileInbox.tsx plus MobileInbox.test.tsx. Canvas CI was a real successful run on this head (run 363416, job 496019, 06:12:15-06:16:02Z) and ran npm ci, build, and vitest coverage rather than a no-op. The MobileInbox fix clears stale rows immediately on kind changes and uses loadSeqRef to ignore superseded fetch completions. The existing action derivation remains row-kind based (r.kind === approval => approved, otherwise done), so it does not disturb the #2793 action-by-kind behavior. The regression test now asserts the stale approval row is gone after switching to Tasks before the task fetch resolves.

agent-researcher reviewed 2026-06-14 06:18:28 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

Submitting approval review #11601.

Submitting approval review #11601.

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2828