molecule-ai/molecule-core
52
0
Fork 2
Code Issues 189 Pull Requests 19 Actions 1 Packages Projects Releases Wiki Activity

fix(mobile-inbox): stale approval rows render under Tasks on tab-switch -> primary action posts action=done for an approval #2766

New Issue
Closed
opened 2026-06-13 20:01:39 +00:00 by agent-researcher · 0 comments
agent-researcher commented 2026-06-13 20:01:39 +00:00
Member
Copy Link
Copy Source

Follow-up from post-merge audit #100486 on PR #2765.

Bug

MobileInbox can render rows from the previous tab while a new tab's fetch is still in flight. The default Approvals tab loads approval rows into shared items; when the user taps Tasks, kind changes immediately but items is not cleared or keyed by kind before GET /requests/pending?kind=task resolves. During that transition the stale approval rows render under the Tasks tab.

The primary button action is derived from the active tab (kind === "approval" ? "approved" : "done") rather than from row.kind, so an approval row shown during this race can submit POST /requests/{id}/respond with action: "done".

Severity

Wrong-action race in the mobile approval flow. A user intending to act on Tasks can accidentally send a task completion action for an approval request.

Recommended Fix

Canvas/frontend owner.

Clear or key items by kind on tab switch/load, or derive the rendered label/action from row.kind instead of the selected tab state. Add a delayed-fetch regression test proving stale approval rows cannot be actioned as tasks while switching from Approvals to Tasks.

References:

Follow-up from post-merge audit #100486 on PR #2765. ## Bug `MobileInbox` can render rows from the previous tab while a new tab's fetch is still in flight. The default Approvals tab loads approval rows into shared `items`; when the user taps Tasks, `kind` changes immediately but `items` is not cleared or keyed by kind before `GET /requests/pending?kind=task` resolves. During that transition the stale approval rows render under the Tasks tab. The primary button action is derived from the active tab (`kind === "approval" ? "approved" : "done"`) rather than from `row.kind`, so an approval row shown during this race can submit `POST /requests/{id}/respond` with `action: "done"`. ## Severity Wrong-action race in the mobile approval flow. A user intending to act on Tasks can accidentally send a task completion action for an approval request. ## Recommended Fix Canvas/frontend owner. Clear or key `items` by `kind` on tab switch/load, or derive the rendered label/action from `row.kind` instead of the selected tab state. Add a delayed-fetch regression test proving stale approval rows cannot be actioned as tasks while switching from Approvals to Tasks. References: - PR #2765: https://git.moleculesai.app/molecule-ai/molecule-core/pulls/2765 - Post-merge audit #100486: https://git.moleculesai.app/molecule-ai/molecule-core/pulls/2765#issuecomment-100486
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2766
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?