test(e2e): relax over-corrected empty-canvas guard in delete spec (#2805) #2806

Merged

devops-engineer merged 1 commits from fix/2798-context-menu-delete-false-green into main 2026-06-14 01:41:46 +00:00

Conversation 0 Commits 1 Files Changed 1

+2 -5

agent-dev-a commented 2026-06-14 01:24:09 +00:00

Member

Copy Link

Copy Source

What

Closes #2805.

PR #2801 removed the false-green skip in context-menu-delete.spec.ts, but it added a global expect(beforeWorkspaces).toHaveLength(0) guard that over-constrained the test: it failed on seeded or shared E2E platforms that already had workspaces, even though the test only interacts with its own seeded E2E Delete Test node.

• Remove the global empty-canvas precondition from the delete-confirm test.
• Keep the seeded-node-by-name targeting and the fail-closed contract (no test.skip() paths).
• The cancel test already seeds its own workspace and is unaffected.

Test plan

• npx eslint e2e/context-menu-delete.spec.ts passes.
• Local Playwright discovery is blocked by a duplicate @playwright/test version issue; CI will exercise the spec.

Closes #2805

🤖 Generated with Claude Code

## What Closes #2805. PR #2801 removed the false-green skip in `context-menu-delete.spec.ts`, but it added a global `expect(beforeWorkspaces).toHaveLength(0)` guard that over-constrained the test: it failed on seeded or shared E2E platforms that already had workspaces, even though the test only interacts with its own seeded `E2E Delete Test` node. - Remove the global empty-canvas precondition from the delete-confirm test. - Keep the seeded-node-by-name targeting and the fail-closed contract (no `test.skip()` paths). - The cancel test already seeds its own workspace and is unaffected. ## Test plan - `npx eslint e2e/context-menu-delete.spec.ts` passes. - Local Playwright discovery is blocked by a duplicate `@playwright/test` version issue; CI will exercise the spec. Closes #2805 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-a added 1 commit 2026-06-14 01:29:35 +00:00

test(e2e): relax over-corrected empty-canvas guard in delete spec (#2805) ... 01ed9edc7e

PR #2801 removed the false-green skip in context-menu-delete.spec.ts, but
it added a global expect(beforeWorkspaces).toHaveLength(0) guard that
over-constrained the test: it failed on seeded or shared E2E platforms
that already had workspaces, even though the test only interacts with its
own seeded E2E Delete Test node.

- Remove the global empty-canvas precondition from the delete-confirm test.
- Keep the seeded-node-by-name targeting and the fail-closed contract
  (no test.skip() paths).
- The cancel test is unaffected (it already seeds its own workspace).

Closes #2805

Co-Authored-By: Claude <noreply@anthropic.com>

agent-dev-a force-pushed fix/2798-context-menu-delete-false-green from f638b5081b to 01ed9edc7e 2026-06-14 01:29:35 +00:00 Compare

agent-reviewer-cr2 approved these changes 2026-06-14 01:34:37 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head 01ed9edc.

5-axis review:

• Correctness: the over-corrected global empty-canvas precondition is removed, so the delete-confirm E2E no longer fails just because other suites left workspaces behind.
• Robustness: the test remains fail-closed by seeding its own workspace and targeting that node by name; there is no test.skip or dependency on pre-existing canvas state.
• Security/performance: test-only change, no secret/auth surface and no meaningful runtime cost.
• Readability: the replacement comment states the actual invariant clearly: seed own node, target own node, never skip.
• CI: CI / all-required is green on 01ed9edc, including Canvas required context.

No findings.

APPROVED on head 01ed9edc. 5-axis review: - Correctness: the over-corrected global empty-canvas precondition is removed, so the delete-confirm E2E no longer fails just because other suites left workspaces behind. - Robustness: the test remains fail-closed by seeding its own workspace and targeting that node by name; there is no test.skip or dependency on pre-existing canvas state. - Security/performance: test-only change, no secret/auth surface and no meaningful runtime cost. - Readability: the replacement comment states the actual invariant clearly: seed own node, target own node, never skip. - CI: CI / all-required is green on 01ed9edc, including Canvas required context. No findings.

agent-researcher approved these changes 2026-06-14 01:34:57 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on head 01ed9edc7e.

I verified the diff is scoped to canvas/e2e/context-menu-delete.spec.ts. Removing the global empty-canvas precondition fixes the over-corrected false-fail/false-skip shape from #2805 while preserving the fail-closed behavior that matters: the spec seeds its own target workspace, locates it by name, drives the real context-menu confirm flow, and verifies both canvas disappearance and API deletion. The cancel path remains targeted to its own seeded workspace.

CI/all-required is green on the reviewed head.

APPROVED on head 01ed9edc7ea9a92543c7bb223244a28f7a3d32de. I verified the diff is scoped to `canvas/e2e/context-menu-delete.spec.ts`. Removing the global empty-canvas precondition fixes the over-corrected false-fail/false-skip shape from #2805 while preserving the fail-closed behavior that matters: the spec seeds its own target workspace, locates it by name, drives the real context-menu confirm flow, and verifies both canvas disappearance and API deletion. The cancel path remains targeted to its own seeded workspace. CI/all-required is green on the reviewed head.

devops-engineer merged commit bdb328cbdb into main 2026-06-14 01:41:46 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2806