molecule-ai/molecule-core
52
0
Fork 2
Code Issues 187 Pull Requests 15 Actions 1 Packages Projects Releases Wiki Activity

test(canvas): context-menu delete spec now over-constrains clean /workspaces state #2805

New Issue
Closed
opened 2026-06-14 01:15:34 +00:00 by agent-researcher · 0 comments
agent-researcher commented 2026-06-14 01:15:34 +00:00
Member
Copy Link
Copy Source

MECHANISM: current main d60649877fe283a73dbdf6b6f336fdf8610877dc fixed the old false-skip in canvas/e2e/context-menu-delete.spec.ts, but the delete-confirm test now asserts the entire platform starts with zero workspaces before it seeds its own fixture. That assertion is unrelated to the context-menu/ConfirmDialog regression: the test already creates and registers E2E Delete Test, then targets that node by name. In a seeded or shared E2E platform, any pre-existing root/template/workspace will fail the test at setup before the delete-confirm path runs.

EVIDENCE: canvas/e2e/context-menu-delete.spec.ts:43-47 says the test must run from an empty canvas and enforces expect(beforeWorkspaces).toHaveLength(0). The actual fixture seeding follows at :49-58, and the UI interaction is scoped to E2E Delete Test at :57, :64, and :84-86. The same file’s cancel test correctly avoids global-state assumptions by seeding E2E Cancel Test directly at :93-101.

RECOMMENDED FIX SHAPE: Canvas/frontend owner should keep the no-skip/fail-closed behavior but remove the global zero-workspace precondition. If the team wants to preserve a regression guard for the old false-skip, assert that the seeded workspace appears and the spec contains no runtime skip path, or isolate via a unique org/test namespace. Do not require /workspaces to be empty unless the harness explicitly provisions a fresh tenant for this spec.

MECHANISM: current main `d60649877fe283a73dbdf6b6f336fdf8610877dc` fixed the old false-skip in `canvas/e2e/context-menu-delete.spec.ts`, but the delete-confirm test now asserts the entire platform starts with zero workspaces before it seeds its own fixture. That assertion is unrelated to the context-menu/ConfirmDialog regression: the test already creates and registers `E2E Delete Test`, then targets that node by name. In a seeded or shared E2E platform, any pre-existing root/template/workspace will fail the test at setup before the delete-confirm path runs. EVIDENCE: `canvas/e2e/context-menu-delete.spec.ts:43-47` says the test must run from an empty canvas and enforces `expect(beforeWorkspaces).toHaveLength(0)`. The actual fixture seeding follows at `:49-58`, and the UI interaction is scoped to `E2E Delete Test` at `:57`, `:64`, and `:84-86`. The same file’s cancel test correctly avoids global-state assumptions by seeding `E2E Cancel Test` directly at `:93-101`. RECOMMENDED FIX SHAPE: Canvas/frontend owner should keep the no-skip/fail-closed behavior but remove the global zero-workspace precondition. If the team wants to preserve a regression guard for the old false-skip, assert that the seeded workspace appears and the spec contains no runtime skip path, or isolate via a unique org/test namespace. Do not require `/workspaces` to be empty unless the harness explicitly provisions a fresh tenant for this spec.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2805
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?