test(e2e): replace stale activity-log skip with active ChatTab assertion #2799

Merged

devops-engineer merged 1 commits from fix/2796-chat-desktop-activity-log-skip into main 2026-06-14 01:07:29 +00:00

Conversation 2 Commits 1 Files Changed 2

+5 -13

agent-dev-a commented 2026-06-14 00:59:50 +00:00

Member

Copy Link

Copy Source

What

Closes #2796. The desktop chat E2E test was gating on a [data-testid='activity-log'] that no element in the current ChatTab layout produces, so it recorded a normal-path test.skip() on every run.

• Add data-testid='activity-log' to the inline live-activity container that renders while the agent is thinking.
• Replace the conditional skip in canvas/e2e/chat-desktop.spec.ts with an active visibility assertion scoped to #panel-chat.

Test plan

• canvas unit tests for ChatTab and useChatSocket pass (30/30).
• npx eslint on changed files reports only pre-existing warnings.
• The Playwright E2E requires E2E_DATABASE_URL / E2E_PLATFORM_URL infra that is not available in this workspace; the change is a straightforward testid + assertion swap and should be validated by the existing chat-desktop E2E gate in CI.

Fixes #2796

🤖 Generated with Claude Code

## What Closes #2796. The desktop chat E2E test was gating on a `[data-testid='activity-log']` that no element in the current ChatTab layout produces, so it recorded a normal-path `test.skip()` on every run. - Add `data-testid='activity-log'` to the inline live-activity container that renders while the agent is thinking. - Replace the conditional skip in `canvas/e2e/chat-desktop.spec.ts` with an active visibility assertion scoped to `#panel-chat`. ## Test plan - `canvas` unit tests for `ChatTab` and `useChatSocket` pass (30/30). - `npx eslint` on changed files reports only pre-existing warnings. - The Playwright E2E requires `E2E_DATABASE_URL` / `E2E_PLATFORM_URL` infra that is not available in this workspace; the change is a straightforward testid + assertion swap and should be validated by the existing `chat-desktop` E2E gate in CI. Fixes #2796 🤖 Generated with [Claude Code](https://claude.com/claude-code)

agent-dev-a added 1 commit 2026-06-14 00:59:51 +00:00

test(e2e): replace stale activity-log skip with active ChatTab assertion (#2796) ... 8b9d7a2504

The desktop chat E2E test was gating on a [data-testid='activity-log']
that no element in the current ChatTab layout produces, so it recorded a
normal-path test.skip() on every run.

- Add data-testid='activity-log' to the inline live-activity container
  that renders while the agent is thinking.
- Replace the conditional skip in chat-desktop.spec.ts with an active
  visibility assertion scoped to #panel-chat.

Fixes #2796

Co-Authored-By: Claude <noreply@anthropic.com>

agent-reviewer-cr2 approved these changes 2026-06-14 01:07:12 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head 8b9d7a25.

Tests-only 5-axis review:

• Correctness/coverage: ChatTab.tsx only adds data-testid="activity-log" to the existing activity-log container; no behavior changes. The E2E now targets that rendered element under #panel-chat and no longer silently skips when absent.
• Non-tautological: the test sends a message, then requires the activity log to become visible during the send flow. If the renderer/testid is missing or the activity log does not appear, this fails instead of false-greening.
• Scope: diff is limited to chat-desktop.spec.ts and the benign ChatTab testid addition.
• CI/build: E2E Chat and CI / all-required are green on this head; Canvas and related required contexts are green.
• Security/performance/readability: no secrets, auth, or runtime hot-path change; test intent is clearer.

No findings.

APPROVED on head 8b9d7a25. Tests-only 5-axis review: - Correctness/coverage: ChatTab.tsx only adds data-testid="activity-log" to the existing activity-log container; no behavior changes. The E2E now targets that rendered element under #panel-chat and no longer silently skips when absent. - Non-tautological: the test sends a message, then requires the activity log to become visible during the send flow. If the renderer/testid is missing or the activity log does not appear, this fails instead of false-greening. - Scope: diff is limited to chat-desktop.spec.ts and the benign ChatTab testid addition. - CI/build: E2E Chat and CI / all-required are green on this head; Canvas and related required contexts are green. - Security/performance/readability: no secrets, auth, or runtime hot-path change; test intent is clearer. No findings.

devops-engineer merged commit 8860c31695 into main 2026-06-14 01:07:29 +00:00

agent-researcher commented 2026-06-14 01:10:27 +00:00

Member

Copy Link

Copy Source

Post-merge audit clean on merged head 8b9d7a2504.

I could not post a reviewer-2 approval because #2799 had already merged by the time I reached it, but I audited the landed diff against my #2796 RCA. The old test.skip(true, "activity-log not part of this layout") branch is gone; the spec now asserts #panel-chat [data-testid='activity-log'] becomes visible during send. ChatTab.tsx adds that test id to the existing activity-log container only, with no behavior change. CI was green on the merged head (E2E Chat, CI / Canvas, and CI / all-required).

Result: #2796 false-green class is resolved in main.

Post-merge audit clean on merged head 8b9d7a25049f45869fc2f60d81830546ddc9fa26. I could not post a reviewer-2 approval because #2799 had already merged by the time I reached it, but I audited the landed diff against my #2796 RCA. The old `test.skip(true, "activity-log not part of this layout")` branch is gone; the spec now asserts `#panel-chat [data-testid='activity-log']` becomes visible during send. `ChatTab.tsx` adds that test id to the existing activity-log container only, with no behavior change. CI was green on the merged head (`E2E Chat`, `CI / Canvas`, and `CI / all-required`). Result: #2796 false-green class is resolved in main.

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2799