test(e2e-chat): desktop activity-log assertion always skips on current layout #2796

Closed
opened 2026-06-14 00:39:04 +00:00 by agent-researcher · 0 comments
Member

MECHANISM: canvas/e2e/chat-desktop.spec.ts:120-138 contains an E2E assertion named activity log appears during send, but it first checks for [data-testid='activity-log'] and calls test.skip(true, "activity-log not part of this layout") when absent. Current desktop chat surfaces use ChatTab / AgentCommsPanel and repo-wide grep finds no producer for that data-testid, so the activity-log assertion is recorded as a skip instead of exercising send-time activity visibility.

EVIDENCE: audit on main e946bca969895763affc20f68a8f2675249af32b found the unconditional runtime skip path at canvas/e2e/chat-desktop.spec.ts:132-135; blame points to 10b7f8a99 (2026-06-04 false-green fix). Concrete skipped-log text is activity-log not part of this layout. Related grep found references in comments/tests only, not a rendered [data-testid='activity-log'] element in canvas/src/components/tabs/ChatTab.tsx or AgentCommsPanel.tsx.

RECOMMENDED FIX SHAPE: Canvas/frontend owner should either move this assertion to the surface that actually renders activity rows (for example Agent Comms/activity feed with a stable test id) or remove/replace the stale desktop-chat activity-log check with an active assertion that is expected in the current layout. Do not leave a normal-path test.skip(true) in the main E2E Chat lane; if optional layout coverage is still desired, split it into an explicitly scoped optional spec.

MECHANISM: `canvas/e2e/chat-desktop.spec.ts:120-138` contains an E2E assertion named `activity log appears during send`, but it first checks for `[data-testid='activity-log']` and calls `test.skip(true, "activity-log not part of this layout")` when absent. Current desktop chat surfaces use `ChatTab` / `AgentCommsPanel` and repo-wide grep finds no producer for that `data-testid`, so the activity-log assertion is recorded as a skip instead of exercising send-time activity visibility. EVIDENCE: audit on main `e946bca969895763affc20f68a8f2675249af32b` found the unconditional runtime skip path at `canvas/e2e/chat-desktop.spec.ts:132-135`; blame points to `10b7f8a99` (2026-06-04 false-green fix). Concrete skipped-log text is `activity-log not part of this layout`. Related grep found references in comments/tests only, not a rendered `[data-testid='activity-log']` element in `canvas/src/components/tabs/ChatTab.tsx` or `AgentCommsPanel.tsx`. RECOMMENDED FIX SHAPE: Canvas/frontend owner should either move this assertion to the surface that actually renders activity rows (for example Agent Comms/activity feed with a stable test id) or remove/replace the stale desktop-chat activity-log check with an active assertion that is expected in the current layout. Do not leave a normal-path `test.skip(true)` in the main E2E Chat lane; if optional layout coverage is still desired, split it into an explicitly scoped optional spec.
Sign in to join this conversation.
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2796