molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 14 Actions Packages Projects Releases Wiki Activity

test(canvas): context-menu delete spec skips delete-confirm path when workspace list is empty #2798

New Issue
Closed
opened 2026-06-14 00:59:33 +00:00 by agent-researcher · 0 comments
agent-researcher commented 2026-06-14 00:59:33 +00:00
Member
Copy Link
Copy Source

MECHANISM: canvas/e2e/context-menu-delete.spec.ts has a suite-wide beforeEach that GETs /workspaces and calls test.skip(...) when the list is empty (context-menu-delete.spec.ts:19-25). That incorrectly suppresses the primary delete-confirm test even though that test creates its own leaf workspace before opening the canvas (context-menu-delete.spec.ts:28-37). On a clean/ephermeral canvas environment with zero pre-existing workspaces, the regression path from PR #1133 can false-green instead of proving the portal ConfirmDialog survives context-menu unmount and deletes the created workspace.

EVIDENCE: current main 1f9b2f4f0beb89c8592c5111cddf6400aa8822fa still has the skip gate at canvas/e2e/context-menu-delete.spec.ts:23-24 (No workspaces on canvas) immediately before the self-seeding test body at :32-37. The second cancel test has a separate legitimate dependency on an existing workspace (:91-98), but the delete-confirm test does not. Open issue scan found #2794 and #2796 for other skip/false-green cases; no existing context-menu-delete issue was open.

RECOMMENDED FIX SHAPE: Canvas/frontend owner should split the setup by test. Remove the suite-level empty-workspace skip for the delete-confirm case and let that test create/register its own workspace unconditionally, failing if create/register/canvas render fails. Keep or replace the cancel-path dependency with explicit fixture seeding so both tests are fail-closed. Add a regression assertion that the delete-confirm test runs in an initially empty /workspaces response rather than skipping.

MECHANISM: `canvas/e2e/context-menu-delete.spec.ts` has a suite-wide `beforeEach` that GETs `/workspaces` and calls `test.skip(...)` when the list is empty (`context-menu-delete.spec.ts:19-25`). That incorrectly suppresses the primary delete-confirm test even though that test creates its own leaf workspace before opening the canvas (`context-menu-delete.spec.ts:28-37`). On a clean/ephermeral canvas environment with zero pre-existing workspaces, the regression path from PR #1133 can false-green instead of proving the portal ConfirmDialog survives context-menu unmount and deletes the created workspace. EVIDENCE: current main `1f9b2f4f0beb89c8592c5111cddf6400aa8822fa` still has the skip gate at `canvas/e2e/context-menu-delete.spec.ts:23-24` (`No workspaces on canvas`) immediately before the self-seeding test body at `:32-37`. The second cancel test has a separate legitimate dependency on an existing workspace (`:91-98`), but the delete-confirm test does not. Open issue scan found #2794 and #2796 for other skip/false-green cases; no existing context-menu-delete issue was open. RECOMMENDED FIX SHAPE: Canvas/frontend owner should split the setup by test. Remove the suite-level empty-workspace skip for the delete-confirm case and let that test create/register its own workspace unconditionally, failing if create/register/canvas render fails. Keep or replace the cancel-path dependency with explicit fixture seeding so both tests are fail-closed. Add a regression assertion that the delete-confirm test runs in an initially empty `/workspaces` response rather than skipping.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2798
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?