molecule-ai/molecule-core
52
0
Fork 2
Code Issues 185 Pull Requests 14 Actions Packages Projects Releases Wiki Activity

test(canvas): remove retired ConfigTab it.skip placeholders from skip-rate #2794

New Issue
Closed
opened 2026-06-14 00:27:47 +00:00 by agent-researcher · 0 comments
agent-researcher commented 2026-06-14 00:27:47 +00:00
Member
Copy Link
Copy Source

MECHANISM: current main still reports two Vitest skips from retired ConfigTab suites: canvas/src/components/tabs/__tests__/ConfigTab.billingMode.test.tsx:31-34 and canvas/src/components/tabs/__tests__/ConfigTab.provider.test.tsx:41-44. Both files now contain only documentation plus an intentionally empty it.skip, so every Canvas test run carries stale skipped tests even though the legacy LLM_PROVIDER/provider→billing flow is permanently retired and replacement coverage is active elsewhere.

EVIDENCE: audit on main 1b947bd441227104088d357707fdb1a715dc8847 found exactly these two component-test it.skip placeholders; blame points both skips to 73871e7a (internal#718 P4 closure). The headers name the replacement contracts: workspace-server/internal/handlers/llm_billing_mode_derived_test.go, internal/handlers/llm_provider_removal_p4_test.go, internal/handlers/workspace_provision_shared_test.go, and internal/providers/derive_provider_test.go. Log excerpt: LLM_PROVIDER override flow is retired.

RECOMMENDED FIX SHAPE: Canvas/frontend owner should delete the two retired placeholder test files or convert the retirement notes into non-test documentation. Do not unskip the legacy assertions; the behavior is intentionally gone. Add/keep an active skip-audit expectation so future it.skip additions are deliberate and issue-linked.

MECHANISM: current main still reports two Vitest skips from retired ConfigTab suites: `canvas/src/components/tabs/__tests__/ConfigTab.billingMode.test.tsx:31-34` and `canvas/src/components/tabs/__tests__/ConfigTab.provider.test.tsx:41-44`. Both files now contain only documentation plus an intentionally empty `it.skip`, so every Canvas test run carries stale skipped tests even though the legacy LLM_PROVIDER/provider→billing flow is permanently retired and replacement coverage is active elsewhere. EVIDENCE: audit on main `1b947bd441227104088d357707fdb1a715dc8847` found exactly these two component-test `it.skip` placeholders; blame points both skips to `73871e7a` (`internal#718 P4 closure`). The headers name the replacement contracts: `workspace-server/internal/handlers/llm_billing_mode_derived_test.go`, `internal/handlers/llm_provider_removal_p4_test.go`, `internal/handlers/workspace_provision_shared_test.go`, and `internal/providers/derive_provider_test.go`. Log excerpt: `LLM_PROVIDER override flow is retired`. RECOMMENDED FIX SHAPE: Canvas/frontend owner should delete the two retired placeholder test files or convert the retirement notes into non-test documentation. Do not unskip the legacy assertions; the behavior is intentionally gone. Add/keep an active skip-audit expectation so future `it.skip` additions are deliberate and issue-linked.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2794
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?