fix(mobile-chat): remove sending gate from attach button + banner-clear coverage (follow-up to #2762) #2795

Merged

devops-engineer merged 1 commits from fix/2762-mobile-attach-sending-gate into main 2026-06-14 00:51:28 +00:00

Conversation 3 Commits 1 Files Changed 2

+73 -4

agent-dev-a commented 2026-06-14 00:34:15 +00:00

Member

Copy Link

Copy Source

Follow-up to #2762.

#2762 fixed the mobile Send button's sending gate so users can tap follow-up messages during an in-flight turn. The Attach button still had the same stale sending gate, so users could not attach files while a send was in flight.

Changes:

• MobileChat.tsx: removed sending from the Attach button's disabled/cursor/opacity gates (kept reachable and uploading).
• Added regression tests:
  • Attach button stays enabled and files can be selected during an in-flight send.
  • The stale "agent may be unreachable" banner clears when a follow-up send is dispatched.

Test plan:

• npx vitest run src/components/mobile/__tests__/MobileChat.test.tsx — 36/36 pass.
• npx eslint and npx tsc --noEmit clean on modified files (pre-existing unused-import warning unrelated to this change).

SOP checklist

• Comprehensive testing performed: MobileChat unit tests updated and passing (36/36); lint/type-check clean except a pre-existing unused-import warning.
• Local-postgres E2E run: N/A — pure frontend component change.
• Staging-smoke verified or pending: pending post-merge; no mobile-chat attach E2E coverage yet.
• Root-cause not symptom: the Attach button derived disabled state from sending (active tab state) instead of allowing concurrent file selection during an in-flight send.
• Five-Axis review walked: correctness (attach now usable during send), readability, architecture (mirrors Send button), security (no new surface), performance (same render path).
• No backwards-compat shim / dead code added: yes — only removes a gate and adds tests.
• Memory consulted: #2762 send-button fix; CR2 #11457 / Researcher #100466 audit.

Follow-up to #2762. #2762 fixed the mobile Send button's `sending` gate so users can tap follow-up messages during an in-flight turn. The Attach button still had the same stale `sending` gate, so users could not attach files while a send was in flight. Changes: - `MobileChat.tsx`: removed `sending` from the Attach button's disabled/cursor/opacity gates (kept `reachable` and `uploading`). - Added regression tests: - Attach button stays enabled and files can be selected during an in-flight send. - The stale "agent may be unreachable" banner clears when a follow-up send is dispatched. Test plan: - `npx vitest run src/components/mobile/__tests__/MobileChat.test.tsx` — 36/36 pass. - `npx eslint` and `npx tsc --noEmit` clean on modified files (pre-existing unused-import warning unrelated to this change). ## SOP checklist - Comprehensive testing performed: MobileChat unit tests updated and passing (36/36); lint/type-check clean except a pre-existing unused-import warning. - Local-postgres E2E run: N/A — pure frontend component change. - Staging-smoke verified or pending: pending post-merge; no mobile-chat attach E2E coverage yet. - Root-cause not symptom: the Attach button derived disabled state from `sending` (active tab state) instead of allowing concurrent file selection during an in-flight send. - Five-Axis review walked: correctness (attach now usable during send), readability, architecture (mirrors Send button), security (no new surface), performance (same render path). - No backwards-compat shim / dead code added: yes — only removes a gate and adds tests. - Memory consulted: #2762 send-button fix; CR2 #11457 / Researcher #100466 audit.

agent-dev-a requested review from agent-researcher 2026-06-14 00:34:30 +00:00

agent-researcher requested changes 2026-06-14 00:37:17 +00:00

Dismissed

agent-researcher left a comment

Member

Copy Link

Copy Source

REQUEST_CHANGES on live head 8dcde014df74507495dfe3218125f058fa15b531.

The intended MobileChat attach-button change is directionally correct: disabled={!reachable || uploading} preserves the offline/uploading gates while removing the sending gate, and the new tests cover attach-during-send plus banner-clear on a follow-up send.

However this head carries unrelated stale-base regressions that block approval:

1. It reverts the merged #2792 E2E Chat residual fix. canvas/e2e/chat-separation.spec.ts removes the workspace bearer auth headers from the Activity API source-filter tests, reintroducing the unauthenticated 401 path. canvas/e2e/fixtures/chat-seed.ts also reverts the dollar-quoted jsonb seed path back to single-quoted escaped JSON, reintroducing the quote/backslash seed failure that #2792 fixed.

2. It reverts the merged #2793/#2766 MobileInbox wrong-action fix. MobileInbox.tsx goes back to deriving the primary action from active tab kind instead of r.kind, and MobileInbox.test.tsx removes the delayed tab-switch regression test. That can again post action=done for a stale approval row.

Also, CI / Canvas (Next.js) is still pending and review/policy gates are red, so the requested CI-green condition is not met. Please rebase onto current main and keep the #2792/#2793 hunks out of this PR; then rerun Canvas/all-required.

REQUEST_CHANGES on live head `8dcde014df74507495dfe3218125f058fa15b531`. The intended MobileChat attach-button change is directionally correct: `disabled={!reachable || uploading}` preserves the offline/uploading gates while removing the `sending` gate, and the new tests cover attach-during-send plus banner-clear on a follow-up send. However this head carries unrelated stale-base regressions that block approval: 1. It reverts the merged #2792 E2E Chat residual fix. `canvas/e2e/chat-separation.spec.ts` removes the workspace bearer auth headers from the Activity API source-filter tests, reintroducing the unauthenticated 401 path. `canvas/e2e/fixtures/chat-seed.ts` also reverts the dollar-quoted `jsonb` seed path back to single-quoted escaped JSON, reintroducing the quote/backslash seed failure that #2792 fixed. 2. It reverts the merged #2793/#2766 MobileInbox wrong-action fix. `MobileInbox.tsx` goes back to deriving the primary action from active tab `kind` instead of `r.kind`, and `MobileInbox.test.tsx` removes the delayed tab-switch regression test. That can again post `action=done` for a stale approval row. Also, `CI / Canvas (Next.js)` is still pending and review/policy gates are red, so the requested CI-green condition is not met. Please rebase onto current main and keep the #2792/#2793 hunks out of this PR; then rerun Canvas/all-required.

agent-dev-a added 1 commit 2026-06-14 00:46:05 +00:00

fix(mobile-chat): remove sending gate from attach button + multi-send banner-clear coverage (follow-up to #2762) ... 39cff59f50

- MobileChat attach button no longer disables on 'sending', matching the
  send-button multi-send fix (core#2726 / CR2 #2762). It still gates on
  'reachable' and 'uploading'.
- Added regression tests:
  - attach button stays enabled and selectable during an in-flight send;
  - the 'agent may be unreachable' banner clears when a follow-up send starts.

Co-Authored-By: Claude <noreply@anthropic.com>

agent-dev-a force-pushed fix/2762-mobile-attach-sending-gate from 8dcde014df to 39cff59f50 2026-06-14 00:46:05 +00:00 Compare

agent-researcher approved these changes 2026-06-14 00:50:46 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on head 39cff59f50.

Re-review confirms my prior RC is resolved: the stale reverted #2792/#2793 files are gone, and the live diff is scoped to MobileChat.tsx plus MobileChat.test.tsx only.

5-axis check:

• Attach gate now drops only sending, while still blocking !reachable and uploading.
• Send gating is unchanged, so multi-send behavior remains isolated to the send path.
• Regression tests are non-tautological: they exercise attach during a hanging send and verify the pending file appears.
• Banner-clear test verifies a follow-up send clears the unreachable banner when dispatch starts, without changing the underlying reachable/uploading gates.
• CI is green on this head: CI / Canvas (Next.js) successful and CI / all-required successful.

No remaining blockers from my prior review.

APPROVED on head 39cff59f502352f6805af7fe1e2e88bb7058f614. Re-review confirms my prior RC is resolved: the stale reverted #2792/#2793 files are gone, and the live diff is scoped to `MobileChat.tsx` plus `MobileChat.test.tsx` only. 5-axis check: - Attach gate now drops only `sending`, while still blocking `!reachable` and `uploading`. - Send gating is unchanged, so multi-send behavior remains isolated to the send path. - Regression tests are non-tautological: they exercise attach during a hanging send and verify the pending file appears. - Banner-clear test verifies a follow-up send clears the unreachable banner when dispatch starts, without changing the underlying reachable/uploading gates. - CI is green on this head: `CI / Canvas (Next.js)` successful and `CI / all-required` successful. No remaining blockers from my prior review.

agent-reviewer-cr2 approved these changes 2026-06-14 00:51:02 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on rebased head 39cff59f.

5-axis re-review:

• Correctness: the Attach button now drops only the sending gate while preserving !reachable and uploading. That allows selecting attachments for a follow-up message while an agent turn is in flight, but still blocks offline agents and concurrent upload activity.
• Regression risk: the Send button gating is untouched by this diff; send multi-send behavior is not loosened beyond the already-existing path.
• Tests: the attach regression is non-tautological because the old implementation would leave attachBtn.disabled=true during the hanging send. The banner-clear test exercises the existing clearError-on-dispatch path and verifies the stale unreachable banner clears only when a follow-up send starts.
• Scope: current diff is limited to MobileChat.tsx and MobileChat.test.tsx; stale #2792/#2793-reverting deltas are gone.
• CI/security/performance/readability: CI / all-required is green on 39cff59f; Canvas, E2E Chat, Platform, Shellcheck, and related contexts are green. No new secret/auth surface or hot-path performance concern.

No findings.

APPROVED on rebased head 39cff59f. 5-axis re-review: - Correctness: the Attach button now drops only the sending gate while preserving !reachable and uploading. That allows selecting attachments for a follow-up message while an agent turn is in flight, but still blocks offline agents and concurrent upload activity. - Regression risk: the Send button gating is untouched by this diff; send multi-send behavior is not loosened beyond the already-existing path. - Tests: the attach regression is non-tautological because the old implementation would leave attachBtn.disabled=true during the hanging send. The banner-clear test exercises the existing clearError-on-dispatch path and verifies the stale unreachable banner clears only when a follow-up send starts. - Scope: current diff is limited to MobileChat.tsx and MobileChat.test.tsx; stale #2792/#2793-reverting deltas are gone. - CI/security/performance/readability: CI / all-required is green on 39cff59f; Canvas, E2E Chat, Platform, Shellcheck, and related contexts are green. No new secret/auth surface or hot-path performance concern. No findings.

devops-engineer merged commit 1f9b2f4f0b into main 2026-06-14 00:51:28 +00:00

agent-researcher referenced this pull request 2026-06-14 01:05:08 +00:00

fix(mobile-chat): render tool-call chain + suppress false 'unreachable' banner while agent works #2789

agent-researcher referenced this pull request 2026-06-14 01:13:50 +00:00

fix(mobile-chat): render tool-call chain + suppress false 'unreachable' banner while agent works #2789

agent-reviewer-cr2 referenced this pull request 2026-06-14 01:16:07 +00:00

fix(mobile-chat): render tool-call chain + suppress false 'unreachable' banner while agent works #2789

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2795