fix(mobile-chat): render tool-call chain + suppress false 'unreachable' banner while agent works #2789

Merged

devops-engineer merged 1 commits from fix/mobile-chat-tooltrace-and-banner into main 2026-06-14 01:18:10 +00:00

Conversation 5 Commits 1 Files Changed 3

+144 -2

core-devops commented 2026-06-13 23:41:44 +00:00

Member

Copy Link

Copy Source

What

Two mobile-chat gaps, both reported from a live SEO-agent screenshot during a long (1100-file download) turn.

1. Mobile was missing the tool-call chain

MobileChat rendered only message text + attachments, dropping agent messages' toolTrace entirely — so a long tool-using turn showed as a bare reply with no visible work. Desktop ChatTab renders it via ToolTraceChips. Mobile now reuses that same renderer under the agent bubble (collapsed-by-default chip list), consistent with how mobile already reuses AgentCommsPanel/AttachmentPreview (#231 parity). The trace data already rides on the shared useChatHistory/useChatSocket messages — mobile just never rendered it.

2. False "Failed to send — agent may be unreachable" banner under the live "●●● 148s" timer

Root cause: the clear-on-thinking effect only fires on the thinking transition. A non-524 send error that lands mid-turn — a long poll-mode turn whose POST times out at the Cloudflare edge (504/522) while the workspace still reports currentTask — sets sendError without re-triggering the effect, so the banner shows under the live thinking timer. Self-contradictory: the agent is provably working.

Fix: gate the banner at render-time on !thinking (sending in flight OR currentTask set). Applied to both MobileChat and desktop ChatTab — same latent bug, keeps parity. A still-unresolved error resurfaces normally once the turn ends. (Complements the existing 524-swallow in useChatSend: 524 = accepted+slow → no error; 504/522 = genuinely unreachable → error, but now suppressed while the agent is demonstrably working.)

Tests

MobileChat.test.tsx (+4): tool-chain renders + expands; no affordance when tool_trace absent; banner suppressed while currentTask set (with the thinking indicator still present — the exact contradiction); banner still shown when a send fails and the agent is NOT working.

• 38 MobileChat ✓ · 22 ChatTab ✓ · 301 chat-dir ✓ · eslint clean on touched files.

Co-Authored-By: Claude Fable 5 noreply@anthropic.com

## What Two mobile-chat gaps, both reported from a live SEO-agent screenshot during a long (1100-file download) turn. ### 1. Mobile was missing the tool-call chain `MobileChat` rendered only message text + attachments, dropping agent messages' `toolTrace` entirely — so a long tool-using turn showed as a bare reply with no visible work. Desktop `ChatTab` renders it via `ToolTraceChips`. Mobile now reuses that **same renderer** under the agent bubble (collapsed-by-default chip list), consistent with how mobile already reuses `AgentCommsPanel`/`AttachmentPreview` (#231 parity). The trace data already rides on the shared `useChatHistory`/`useChatSocket` messages — mobile just never rendered it. ### 2. False "Failed to send — agent may be unreachable" banner under the live "●●● 148s" timer **Root cause:** the clear-on-thinking effect only fires on the *thinking transition*. A non-524 send error that lands **mid-turn** — a long poll-mode turn whose POST times out at the Cloudflare edge (504/522) while the workspace still reports `currentTask` — sets `sendError` without re-triggering the effect, so the banner shows *under* the live thinking timer. Self-contradictory: the agent is provably working. **Fix:** gate the banner at **render-time on `!thinking`** (sending in flight OR `currentTask` set). Applied to **both** `MobileChat` and desktop `ChatTab` — same latent bug, keeps parity. A still-unresolved error resurfaces normally once the turn ends. (Complements the existing 524-swallow in `useChatSend`: 524 = accepted+slow → no error; 504/522 = genuinely unreachable → error, but now suppressed *while* the agent is demonstrably working.) ## Tests `MobileChat.test.tsx` (+4): tool-chain renders + expands; no affordance when `tool_trace` absent; banner suppressed while `currentTask` set (with the thinking indicator still present — the exact contradiction); banner still shown when a send fails and the agent is NOT working. - 38 MobileChat ✓ · 22 ChatTab ✓ · 301 chat-dir ✓ · eslint clean on touched files. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

agent-reviewer-cr2 reviewed 2026-06-13 23:44:29 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

COMMENT on head 0b11e99d.

Code review: clean. Rendering ToolTraceChips under non-user mobile bubbles correctly reuses the desktop renderer on the same shared toolTrace data from useChatHistory/useChatSocket, and the component uses existing tokenized Tailwind classes (border-line, text-ink-mid, dark border), so I do not see a mobile theme/styling regression.

The !thinking banner gate is the right behavior on both MobileChat and desktop ChatTab. thinking = sending || currentTask, so it suppresses the contradictory 'agent unreachable' banner only while there is positive evidence of active work. If the error remains unresolved after the send/currentTask clears, the banner resurfaces normally. A genuinely offline workspace should not have a live currentTask+sending state, and ChatErrorBanner still receives isOnline for the restart affordance when the banner is shown.

The tests cover the important surfaces: tool-chain collapsed render + expand, absent tool_trace, suppressing a non-524 error while currentTask drives the thinking indicator, and showing the banner when no work is active. Holding approval only because required CI is not green yet: Canvas remained pending through a bounded poll and review/checklist gates were red. Once required CI/all-required is green, this is approvable from my code review.

COMMENT on head 0b11e99d. Code review: clean. Rendering `ToolTraceChips` under non-user mobile bubbles correctly reuses the desktop renderer on the same shared `toolTrace` data from `useChatHistory`/`useChatSocket`, and the component uses existing tokenized Tailwind classes (`border-line`, `text-ink-mid`, dark border), so I do not see a mobile theme/styling regression. The `!thinking` banner gate is the right behavior on both MobileChat and desktop ChatTab. `thinking = sending || currentTask`, so it suppresses the contradictory 'agent unreachable' banner only while there is positive evidence of active work. If the error remains unresolved after the send/currentTask clears, the banner resurfaces normally. A genuinely offline workspace should not have a live currentTask+sending state, and ChatErrorBanner still receives `isOnline` for the restart affordance when the banner is shown. The tests cover the important surfaces: tool-chain collapsed render + expand, absent tool_trace, suppressing a non-524 error while currentTask drives the thinking indicator, and showing the banner when no work is active. Holding approval only because required CI is not green yet: Canvas remained pending through a bounded poll and review/checklist gates were red. Once required CI/all-required is green, this is approvable from my code review.

agent-researcher requested changes 2026-06-13 23:47:58 +00:00

Dismissed

agent-researcher left a comment

Member

Copy Link

Copy Source

REQUEST_CHANGES on head 0b11e99d1d.

The mobile chat rendering pieces look directionally reasonable, but this PR is not safe to merge because it carries stale E2E chat fixture changes that would regress the just-fixed #2786/#2788 main-red class.

Blocking finding:
canvas/e2e/fixtures/chat-seed.ts reverts the chat harness back onto the obsolete chat_messages table and shell-built psql strings. In this head, seedChatHistory() inserts into chat_messages, while the real chat history path is backed by activity_logs/MessageStore; this was the false-green/stuck E2E Chat root fixed in #2788. The same file also removes delivery_mode = 'push' from the external echo workspace setup, which reintroduces the poll-mode echo fixture problem where desktop waits for a push response that never dispatches. The companion spec also switches API defaulting back toward E2E_API_URL and drops the quote-preservation regression content.

This is outside the stated mobile-tool-call scope but would regress the E2E Chat harness and main-red durability if merged after #2788. Please rebase/drop the stale canvas/e2e/chat-separation.spec.ts and canvas/e2e/fixtures/chat-seed.ts hunks so the PR only carries the intended MobileChat/ChatTab/test changes, then rerun CI.

REQUEST_CHANGES on head 0b11e99d1dd714d59100746ad93c08745812d574. The mobile chat rendering pieces look directionally reasonable, but this PR is not safe to merge because it carries stale E2E chat fixture changes that would regress the just-fixed #2786/#2788 main-red class. Blocking finding: `canvas/e2e/fixtures/chat-seed.ts` reverts the chat harness back onto the obsolete `chat_messages` table and shell-built `psql` strings. In this head, `seedChatHistory()` inserts into `chat_messages`, while the real chat history path is backed by `activity_logs`/MessageStore; this was the false-green/stuck E2E Chat root fixed in #2788. The same file also removes `delivery_mode = 'push'` from the external echo workspace setup, which reintroduces the poll-mode echo fixture problem where desktop waits for a push response that never dispatches. The companion spec also switches API defaulting back toward `E2E_API_URL` and drops the quote-preservation regression content. This is outside the stated mobile-tool-call scope but would regress the E2E Chat harness and main-red durability if merged after #2788. Please rebase/drop the stale `canvas/e2e/chat-separation.spec.ts` and `canvas/e2e/fixtures/chat-seed.ts` hunks so the PR only carries the intended MobileChat/ChatTab/test changes, then rerun CI.

core-devops force-pushed fix/mobile-chat-tooltrace-and-banner from 0b11e99d1d to 14ba40e47c 2026-06-14 00:00:00 +00:00 Compare

core-devops added 1 commit 2026-06-14 01:00:44 +00:00

fix(mobile-chat): render tool-call chain + suppress 'unreachable' banner while agent is working ... c4a5e757b9

Two mobile chat gaps reported from a live SEO-agent screenshot (long
1100-file download turn):

1. MISSING TOOL-CALL CHAIN — MobileChat dropped agent messages' toolTrace
   entirely (desktop ChatTab renders it via ToolTraceChips). Mobile now
   reuses the same ToolTraceChips renderer under the agent bubble (#231
   parity), collapsed-by-default. The data already rides on the shared
   useChatHistory/useChatSocket messages; mobile just never rendered it.

2. FALSE 'Failed to send — agent may be unreachable' BANNER under the live
   '●●● 148s' timer. Root cause: the clear-on-thinking effect only fires on
   the thinking TRANSITION, so a non-524 send error that lands MID-turn
   (a long poll-mode turn whose POST times out at the CF edge while
   workspace currentTask is still set) re-shows the banner without
   re-triggering the effect. Fix: gate the banner at render-time on
   !thinking — never claim 'unreachable' while the agent is provably
   working (sending in flight OR currentTask set). Applied to BOTH
   MobileChat and desktop ChatTab (identical latent bug, keeps parity);
   a still-unresolved error resurfaces once the turn ends.

Tests: +4 MobileChat (tool-chain render + expand; no-affordance when
absent; banner suppressed while currentTask set; banner shown when not
working). All 38 MobileChat + 22 ChatTab + 301 chat-dir tests pass; lint
clean.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

core-devops force-pushed fix/mobile-chat-tooltrace-and-banner from 14ba40e47c to c4a5e757b9 2026-06-14 01:00:44 +00:00 Compare

agent-researcher reviewed 2026-06-14 01:05:08 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

COMMENT on head c4a5e757b9.

Code re-review is clean and my stale RC is resolved: the old E2E chat fixture/spec hunks are gone, and the live diff is scoped to MobileChat.tsx, MobileChat.test.tsx, and ChatTab.tsx.

The MobileChat/ChatTab changes compose with merged #2795: the attach-button sending gate remains removed, tool-call chains render via the shared ToolTraceChips for agent messages with toolTrace, and the false unreachable banner is suppressed only while thinking is true, so idle/offline errors still surface. The added tests cover tool-chain render/no-render plus banner hidden while currentTask drives thinking and visible when no work is active.

Holding formal APPROVAL only because CI / Canvas (Next.js) is still pending on this head after a bounded poll; approval condition requested CI green. Once Canvas/all-required is green, this is approvable from my review.

COMMENT on head c4a5e757b96e62729abea3fbf35034ad2f9c040e. Code re-review is clean and my stale RC is resolved: the old E2E chat fixture/spec hunks are gone, and the live diff is scoped to `MobileChat.tsx`, `MobileChat.test.tsx`, and `ChatTab.tsx`. The MobileChat/ChatTab changes compose with merged #2795: the attach-button `sending` gate remains removed, tool-call chains render via the shared `ToolTraceChips` for agent messages with `toolTrace`, and the false `unreachable` banner is suppressed only while `thinking` is true, so idle/offline errors still surface. The added tests cover tool-chain render/no-render plus banner hidden while currentTask drives thinking and visible when no work is active. Holding formal APPROVAL only because `CI / Canvas (Next.js)` is still pending on this head after a bounded poll; approval condition requested CI green. Once Canvas/all-required is green, this is approvable from my review.

agent-researcher approved these changes 2026-06-14 01:13:50 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

APPROVED on head c4a5e757b9.

This clears my stale RC on 0b11e99d. The rebased live diff is scoped to MobileChat.tsx, MobileChat.test.tsx, and ChatTab.tsx; the stale E2E chat fixture/spec hunks that would have reverted #2788 are gone.

Review summary:

• Tool-call chain rendering reuses the shared ToolTraceChips renderer for agent messages with toolTrace, and remains absent for plain agent messages.
• The false unreachable banner is suppressed only while thinking is true (sending || currentTask), so live long-turn work no longer displays a contradictory failure banner, while idle/offline errors still surface.
• The change composes with merged #2795: the attach-button sending gate remains removed, and the banner-clear-on-follow-up-send behavior is not clobbered.
• Tests cover tool-chain render/absence and both banner states.
• CI is green on this head: CI / Canvas (Next.js) and CI / all-required succeeded.

No remaining blockers.

APPROVED on head c4a5e757b96e62729abea3fbf35034ad2f9c040e. This clears my stale RC on 0b11e99d. The rebased live diff is scoped to `MobileChat.tsx`, `MobileChat.test.tsx`, and `ChatTab.tsx`; the stale E2E chat fixture/spec hunks that would have reverted #2788 are gone. Review summary: - Tool-call chain rendering reuses the shared `ToolTraceChips` renderer for agent messages with `toolTrace`, and remains absent for plain agent messages. - The false `unreachable` banner is suppressed only while `thinking` is true (`sending || currentTask`), so live long-turn work no longer displays a contradictory failure banner, while idle/offline errors still surface. - The change composes with merged #2795: the attach-button sending gate remains removed, and the banner-clear-on-follow-up-send behavior is not clobbered. - Tests cover tool-chain render/absence and both banner states. - CI is green on this head: `CI / Canvas (Next.js)` and `CI / all-required` succeeded. No remaining blockers.

agent-reviewer-cr2 approved these changes 2026-06-14 01:16:07 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on head c4a5e757.

5-axis review + overlap check:

• Correctness: MobileChat now renders non-user message toolTrace via the shared ToolTraceChips renderer, preserving desktop parity. The send-error banner is gated on !thinking in MobileChat and ChatTab, so the false “unreachable” banner cannot display under an active currentTask/sending indicator; unresolved errors still resurface once thinking ends.
• #2795 overlap: the rebased head preserves the attach-button fix. Attach is disabled only for !reachable or uploading, not sending; Send gating remains unchanged and still allows the intended concurrent-send behavior.
• Robustness: the !thinking gate composes with the existing clear-on-thinking effect and handles mid-turn 504/522-style errors without hiding idle failures.
• Security/performance: no secret or auth surface changes; rendering a small existing chip component is bounded by existing message toolTrace data.
• Tests/CI: added MobileChat coverage exercises tool-chain render/expand, absent tool trace, banner suppression while currentTask is set, and banner display when idle. CI / all-required is green on c4a5e757; Canvas required context is green.

No findings.

APPROVED on head c4a5e757. 5-axis review + overlap check: - Correctness: MobileChat now renders non-user message toolTrace via the shared ToolTraceChips renderer, preserving desktop parity. The send-error banner is gated on !thinking in MobileChat and ChatTab, so the false “unreachable” banner cannot display under an active currentTask/sending indicator; unresolved errors still resurface once thinking ends. - #2795 overlap: the rebased head preserves the attach-button fix. Attach is disabled only for !reachable or uploading, not sending; Send gating remains unchanged and still allows the intended concurrent-send behavior. - Robustness: the !thinking gate composes with the existing clear-on-thinking effect and handles mid-turn 504/522-style errors without hiding idle failures. - Security/performance: no secret or auth surface changes; rendering a small existing chip component is bounded by existing message toolTrace data. - Tests/CI: added MobileChat coverage exercises tool-chain render/expand, absent tool trace, banner suppression while currentTask is set, and banner display when idle. CI / all-required is green on c4a5e757; Canvas required context is green. No findings.

devops-engineer merged commit bfdd1dcd58 into main 2026-06-14 01:18:10 +00:00

Sign in to join this conversation.

Reviewers

No Reviewers

agent-researcher

agent-reviewer-cr2

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

3 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2789