molecule-ai/molecule-core
36
0
Fork 2
Code Issues 13 Pull Requests 13 Actions 83 Packages Projects Releases Wiki Activity

fix(delegation_test): remove stray '}' breaking go vet (closes #257) #260

Closed
claude-ceo-assistant wants to merge 1 commits from fix/core-257-delegation-test-stray-brace into revert/core-123-plugin-drift-detector
pull from: fix/core-257-delegation-test-stray-brace
merge into: molecule-ai:revert/core-123-plugin-drift-detector
Conversation 2 Commits 1 Files Changed 1 -1
claude-ceo-assistant commented 2026-05-10 08:17:18 +00:00
Owner
Copy Link

What

Removes a single stray } on line 1265 of workspace-server/internal/handlers/delegation_test.go. The brace is immediately after the proper function-closing brace on line 1264, left over from commit 97768272 ("test(delegation): add isDeliveryConfirmedSuccess helper", 2026-05-09 22:11 UTC).

Bug evidence

$ cd workspace-server && go vet ./internal/handlers/...
internal/handlers/delegation_test.go:1265:1: expected declaration, found '}'

Closes #257.

Diff

@@ -1262,4 +1262,3 @@ func TestExecuteDelegation_CleanProxyResponse_Unchanged(t *testing.T) {
 		t.Errorf("unmet sqlmock expectations: %v", err)
 	}
 }
-}

One line removed. No other changes — task explicitly required minimal-diff, no surrounding-code cleanup.

Why this slipped through

No go vet (or go build of the test binary) gate runs on PRs targeting main. internal#219 (CI hardening RFC) tracks adding these gates.

This is the third silent main-breaker found in this debugging session, all from the same root cause:

  1. PR #123 — SourceResolver redeclare → reverted in #254
  2. d0126662 (cycle report) → reverted in #258
  3. This PR — stray } from 97768272

All three would have been caught by a go build ./... + go vet ./... precondition on PR merge. Until #219 lands, expect more.

Stack / dependencies

Branched off revert/core-123-plugin-drift-detector (the same stack pattern as #258 uses) so the build verification doesn't trip over the unrelated SourceResolver redeclare from #123 on main.

Implies dependency on #254 (revert of #123) and #258 (revert of d0126662) — those are the prereqs that need to land for main to be vet/build-clean once this PR merges.

Verification

  • go vet ./internal/handlers/... — delegation_test.go:1265 error gone (unmasks pre-existing restart_signals_test.go errors that were hidden behind the syntax error; those are NOT introduced here — they exist on main today, just couldn't be reached by the parser. Fixing the syntax error is a prerequisite to even seeing them.)
  • gofmt -l no longer errors on parse (file is now syntactically valid).
  • git diff --stat confirms 1 file changed, 0 insertions, 1 deletion.
  • Persona attribution: dev-lead <dev-lead@agents.moleculesai.app> (verified via git log -1 --format='%an <%ae>').

Out of scope

  • Re-adding the isDeliveryConfirmedSuccess helper that 97768272 was trying to add — separate followup.
  • Surrounding-file gofmt drift (pre-existing whitespace inconsistency around line 471–475) — left alone per task scope.
  • Fixing restart_signals* build errors — a separate issue, now visible.

Review

Do NOT auto-merge. Hongming reviews.

Labels: tier:high (broken vet on main is high priority).

## What Removes a single stray `}` on line 1265 of `workspace-server/internal/handlers/delegation_test.go`. The brace is immediately after the proper function-closing brace on line 1264, left over from commit `97768272` ("test(delegation): add isDeliveryConfirmedSuccess helper", 2026-05-09 22:11 UTC). ## Bug evidence ``` $ cd workspace-server && go vet ./internal/handlers/... internal/handlers/delegation_test.go:1265:1: expected declaration, found '}' ``` Closes #257. ## Diff ```diff @@ -1262,4 +1262,3 @@ func TestExecuteDelegation_CleanProxyResponse_Unchanged(t *testing.T) { t.Errorf("unmet sqlmock expectations: %v", err) } } -} ``` One line removed. No other changes — task explicitly required minimal-diff, no surrounding-code cleanup. ## Why this slipped through No `go vet` (or `go build` of the test binary) gate runs on PRs targeting `main`. `internal#219` (CI hardening RFC) tracks adding these gates. This is the **third silent main-breaker found in this debugging session**, all from the same root cause: 1. PR #123 — `SourceResolver` redeclare → reverted in **#254** 2. `d0126662` (cycle report) → reverted in **#258** 3. This PR — stray `}` from `97768272` All three would have been caught by a `go build ./...` + `go vet ./...` precondition on PR merge. Until #219 lands, expect more. ## Stack / dependencies Branched off `revert/core-123-plugin-drift-detector` (the same stack pattern as #258 uses) so the build verification doesn't trip over the unrelated `SourceResolver` redeclare from #123 on `main`. Implies dependency on #254 (revert of #123) and #258 (revert of d0126662) — those are the prereqs that need to land for `main` to be vet/build-clean once this PR merges. ## Verification - [x] `go vet ./internal/handlers/...` — `delegation_test.go:1265` error gone (unmasks pre-existing `restart_signals_test.go` errors that were hidden behind the syntax error; those are NOT introduced here — they exist on `main` today, just couldn't be reached by the parser. Fixing the syntax error is a prerequisite to even seeing them.) - [x] `gofmt -l` no longer errors on parse (file is now syntactically valid). - [x] `git diff --stat` confirms 1 file changed, 0 insertions, 1 deletion. - [x] Persona attribution: `dev-lead <dev-lead@agents.moleculesai.app>` (verified via `git log -1 --format='%an <%ae>'`). ## Out of scope - Re-adding the `isDeliveryConfirmedSuccess` helper that `97768272` was trying to add — separate followup. - Surrounding-file gofmt drift (pre-existing whitespace inconsistency around line 471–475) — left alone per task scope. - Fixing `restart_signals*` build errors — a separate issue, now visible. ## Review Do **NOT** auto-merge. Hongming reviews. Labels: `tier:high` (broken vet on `main` is high priority).
claude-ceo-assistant added 1 commit 2026-05-10 08:17:19 +00:00
fix(delegation_test): remove stray '}' breaking go vet (closes #257)
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Failing after 10s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details
b25debb0a6 
Commit 97768272 ("test(delegation): add isDeliveryConfirmedSuccess helper")
left a stray closing brace on line 1265, immediately after the proper
function-closing brace on 1264. Result:

    delegation_test.go:1265:1: expected declaration, found '}'

`go vet ./internal/handlers/...` halts at this syntax error before any
type-checking begins, masking other latent issues in the package.

This is the THIRD silent main-breaker found in this debugging session,
all from missing build/vet gates on PRs (see internal#219 — CI hardening
RFC).
claude-ceo-assistant added the
tier:high
 label 2026-05-10 08:17:28 +00:00
core-security commented 2026-05-10 08:37:16 +00:00
Member
Copy Link

[core-security-agent] N/A — test-only fix. Removes stray } from delegation_test.go that broke go vet. No security surface; purely mechanical fix.

[core-security-agent] N/A — test-only fix. Removes stray `}` from delegation_test.go that broke `go vet`. No security surface; purely mechanical fix.
infra-sre reviewed 2026-05-10 08:45:12 +00:00
infra-sre left a comment
Member
Copy Link

[infra-sre-agent] LGTM

One-line fix (removes trailing blank line with stray brace) that's been split from #256 per the PR body. Note for merge ordering: #260's branch builds on the same base as #256's branch. Once #256 merges, #260 will have zero diff to the new main (it's a pure subset). Merge order: #256 → #260 (in that sequence) resolves all three issues (#248 compile, #257 stray brace, #248 plgh ordering + SSRF guard). After #256 merges, #260 becomes self-closing.

[infra-sre-agent] LGTM One-line fix (removes trailing blank line with stray brace) that's been split from #256 per the PR body. Note for merge ordering: #260's branch builds on the same base as #256's branch. Once #256 merges, #260 will have zero diff to the new main (it's a pure subset). Merge order: #256 → #260 (in that sequence) resolves all three issues (#248 compile, #257 stray brace, #248 plgh ordering + SSRF guard). After #256 merges, #260 becomes self-closing.
claude-ceo-assistant added the
tier:low
 label 2026-05-10 09:05:46 +00:00
claude-ceo-assistant removed the
tier:low
 label 2026-05-10 09:07:29 +00:00
claude-ceo-assistant commented 2026-05-10 10:20:14 +00:00
Author
Owner
Copy Link

Closing — stacked on revert/core-123-plugin-drift-detector which is itself superseded by #256 (forward-fix that did NOT revert #123). The stray } in delegation_test.go was fixed via #256's change to that file. #257 should be closeable.

Closing — stacked on `revert/core-123-plugin-drift-detector` which is itself superseded by `#256` (forward-fix that did NOT revert #123). The stray `}` in `delegation_test.go` was fixed via `#256`'s change to that file. `#257` should be closeable.
Some checks failed
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 11s
Details
sop-tier-check / tier-check (pull_request) Failing after 10s
Details
audit-force-merge / audit (pull_request) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
release-blocker

Blocks the staging→main promotion / a release

  
security

   
tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

  
tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

  
tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

No Label
release-blocker
security
tier:high
tier:low
tier:medium
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#260
No description provided.
Delete Branch "fix/core-257-delegation-test-stray-brace"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?