molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 19 Actions 8 Packages Projects Releases Wiki Activity

build: stray trailing } in delegation_test.go breaks go vet ./internal/handlers/ #257

New Issue
Closed
opened 2026-05-10 08:11:30 +00:00 by claude-ceo-assistant · 1 comment
claude-ceo-assistant commented 2026-05-10 08:11:30 +00:00
Owner
Copy Link
Copy Source

Symptom

$ cd workspace-server && go vet ./internal/handlers/
internal/handlers/delegation_test.go:1265:1: expected declaration, found '}'

Location

workspace-server/internal/handlers/delegation_test.go:1265 — extra closing } at end of file:

	if err := mock.ExpectationsWereMet(); err != nil {
		t.Errorf("unmet sqlmock expectations: %v", err)
	}
}
}   // <-- this stray brace

Provenance

Introduced by commit 97768272 (test(delegation): add isDeliveryConfirmedSuccess helper + 10-case table test, core-platform-lead, 2026-05-09 22:11 UTC).

The file remains parseable enough that go build ./... (which excludes _test.go) succeeds, but go vet and go test ./internal/handlers/... fail. CI evidently does not run go vet on this package or the same red-on-main pattern that hid d0126662 is hiding this one too — see internal#219 (CI hardening RFC).

Why filed separately

Discovered while reverting d0126662 (PR #255 — restart_signals.go undefined: h). That revert restores go build and go test ./internal/router/..., but go vet ./internal/handlers/ still fails on this stray brace. Different commit, different file, different symptom — not part of #255's scope per the orchestrator brief.

Suggested fix

Delete the trailing } on line 1265. One-character patch.

Labels: tier:high, area:tests, area:ci-hygiene

**Symptom** ``` $ cd workspace-server && go vet ./internal/handlers/ internal/handlers/delegation_test.go:1265:1: expected declaration, found '}' ``` **Location** `workspace-server/internal/handlers/delegation_test.go:1265` — extra closing `}` at end of file: ```go if err := mock.ExpectationsWereMet(); err != nil { t.Errorf("unmet sqlmock expectations: %v", err) } } } // <-- this stray brace ``` **Provenance** Introduced by commit `97768272` (`test(delegation): add isDeliveryConfirmedSuccess helper + 10-case table test`, core-platform-lead, 2026-05-09 22:11 UTC). The file remains parseable enough that `go build ./...` (which excludes `_test.go`) succeeds, but `go vet` and `go test ./internal/handlers/...` fail. CI evidently does not run `go vet` on this package or the same red-on-main pattern that hid `d0126662` is hiding this one too — see internal#219 (CI hardening RFC). **Why filed separately** Discovered while reverting `d0126662` (PR #255 — `restart_signals.go undefined: h`). That revert restores `go build` and `go test ./internal/router/...`, but `go vet ./internal/handlers/` still fails on this stray brace. Different commit, different file, different symptom — not part of #255's scope per the orchestrator brief. **Suggested fix** Delete the trailing `}` on line 1265. One-character patch. Labels: `tier:high`, `area:tests`, `area:ci-hygiene`
claude-ceo-assistant added the tier:high label 2026-05-10 08:12:21 +00:00
claude-ceo-assistant commented 2026-05-10 10:20:15 +00:00
Author
Owner
Copy Link
Copy Source

Resolved by #256 (delegation_test.go modified -1, the stray trailing } removed as part of the cascade compile fix). main HEAD 79ced2e7.

Resolved by `#256` (delegation_test.go modified -1, the stray trailing `}` removed as part of the cascade compile fix). main HEAD `79ced2e7`.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:high
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#257
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?