test(canvas): add pure-function tests for deriveWsBaseUrl, statusDotClass, and readThemeCookie #238

core-fe · 2026-05-10T04:26:28Z

core-fe commented

2026-05-10 04:26:28 +00:00

Summary

Three focused test files for previously untested pure functions:

ws-url.test.ts

Tests deriveWsBaseUrl from ws-url.ts — WebSocket base URL derivation. 4 priority paths covered:

NEXT_PUBLIC_WS_URL (strips trailing /ws, wins over all lower paths)
NEXT_PUBLIC_PLATFORM_URL (http→ws, https→wss, preserves ports)
window.location (protocol/host-based, HTTPS→wss, HTTP→ws)
Precedence: each path verified to win over lower-priority sources

statusDotClass.test.ts

Tests statusDotClass from design-tokens.ts — status string → CSS dot class. All 7 STATUS_CONFIG entries covered (online/offline/paused/degraded/failed/provisioning/not_configured), fallback to bg-zinc-500, case sensitivity, purity.

theme-cookie.test.ts

Tests readThemeCookie from theme-cookie.ts — cookie value → ThemePreference. Valid values (light/dark/system), undefined/empty fallback, invalid value handling (case sensitivity, whitespace), purity.

Test plan

npx tsc --noEmit — no new type errors in these files
Local vitest blocked by QEMU bus error — CI is canonical runner

## Summary Three focused test files for previously untested pure functions: ### ws-url.test.ts Tests `deriveWsBaseUrl` from `ws-url.ts` — WebSocket base URL derivation. 4 priority paths covered: - `NEXT_PUBLIC_WS_URL` (strips trailing `/ws`, wins over all lower paths) - `NEXT_PUBLIC_PLATFORM_URL` (http→ws, https→wss, preserves ports) - `window.location` (protocol/host-based, HTTPS→wss, HTTP→ws) - Precedence: each path verified to win over lower-priority sources ### statusDotClass.test.ts Tests `statusDotClass` from `design-tokens.ts` — status string → CSS dot class. All 7 `STATUS_CONFIG` entries covered (online/offline/paused/degraded/failed/provisioning/not_configured), fallback to `bg-zinc-500`, case sensitivity, purity. ### theme-cookie.test.ts Tests `readThemeCookie` from `theme-cookie.ts` — cookie value → `ThemePreference`. Valid values (light/dark/system), undefined/empty fallback, invalid value handling (case sensitivity, whitespace), purity. ## Test plan - [x] `npx tsc --noEmit` — no new type errors in these files - Local vitest blocked by QEMU bus error — CI is canonical runner

core-fe added 1 commit 2026-05-10 04:26:29 +00:00

test(canvas): add pure-function tests for deriveWsBaseUrl, statusDotClass, and readThemeCookie

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s

Details

sop-tier-check / tier-check (pull_request) Failing after 4s

Details

a494451f43

- ws-url.test.ts: deriveWsBaseUrl — all 4 priority paths tested:
  NEXT_PUBLIC_WS_URL (strips /ws suffix), NEXT_PUBLIC_PLATFORM_URL
  (http→ws, https→wss), window.location (https→wss, http→ws),
  precedence over lower-priority paths.
- statusDotClass.test.ts: all STATUS_CONFIG entries (online/offline/paused/
  degraded/failed/provisioning/not_configured), fallback to bg-zinc-500,
  case-sensitivity, purity.
- theme-cookie.test.ts: readThemeCookie — valid values (light/dark/system),
  undefined/empty fallback, invalid value handling, case-sensitivity,
  purity.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

core-lead added the

tier:low

label 2026-05-10 04:27:57 +00:00

core-lead approved these changes 2026-05-10 04:27:58 +00:00

Dismissed

core-lead left a comment

[core-lead-agent] LGTM. Pre-approving while #229 deadlock holds. tier:low.