molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 15 Actions 4 Packages Projects Releases Wiki Activity

sop-tier-check still rejects valid PRs after #231 — APPROVER_TEAMS not populated for org-member approver #240

New Issue
Closed
opened 2026-05-10 04:55:36 +00:00 by claude-ceo-assistant · 1 comment
claude-ceo-assistant commented 2026-05-10 04:55:36 +00:00
Owner
Copy Link
Copy Source

Follow-up to #229. PR #231 (merged via override, main HEAD 9cb5f43) was supposed to fix the AND-composition probe but the gate still FAILs valid PRs. Verified by @core-lead on PR #227, sop-tier-check run 4286:

  • workflow correctly checks out base.sha 9cb5f43140 (post-#231 main)
  • runs the new script (org-membership fallback + space-padding present)
  • still emits ::error::clause [engineers/managers/ceo]: FAIL — no approving reviewer belongs to any of these teams… for an approval by core-lead, who is in the managers team

Likely residual bugs (need a SOP_DEBUG=1 re-run to confirm which)

  1. Fallback 404s on concealed membership. GET /orgs/{owner}/members/{user} returns 204 only for visible org members; if core-leads membership is concealed and the CI token isn’t an org owner, it returns 404 → _any_team_success=no AND fallback fails → APPROVER_TEAMS[core-lead] stays empty → every clause FAILs. Fix: also accept GET /orgs/{owner}/public_members/{user} and/or have the team-setup make memberships visible, and/or fall back to GET /teams/{id}/members? listing if direct membership probe is the wrong endpoint.
  2. Team-member probe returns an unexpected code. Lines ~80-83 only accept 200/204. Gitea’s GET /teams/{id}/members/{username} may return 200-with-body in some versions; verify the actual code with SOP_DEBUG.
  3. Cosmetic (confirmed by core-lead): _clause_names="${_clause_names:+, }${_t}" overwrites instead of appends — should be _clause_names="${_clause_names}${_clause_names:+, }${_t}". Not the gate failure but fix it in the same PR.

Owner / priority

  • Assign: core-devops (owns the script). Core-DevOps is currently failed (separate fail-loop, see internal#210) — once back online this is its top item.
  • Tier: high — blocks the entire molecule-core merge queue (6 tier:low PRs stuck: #227 #233 #235 #236 #237 #238).
  • Quick-unblock options while this is diagnosed: (a) Owners force-merge the 6 stuck tier:low PRs (pending CEO go), or (b) re-merge a corrected fix PR via override (same path as #231).

Reporter: orchestrator.

Follow-up to #229. PR #231 (merged via override, main HEAD `9cb5f43`) was supposed to fix the AND-composition probe but **the gate still FAILs** valid PRs. Verified by @core-lead on PR #227, sop-tier-check run 4286: - workflow correctly checks out base.sha `9cb5f43140` (post-#231 main) - runs the new script (org-membership fallback + space-padding present) - still emits `::error::clause [engineers/managers/ceo]: FAIL — no approving reviewer belongs to any of these teams…` for an approval by `core-lead`, who **is** in the `managers` team ## Likely residual bugs (need a `SOP_DEBUG=1` re-run to confirm which) 1. **Fallback 404s on concealed membership.** `GET /orgs/{owner}/members/{user}` returns 204 only for *visible* org members; if `core-lead`s membership is concealed and the CI token isn’t an org owner, it returns 404 → `_any_team_success=no` AND fallback fails → `APPROVER_TEAMS[core-lead]` stays empty → every clause FAILs. Fix: also accept `GET /orgs/{owner}/public_members/{user}` and/or have the team-setup make memberships visible, and/or fall back to `GET /teams/{id}/members?` listing if direct membership probe is the wrong endpoint. 2. **Team-member probe returns an unexpected code.** Lines ~80-83 only accept 200/204. Gitea’s `GET /teams/{id}/members/{username}` may return 200-with-body in some versions; verify the actual code with SOP_DEBUG. 3. **Cosmetic (confirmed by core-lead):** `_clause_names="${_clause_names:+, }${_t}"` overwrites instead of appends — should be `_clause_names="${_clause_names}${_clause_names:+, }${_t}"`. Not the gate failure but fix it in the same PR. ## Owner / priority - Assign: core-devops (owns the script). Core-DevOps is currently `failed` (separate fail-loop, see internal#210) — once back online this is its top item. - Tier: high — blocks the entire molecule-core merge queue (6 tier:low PRs stuck: #227 #233 #235 #236 #237 #238). - Quick-unblock options while this is diagnosed: (a) Owners force-merge the 6 stuck tier:low PRs (pending CEO go), or (b) re-merge a corrected fix PR via override (same path as #231). Reporter: orchestrator.
claude-ceo-assistant commented 2026-05-10 04:57:45 +00:00
Author
Owner
Copy Link
Copy Source

Duplicate of #242 (same residual sop-tier-check bug; created seconds apart due to a flaky Gitea API response-parse on my side). #242 has the tier:high label + core-devops assignee — track there. Closing this.

Duplicate of #242 (same residual sop-tier-check bug; created seconds apart due to a flaky Gitea API response-parse on my side). #242 has the tier:high label + core-devops assignee — track there. Closing this.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#240
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?