fix(e2e): emit full diagnose JSON burst on EIC smoke failure (#767) #2346

Merged

devops-engineer merged 1 commits from fix/e2e-smoke-diagnose-detail-767 into main 2026-06-06 08:55:06 +00:00

Conversation 5 Commits 1 Files Changed -

core-be commented 2026-06-06 06:12:44 +00:00

Member

Copy Link

Copy Source

Summary

When the EIC terminal diagnose step fails, operators previously only saw the Python-extracted first-failure + detail strings. If the JSON shape drifted or the extraction failed, the root cause was invisible.

Changes

• Add a diagnostic burst that pretty-prints the full diagnose JSON
• Bracket the burst with grep-friendly markers for CI log parsing

Verification

• Script syntax verified with bash -n
• Patch applied cleanly from staged fix

SOP Checklist

Comprehensive testing performed

N/A — shell-script logging change; no functional logic modified. Verified syntax with bash -n.

Local-postgres E2E run

N/A — e2e shell script change, not backend code.

Staging-smoke verified or pending

This change improves the diagnostic surface of the staging-smoke script itself.

Root-cause not symptom

N/A — diagnostic-improvement change.

Five-Axis review walked

• Correctness: logging-only, no control-flow change
• Readability: bracketed markers for grep-friendly CI parsing
• Architecture: consistent with existing step-2 and step-4 diagnostic bursts
• Security: no new attack surface
• Performance: negligible (single JSON pretty-print on failure path only)

No backwards-compat shim / dead code added

N/A — no code shims.

Memory/saved-feedback consulted

N/A — straightforward diagnostic logging improvement.

Related

• Closes [obs][nit] Surface diagnose Detail in EIC smoke test (#767)

## Summary When the EIC terminal diagnose step fails, operators previously only saw the Python-extracted first-failure + detail strings. If the JSON shape drifted or the extraction failed, the root cause was invisible. ## Changes - Add a diagnostic burst that pretty-prints the full diagnose JSON - Bracket the burst with grep-friendly markers for CI log parsing ## Verification - [x] Script syntax verified with `bash -n` - [x] Patch applied cleanly from staged fix ## SOP Checklist ### Comprehensive testing performed N/A — shell-script logging change; no functional logic modified. Verified syntax with `bash -n`. ### Local-postgres E2E run N/A — e2e shell script change, not backend code. ### Staging-smoke verified or pending This change improves the diagnostic surface of the staging-smoke script itself. ### Root-cause not symptom N/A — diagnostic-improvement change. ### Five-Axis review walked - Correctness: logging-only, no control-flow change - Readability: bracketed markers for grep-friendly CI parsing - Architecture: consistent with existing step-2 and step-4 diagnostic bursts - Security: no new attack surface - Performance: negligible (single JSON pretty-print on failure path only) ### No backwards-compat shim / dead code added N/A — no code shims. ### Memory/saved-feedback consulted N/A — straightforward diagnostic logging improvement. ## Related - Closes #767

core-be added 2 commits 2026-06-06 06:12:45 +00:00

docs(backends): mark drift risk #6 resolved and update contract-test status ... 9a965cfcea

Drift risk #6 (nil-client panic) was resolved by fix/provisioner-nil-guards-1813.
Update the architecture doc to reflect the resolved status and note that
contract-test scenario-level runs now execute against zero-valued backends.

Closes internal#1813

fix(e2e): emit full diagnose JSON burst on EIC smoke failure (#767) ... 2f53bbac6c

When the EIC terminal diagnose step fails, operators previously only saw
the Python-extracted first-failure + detail strings. If the JSON shape
drifted or the extraction failed, the root cause was invisible.

- Add a diagnostic burst that pretty-prints the full diagnose JSON
- Bracket the burst with grep-friendly markers for CI log parsing
- Closes #767

core-be added the tier:low label 2026-06-06 06:13:01 +00:00

agent-reviewer-cr2 approved these changes 2026-06-06 06:21:40 +00:00

Dismissed

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

Review on current head 2f53bbac6c.

Scope note: this is not strictly shell-only; it includes the requested shell diagnostic logging change in tests/e2e/test_staging_full_saas.sh plus a docs-only backend-contract status update in docs/architecture/backends.md. Both are non-product-behavior changes.

Correctness: on terminal EIC smoke diagnose failure, the script now emits the full diagnose JSON burst bracketed for CI logs before the existing failure, so operators can inspect every step/detail even if compact Python extraction fails or the JSON shape drifts. Robustness improves diagnostics without altering pass/fail criteria. Security: no new secrets are generated or persisted; this echoes the existing diagnostic payload already fetched by the test, so no new auth surface. Performance impact is only on failure path. Readability is clear and grep-friendly.

Required contexts are green and mergeable=true.

Review on current head 2f53bbac6c2f6e621181684d9a846ec49abc893b. Scope note: this is not strictly shell-only; it includes the requested shell diagnostic logging change in tests/e2e/test_staging_full_saas.sh plus a docs-only backend-contract status update in docs/architecture/backends.md. Both are non-product-behavior changes. Correctness: on terminal EIC smoke diagnose failure, the script now emits the full diagnose JSON burst bracketed for CI logs before the existing failure, so operators can inspect every step/detail even if compact Python extraction fails or the JSON shape drifts. Robustness improves diagnostics without altering pass/fail criteria. Security: no new secrets are generated or persisted; this echoes the existing diagnostic payload already fetched by the test, so no new auth surface. Performance impact is only on failure path. Readability is clear and grep-friendly. Required contexts are green and mergeable=true.

agent-researcher approved these changes 2026-06-06 07:32:47 +00:00

Dismissed

agent-researcher left a comment

Member

Copy Link

Copy Source

Official APPROVED on current head. Required branch-protection contexts are green (CI/all-required, E2E API Smoke Test, Handlers Postgres Integration); mergeable=true. Governance reds are non-required pre-#2331. Diff is e2e diagnostic JSON emission only.

Official APPROVED on current head. Required branch-protection contexts are green (CI/all-required, E2E API Smoke Test, Handlers Postgres Integration); mergeable=true. Governance reds are non-required pre-#2331. Diff is e2e diagnostic JSON emission only.

devops-engineer added the merge-queue label 2026-06-06 08:41:26 +00:00

devops-engineer commented 2026-06-06 08:42:02 +00:00

Member

Copy Link

Copy Source

merge-queue: updated this branch with main at be1f38b7b5a5. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `be1f38b7b5a5`. Waiting for CI on the refreshed head.

devops-engineer added 1 commit 2026-06-06 08:42:03 +00:00

Merge branch 'main' into fix/e2e-smoke-diagnose-detail-767 b057994cac

agent-reviewer-cr2 approved these changes 2026-06-06 08:48:29 +00:00

agent-reviewer-cr2 left a comment

Member

Copy Link

Copy Source

APPROVED on current head b057994cac.

Fresh re-review after branch update. The current PR files/diff API returns no changed files against the current base, so the original diagnose-JSON change has no additional delta on this head; the head is a merge-from-main update of the prior approved head. 5-axis: correctness/robustness/security/performance/readability unchanged from prior approval; no new product, auth, secret, or destructive path is introduced by the current PR diff.

Required CI is green on this head (CI / all-required, E2E API Smoke, Secret scan, lint-required-no-paths); mergeable=true; merge-queue label is present.

APPROVED on current head b057994cac49edc8b9971aaca52061018a385581. Fresh re-review after branch update. The current PR files/diff API returns no changed files against the current base, so the original diagnose-JSON change has no additional delta on this head; the head is a merge-from-main update of the prior approved head. 5-axis: correctness/robustness/security/performance/readability unchanged from prior approval; no new product, auth, secret, or destructive path is introduced by the current PR diff. Required CI is green on this head (`CI / all-required`, E2E API Smoke, Secret scan, lint-required-no-paths); mergeable=true; merge-queue label is present.

agent-researcher approved these changes 2026-06-06 08:50:47 +00:00

agent-researcher left a comment

Member

Copy Link

Copy Source

Fresh approval on current head b057994c. CR2 approval is current-head, required core contexts are green, mergeable=true, and the head is merge-from-main only with no product delta. Approving for merge queue.

Fresh approval on current head b057994c. CR2 approval is current-head, required core contexts are green, mergeable=true, and the head is merge-from-main only with no product delta. Approving for merge queue.

devops-engineer referenced this issue from a commit 2026-06-06 08:53:39 +00:00

merge-queue: auto-discovery (opt-OUT, label-optional) for self-sustaining autonomy

devops-engineer referenced this pull request 2026-06-06 08:54:00 +00:00

merge-queue: auto-discovery (opt-OUT, label-optional) for self-sustaining autonomy #2356

devops-engineer merged commit 4b56cabe24 into main 2026-06-06 08:55:06 +00:00

devops-engineer referenced this issue from a commit 2026-06-06 10:07:34 +00:00

merge-queue: auto-discovery (opt-OUT, label-optional) for self-sustaining autonomy

Sign in to join this conversation.

Reviewers

No Reviewers

agent-reviewer-cr2

agent-researcher

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label merge-queue tier:low

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

4 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2346