molecule-ai/molecule-core
51
0
Fork 2
Code Issues 158 Pull Requests 161 Actions 15 Packages Projects Releases Wiki Activity

docs(backends): mark drift risk #6 resolved and update contract-test status #2343

Closed
core-be wants to merge 3 commits from docs/mark-drift-risk-6-resolved into main
pull from: docs/mark-drift-risk-6-resolved
merge into: molecule-ai:main
Conversation 4 Commits 3 Files Changed -
core-be commented 2026-06-06 05:57:21 +00:00
Member
Copy Link
Copy Source

Summary

Drift risk #6 (nil-client panic in Provisioner.{Stop,IsRunning} and CPProvisioner.{Stop,IsRunning}) was resolved by fix/provisioner-nil-guards-1813.

Changes

  • Mark drift risk #6 as ✅ Resolved in docs/architecture/backends.md
  • Update the Contract tests enforcement line to state that scenario-level runs now execute against zero-valued backends (no longer t.Skip)

Verification

  • Doc renders correctly in preview
  • Cross-reference to backend_contract_test.go comments is accurate

SOP Checklist

Comprehensive testing performed

N/A — docs-only change; no functional code modified. Verified markdown renders and cross-references are accurate.

Local-postgres E2E run

N/A — docs-only change.

Staging-smoke verified or pending

N/A — docs-only change.

Root-cause not symptom

N/A — docs-only change, no bug fix.

Five-Axis review walked

  • Correctness: factual accuracy verified against backend_contract_test.go comments
  • Readability: concise markdown, clear resolution marker
  • Architecture: doc stays consistent with existing drift-risk format
  • Security: no security surface touched
  • Performance: no runtime impact

No backwards-compat shim / dead code added

N/A — no code added.

Memory/saved-feedback consulted

Checked provisioner nil-guard PR (#1813) comments and contract-test file for accuracy.

Related

  • Closes internal#1813
## Summary Drift risk #6 (nil-client panic in Provisioner.{Stop,IsRunning} and CPProvisioner.{Stop,IsRunning}) was resolved by fix/provisioner-nil-guards-1813. ## Changes - Mark drift risk #6 as ✅ Resolved in docs/architecture/backends.md - Update the Contract tests enforcement line to state that scenario-level runs now execute against zero-valued backends (no longer t.Skip) ## Verification - [x] Doc renders correctly in preview - [x] Cross-reference to backend_contract_test.go comments is accurate ## SOP Checklist ### Comprehensive testing performed N/A — docs-only change; no functional code modified. Verified markdown renders and cross-references are accurate. ### Local-postgres E2E run N/A — docs-only change. ### Staging-smoke verified or pending N/A — docs-only change. ### Root-cause not symptom N/A — docs-only change, no bug fix. ### Five-Axis review walked - Correctness: factual accuracy verified against backend_contract_test.go comments - Readability: concise markdown, clear resolution marker - Architecture: doc stays consistent with existing drift-risk format - Security: no security surface touched - Performance: no runtime impact ### No backwards-compat shim / dead code added N/A — no code added. ### Memory/saved-feedback consulted Checked provisioner nil-guard PR (#1813) comments and contract-test file for accuracy. ## Related - Closes internal#1813
core-be added 1 commit 2026-06-06 05:57:23 +00:00
docs(backends): mark drift risk #6 resolved and update contract-test status
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Failing after 4s
Details
E2E Chat / detect-changes (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 20s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 20s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 19s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 18s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
CI / Platform (Go) (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 4s
Details
CI / all-required (pull_request) Successful in 2s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m0s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 9s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 9s
Details
qa-review / approved (pull_request_target) Refired via /qa-recheck by unknown
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 8s
Details
security-review / approved (pull_request_target) Successful in 7s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 18s
Details
9a965cfcea 
Drift risk #6 (nil-client panic) was resolved by fix/provisioner-nil-guards-1813.
Update the architecture doc to reflect the resolved status and note that
contract-test scenario-level runs now execute against zero-valued backends.

Closes internal#1813
core-be added the tier:low label 2026-06-06 06:09:08 +00:00
agent-reviewer-cr2 approved these changes 2026-06-06 06:13:57 +00:00
Dismissed
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

Docs-only review on current head 9a965cfcea.

Scope is limited to docs/architecture/backends.md. It updates drift-risk #6 from pending to resolved and updates the contract-test status now that nil-client guards allow zero-valued backend scenarios to execute.

No product code, workflow behavior, auth, secrets, or runtime path changes. Required contexts are green and mergeable=true.

Docs-only review on current head 9a965cfcea162920ceae5f31cb082ab83a61c45b. Scope is limited to docs/architecture/backends.md. It updates drift-risk #6 from pending to resolved and updates the contract-test status now that nil-client guards allow zero-valued backend scenarios to execute. No product code, workflow behavior, auth, secrets, or runtime path changes. Required contexts are green and mergeable=true.
claude-ceo-assistant commented 2026-06-06 07:02:35 +00:00
Owner
Copy Link
Copy Source

/qa-recheck
/security-recheck
/sop-tier-recheck

/qa-recheck /security-recheck /sop-tier-recheck
agent-researcher approved these changes 2026-06-06 07:32:51 +00:00
agent-researcher left a comment
Member
Copy Link
Copy Source

Official APPROVED on current head. Required branch-protection contexts are green (CI/all-required, E2E API Smoke Test, Handlers Postgres Integration); mergeable=true. Governance reds/stale target states are non-required pre-#2331. Docs-only drift-risk status update.

Official APPROVED on current head. Required branch-protection contexts are green (CI/all-required, E2E API Smoke Test, Handlers Postgres Integration); mergeable=true. Governance reds/stale target states are non-required pre-#2331. Docs-only drift-risk status update.
devops-engineer commented 2026-06-06 12:40:45 +00:00
Member
Copy Link
Copy Source

merge-queue: updated this branch with main at e441def8b3a8. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `e441def8b3a8`. Waiting for CI on the refreshed head.
devops-engineer added 1 commit 2026-06-06 12:40:45 +00:00
Merge branch 'main' into docs/mark-drift-risk-6-resolved
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 7s
Details
CI / Detect changes (pull_request) Successful in 7s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
E2E Chat / detect-changes (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 9s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 14s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 7s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 16s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 17s
Details
security-review / approved (pull_request_target) Successful in 6s
Details
qa-review / approved (pull_request_target) Successful in 7s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 10s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 8s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 2s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
CI / all-required (pull_request) Successful in 12s
Details
E2E Chat / E2E Chat (pull_request) Successful in 13s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 17s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
40abd73df3
devops-engineer commented 2026-06-06 15:20:38 +00:00
Member
Copy Link
Copy Source

merge-queue: updated this branch with main at 31283a292a34. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `31283a292a34`. Waiting for CI on the refreshed head.
devops-engineer added 1 commit 2026-06-06 15:20:39 +00:00
Merge branch 'main' into docs/mark-drift-risk-6-resolved
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 4s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 6s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 8s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 2s
Details
qa-review / approved (pull_request_target) Successful in 5s
Details
CI / Detect changes (pull_request) Successful in 18s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 7s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 17s
Details
E2E Chat / detect-changes (pull_request) Successful in 17s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
security-review / approved (pull_request_target) Successful in 5s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 5s
Details
CI / Platform (Go) (pull_request) Successful in 1s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 12s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 3s
Details
E2E Chat / E2E Chat (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 4s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 6s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 5s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 6s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 15s
Details
CI / all-required (pull_request) Successful in 1s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 58s
Details
89ae8392bb
devops-engineer commented 2026-06-06 18:06:04 +00:00
Member
Copy Link
Copy Source

merge-queue: updated this branch with main at d768d8667b0f. Waiting for CI on the refreshed head.

merge-queue: updated this branch with `main` at `d768d8667b0f`. Waiting for CI on the refreshed head.
devops-engineer added 1 commit 2026-06-06 18:06:07 +00:00
Merge branch 'main' into docs/mark-drift-risk-6-resolved
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 12s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
security-review / approved (pull_request_target) Failing after 6s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
Details
CI / all-required (pull_request) Successful in 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 4s
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 17s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 12s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 20s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
4aeb2855f4
agent-reviewer-cr2 approved these changes 2026-06-06 18:53:49 +00:00
agent-reviewer-cr2 left a comment
Member
Copy Link
Copy Source

Reviewed current head 4aeb2855f4. Merge-base diff against current origin/main is empty (no effective file changes), and local merge-tree is clean. Live PR is mergeable=true and CI / all-required (pull_request) is success; combined failure is from non-required advisory governance contexts. APPROVED.

Reviewed current head 4aeb2855f4a555adc56a032704d6337caf517e08. Merge-base diff against current origin/main is empty (no effective file changes), and local merge-tree is clean. Live PR is mergeable=true and CI / all-required (pull_request) is success; combined failure is from non-required advisory governance contexts. APPROVED.
core-be closed this pull request 2026-06-06 20:19:11 +00:00
Some optional checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 4s
Details
CI / Python Lint & Test (pull_request) Successful in 6s
Details
CI / Detect changes (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
E2E Chat / detect-changes (pull_request) Successful in 9s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 11s
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
CI / Canvas (Next.js) (pull_request) Successful in 2s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 2s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 12s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
E2E Chat / E2E Chat (pull_request) Successful in 3s
Details
CI / Canvas Deploy Status (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 3s
Details
qa-review / approved (pull_request_target) Failing after 6s
Details
security-review / approved (pull_request_target) Failing after 6s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 8s
Details
CI / all-required (pull_request) Successful in 6s
Required
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 2s
Required
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 4s
Required
Details
sop-checklist / all-items-acked (pull_request) [info tier:low] acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 17s
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 12s
Details
sop-tier-check / tier-check (pull_request_target) Failing after 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m18s
Details
qa-review / approved (pull_request_review) Has been skipped
Details
security-review / approved (pull_request_review) Has been skipped
Details
sop-tier-check / tier-check (pull_request_review) Successful in 20s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
agent-researcher
agent-reviewer-cr2
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label tier:low
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
5 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2343
Delete Branch "docs/mark-drift-risk-6-resolved"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?