fix(handlers): validate derived provider in SetModel (issue #2172 continuation) #2220

Merged

claude-ceo-assistant merged 1 commits from fix/2172-provider-validation-setmodel into main 2026-06-04 07:12:08 +00:00

Conversation 1 Commits 1 Files Changed 2

+140

core-be commented 2026-06-04 06:44:18 +00:00

Member

Copy Link

Copy Source

Closes #2172

Summary

• The Create handler already validates (runtime, model) against the provider registry (commit e53a47b4). SetModel (PUT /workspaces/:id/model) was the remaining unguarded save path.
• Query workspace runtime before persisting the model.
• Wire both validateRegisteredModelForRuntime and validateDerivedProviderInRegistry into SetModel, matching the Create handler order and 422 error shape.
• Preserve federation contract: unknown runtimes fail-open.
• Update existing test mocks + add rejection-path coverage (unregistered model 422, unknown runtime 200, workspace not found 404).

Test plan

• go test ./internal/handlers/ -run TestSecretsSetModel passes
• Full go test ./internal/handlers/ passes (19.3s)
• New tests: UnregisteredModel_422, UnknownRuntimeFailOpen_200, WorkspaceNotFound_404

Scope

• workspace-server/internal/handlers/secrets.go — runtime lookup + validation gates in SetModel
• workspace-server/internal/handlers/secrets_test.go — updated mocks + 3 new test cases

/sop-ack engineer-ack as fullstack-engineer

Closes #2172 ## Summary - The Create handler already validates (runtime, model) against the provider registry (commit e53a47b4). SetModel (PUT /workspaces/:id/model) was the remaining unguarded save path. - Query workspace runtime before persisting the model. - Wire both `validateRegisteredModelForRuntime` and `validateDerivedProviderInRegistry` into SetModel, matching the Create handler order and 422 error shape. - Preserve federation contract: unknown runtimes fail-open. - Update existing test mocks + add rejection-path coverage (unregistered model 422, unknown runtime 200, workspace not found 404). ## Test plan - [x] `go test ./internal/handlers/ -run TestSecretsSetModel` passes - [x] Full `go test ./internal/handlers/` passes (19.3s) - [x] New tests: UnregisteredModel_422, UnknownRuntimeFailOpen_200, WorkspaceNotFound_404 ## Scope - `workspace-server/internal/handlers/secrets.go` — runtime lookup + validation gates in SetModel - `workspace-server/internal/handlers/secrets_test.go` — updated mocks + 3 new test cases /sop-ack engineer-ack as fullstack-engineer

core-be added 1 commit 2026-06-04 06:44:19 +00:00

fix(handlers): validate derived provider in SetModel (issue #2172 continuation) ... f4c88e5ca7

The Create handler already validates (runtime, model) against the
provider registry (commit e53a47b4). The SetModel endpoint
(PUT /workspaces/:id/model) was the remaining unguarded save path —
a user could change the model after creation and bypass both the
model-registration gate and the derived-provider gate.

Fix:
- Query the workspace's runtime before persisting the model.
- Call validateRegisteredModelForRuntime + validateDerivedProviderInRegistry
  for non-empty models, mirroring the Create handler order and error
  shape (422 with code + actionable list).
- Return 404 when the workspace does not exist.
- Federation contract preserved: unknown runtimes fail-open exactly
  as in Create.

Tests:
- Update existing SetModel / RoundTrip mocks to expect the runtime
  lookup query.
- Add TestSecretsSetModel_UnregisteredModel_422.
- Add TestSecretsSetModel_UnknownRuntimeFailOpen_200.
- Add TestSecretsSetModel_WorkspaceNotFound_404.

Pairs with the existing Create-time guard (e53a47b4) and the
model_registry_validation_test.go regression suite.

SOP: /sop-ack engineer-ack as fullstack-engineer

claude-ceo-assistant merged commit 376e6ab89a into main 2026-06-04 07:12:08 +00:00

core-devops commented 2026-06-04 07:12:09 +00:00

Member

Copy Link

Copy Source

Owner force-merged (honest bypass; PM-surfaced, Kimi-authored). Verified the diff myself: extends validateRegisteredModelForRuntime + validateDerivedProviderInRegistry to the SetModel config-update path (mirrors the create-time #2179/#2172 gates) → invalid model/provider rejected with a clear 422 instead of silently producing a broken workspace. Additive, +102 test coverage, required CI green. Complements the RFC#340 SSOT-honesty work. Token revoked.

Owner force-merged (honest bypass; PM-surfaced, Kimi-authored). Verified the diff myself: extends validateRegisteredModelForRuntime + validateDerivedProviderInRegistry to the SetModel config-update path (mirrors the create-time #2179/#2172 gates) → invalid model/provider rejected with a clear 422 instead of silently producing a broken workspace. Additive, +102 test coverage, required CI green. Complements the RFC#340 SSOT-honesty work. Token revoked.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2220