molecule-ai/molecule-core
52
0
Fork 2
Code Issues 183 Pull Requests 14 Actions 5 Packages Projects Releases Wiki Activity

Validate workspace config provider against registry at config-SAVE (fail-closed) + CI gate — catch provider=moonshot-not-in-registry class #2172

New Issue
Closed
opened 2026-06-03 19:03:50 +00:00 by core-devops · 0 comments
core-devops commented 2026-06-03 19:03:50 +00:00
Member
Copy Link
Copy Source

Problem

A workspace can be configured with a model whose derived provider is not in the providers registry, and nothing catches it until the agent BOOTS in prod and the runtime adapter throws.

Live example (adk-demo Assistant, 2026-06-03): workspace config model moonshot/kimi-k2.6 → claude-code adapter derives provider=moonshot → ValueError: provider=moonshot not in providers registry at boot. Canonical names are platform / kimi-coding; bare moonshot is not a registry provider. The config was SAVED without validation and only failed at agent boot. CI never saw it — this is the 3rd instance of the class (original adk-demo claude-code+moonshot boot failure that started the regression-coverage work, + Codex NOT-CONFIGURED cp#423).

Why current gates miss it

  • The providers↔template drift-gate (RFC#580) validates TEMPLATES against the registry, NOT per-WORKSPACE configs. The hole is per-workspace.
  • Unit/contract tests are mock-based — they neither validate a real config against the registry nor boot the real adapter.
  • The real boot gate (boot-to-registration e2e, cp#455/#479) that WOULD catch it is not yet landed.

Fix (cheap, high-leverage — do this independent of cp#455)

Static config↔registry validation, fail-closed at config-SAVE time (the workspace runtime-config set endpoint), not at boot:

  • For every workspace config, resolve model → derived provider (same derivation the adapter uses) and assert the provider ∈ the generated providers registry (providers.yaml SSOT). Reject the save with a clear error + the list of valid providers/aliases if not.
  • Add a CI test over the demo/template configs asserting every configured model resolves to a registry provider (regression gate, runs on every PR — mock-free, just registry-resolution).
  • Optional: register moonshot as an alias of kimi-coding/platform in providers.yaml IF bare moonshot/ should be valid — but the validation is the durable fix regardless.

Acceptance

A workspace config picking a non-registry provider is rejected at save with an actionable message; a CI test fails if any shipped demo/template config references an unregistered provider. Pairs with cp#455 boot-e2e (this is the fast static layer; cp#455 is the deep runtime layer).

## Problem A workspace can be configured with a model whose **derived provider is not in the providers registry**, and nothing catches it until the agent BOOTS in prod and the runtime adapter throws. **Live example (adk-demo Assistant, 2026-06-03):** workspace config model `moonshot/kimi-k2.6` → claude-code adapter derives `provider=moonshot` → `ValueError: provider=moonshot not in providers registry` at boot. Canonical names are `platform` / `kimi-coding`; bare `moonshot` is not a registry provider. The config was SAVED without validation and only failed at agent boot. **CI never saw it** — this is the 3rd instance of the class (original adk-demo claude-code+moonshot boot failure that started the regression-coverage work, + Codex NOT-CONFIGURED cp#423). ## Why current gates miss it - The providers↔template drift-gate (RFC#580) validates TEMPLATES against the registry, NOT per-WORKSPACE configs. The hole is per-workspace. - Unit/contract tests are mock-based — they neither validate a real config against the registry nor boot the real adapter. - The real boot gate (boot-to-registration e2e, cp#455/#479) that WOULD catch it is not yet landed. ## Fix (cheap, high-leverage — do this independent of cp#455) **Static config↔registry validation, fail-closed at config-SAVE time** (the workspace runtime-config set endpoint), not at boot: - For every workspace config, resolve `model → derived provider` (same derivation the adapter uses) and assert the provider ∈ the generated providers registry (providers.yaml SSOT). Reject the save with a clear error + the list of valid providers/aliases if not. - Add a CI test over the demo/template configs asserting every configured model resolves to a registry provider (regression gate, runs on every PR — mock-free, just registry-resolution). - Optional: register `moonshot` as an alias of `kimi-coding`/`platform` in providers.yaml IF bare `moonshot/` should be valid — but the validation is the durable fix regardless. ## Acceptance A workspace config picking a non-registry provider is rejected at save with an actionable message; a CI test fails if any shipped demo/template config references an unregistered provider. Pairs with cp#455 boot-e2e (this is the fast static layer; cp#455 is the deep runtime layer).
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2172
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?