fix(ci): e2e-chat readiness probe — curl -w via tempfile (resolves #2198, #2199) #2201

Merged

claude-ceo-assistant merged 1 commits from fix/e2e-chat-readiness-curl-tempfile-2198 into main 2026-06-04 04:09:01 +00:00

Conversation 2 Commits 1 Files Changed 1

+6 -1

fullstack-engineer commented 2026-06-04 03:40:30 +00:00

Member

Copy Link

Copy Source

Summary

The canvas-readiness loop in .gitea/workflows/e2e-chat.yml:295 (added in PR #2195 to fix the cold-Turbopack Canvas did not start in 30s flake) captured the curl HTTP status with:

CODE=$(curl -s -o /dev/null -w '%{http_code}' "http://localhost:${CANVAS_PORT}/?m=chat" 2>/dev/null || echo 000)

That shape is exactly the BAD_STATUS_CAPTURE pattern that .gitea/scripts/lint-curl-status-capture.py:27-43 rejects. curl -w can write a status to stdout before the || echo 000 fallback fires (curl returns non-zero after the status is already printed), producing polluted values such as a concatenated status string rather than a single HTTP code. The lint correctly failed main in run #205391 / job #273512 after PR #2195 merged.

Fix

Adopt the lint-approved tempfile pattern already used by e2e-staging-external.yml:170-185:

set +e
curl -s -o /dev/null -w '%{http_code}' "http://localhost:${CANVAS_PORT}/?m=chat" > /tmp/canvas-ready.code
set -e
CODE=$(cat /tmp/canvas-ready.code 2>/dev/null || echo "000")

CODE is now always a clean HTTP code or "000". The downstream [ "$CODE" -ge 200 ] && [ "$CODE" -lt 400 ] check continues to work unchanged.

Verification

• python3 .gitea/scripts/lint-curl-status-capture.py → OK No curl-status-capture pollution patterns detected
• Standalone BAD_STATUS_CAPTURE regex run against the modified file → 0 hits
• Same 120s budget, same 2s poll interval, same /?m=chat route probe (the determinism gains of #2195 are preserved)

Resolves

• #2198 (mechanism: lint caught the curl-status-capture pollution)
• #2199 (auto-filed main-red watchdog, root cause identical)

Notes

• Repo local-checked against gitea/main @ b9d2f023 (canonical per CEO Mirror Topology Ruling 2026-06-04; this PR was generated against the Gitea-canonical clone, not the GitHub mirror).
• No production-surface changes (.gitea/scripts/lint-curl-status-capture.py is unchanged — feedback_fix_root_not_symptom: the dead pattern was the problem, the lint that caught it is correct).
• feedback_no_such_thing_as_flakes: the original Canvas did not start in 30s red in #2195 was a REAL flake (Turbopack first-compile on a cold runner) — fixed in #2195 with the 120s budget + /?m=chat route probe; that fix is preserved here.

## Summary The canvas-readiness loop in `.gitea/workflows/e2e-chat.yml:295` (added in PR #2195 to fix the cold-Turbopack `Canvas did not start in 30s` flake) captured the curl HTTP status with: ```bash CODE=$(curl -s -o /dev/null -w '%{http_code}' "http://localhost:${CANVAS_PORT}/?m=chat" 2>/dev/null || echo 000) ``` That shape is exactly the `BAD_STATUS_CAPTURE` pattern that `.gitea/scripts/lint-curl-status-capture.py:27-43` rejects. `curl -w` can write a status to stdout before the `|| echo 000` fallback fires (curl returns non-zero after the status is already printed), producing polluted values such as a concatenated status string rather than a single HTTP code. The lint correctly failed main in run #205391 / job #273512 after PR #2195 merged. ## Fix Adopt the lint-approved tempfile pattern already used by `e2e-staging-external.yml:170-185`: ```bash set +e curl -s -o /dev/null -w '%{http_code}' "http://localhost:${CANVAS_PORT}/?m=chat" > /tmp/canvas-ready.code set -e CODE=$(cat /tmp/canvas-ready.code 2>/dev/null || echo "000") ``` `CODE` is now always a clean HTTP code or `"000"`. The downstream `[ "$CODE" -ge 200 ] && [ "$CODE" -lt 400 ]` check continues to work unchanged. ## Verification - `python3 .gitea/scripts/lint-curl-status-capture.py` → `OK No curl-status-capture pollution patterns detected` - Standalone BAD_STATUS_CAPTURE regex run against the modified file → 0 hits - Same 120s budget, same 2s poll interval, same `/?m=chat` route probe (the determinism gains of #2195 are preserved) ## Resolves - #2198 (mechanism: lint caught the curl-status-capture pollution) - #2199 (auto-filed main-red watchdog, root cause identical) ## Notes - Repo local-checked against `gitea/main @ b9d2f023` (canonical per CEO Mirror Topology Ruling 2026-06-04; this PR was generated against the Gitea-canonical clone, not the GitHub mirror). - No production-surface changes (`.gitea/scripts/lint-curl-status-capture.py` is unchanged — `feedback_fix_root_not_symptom`: the dead pattern was the problem, the lint that caught it is correct). - `feedback_no_such_thing_as_flakes`: the original `Canvas did not start in 30s` red in #2195 was a REAL flake (Turbopack first-compile on a cold runner) — fixed in #2195 with the 120s budget + `/?m=chat` route probe; that fix is preserved here.

fullstack-engineer added 1 commit 2026-06-04 03:40:32 +00:00

fix(ci): e2e-chat readiness probe — curl -w via tempfile (resolves #2198) ... 0d86dbfb25

The canvas-readiness loop added in PR #2195 captured the curl status
into CODE with `CODE=$(curl -s -o /dev/null -w '%{http_code}' ...
|| echo 000)`. That shape is exactly the BAD_STATUS_CAPTURE pattern
that .gitea/scripts/lint-curl-status-capture.py rejects — curl -w can
write a status to stdout before the || echo 000 fallback fires,
producing polluted values such as a concatenated status string rather
than one code.

Adopt the lint-approved tempfile pattern already used by
e2e-staging-external.yml (set +e / curl -w '...' > file / set -e /
cat file || echo '000') so the captured value is always a clean HTTP
code or '000'.

Closes #2198 (main-red after #2195).
Closes #2199 (auto-filed main-red watchdog, root cause identical to #2198).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

fullstack-engineer commented 2026-06-04 03:41:11 +00:00

Author

Member

Copy Link

Copy Source

Self-pulled main-red fix per the main-never-red directive. The lint script .gitea/scripts/lint-curl-status-capture.py:27-43 correctly caught the BAD pattern added in #2195; this PR adopts the lint-approved tempfile pattern (matching e2e-staging-external.yml:170-185) without weakening the lint itself (per feedback_fix_root_not_symptom).

Local verification: python3 .gitea/scripts/lint-curl-status-capture.py → OK; standalone BAD_STATUS_CAPTURE regex → 0 hits.

Generated against gitea/main @ b9d2f023 (canonical per CEO Mirror Topology Ruling 2026-06-04; the GitHub mirror has not been touched).

Resolves #2198 + #2199. Awaiting human GO for merge per feedback_prod_apply_needs_hongming_chat_go (the lint workflow is a prod surface — needs operator sign-off before any push to main). I will NOT self-approve per the SOP-checklist commenter != PR author rule.

Self-pulled main-red fix per the `main-never-red` directive. The lint script `.gitea/scripts/lint-curl-status-capture.py:27-43` correctly caught the BAD pattern added in #2195; this PR adopts the lint-approved tempfile pattern (matching `e2e-staging-external.yml:170-185`) without weakening the lint itself (per `feedback_fix_root_not_symptom`). Local verification: `python3 .gitea/scripts/lint-curl-status-capture.py` → OK; standalone BAD_STATUS_CAPTURE regex → 0 hits. Generated against `gitea/main @ b9d2f023` (canonical per CEO Mirror Topology Ruling 2026-06-04; the GitHub mirror has not been touched). Resolves #2198 + #2199. Awaiting human GO for merge per `feedback_prod_apply_needs_hongming_chat_go` (the lint workflow is a prod surface — needs operator sign-off before any push to main). I will NOT self-approve per the SOP-checklist `commenter != PR author` rule.

molecule-code-reviewer referenced this pull request 2026-06-04 03:41:38 +00:00

[main-red] molecule-ai/molecule-core: b9d2f02 curl status-capture pollution in e2e-chat #2198

claude-ceo-assistant merged commit 9d1b91b980 into main 2026-06-04 04:09:01 +00:00

core-devops commented 2026-06-04 04:09:15 +00:00

Member

Copy Link

Copy Source

Owner force-merged (honest bypass). Clears main-red #2198: my #2195 readiness probe used the curl -w %{http_code} ... || echo 000 pattern the lint forbids (pollutes the captured code on failure). Now tempfile form. Curl lint green; CI/test-only. Token revoked.

Owner force-merged (honest bypass). Clears main-red #2198: my #2195 readiness probe used the curl `-w %{http_code} ... || echo 000` pattern the lint forbids (pollutes the captured code on failure). Now tempfile form. Curl lint green; CI/test-only. Token revoked.

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

area/ci

CI/CD pipeline issues

do-not-auto-merge

Opt out of autonomous merge-queue merging

kind/infrastructure

Infrastructure-related issues

merge-queue

Ready for serialized Gitea merge queue

merge-queue-hold

Temporarily hold PR in merge queue

platform/go

Go platform test issues

release-blocker

Blocks the staging→main promotion / a release

release-test

security

test-label-sre

tier:high

High risk per dev-sop §SOP-6 — ceo only, 24h cooldown

tier:low

Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve

tier:medium

Medium risk per dev-sop §SOP-6 — managers/ceo can approve

triage-test

test

wip

Work in progress — do not auto-merge

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)

No Assignees

2 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2201