molecule-ai/molecule-core
52
0
Fork 2
Code Issues 184 Pull Requests 16 Actions 3 Packages Projects Releases Wiki Activity

[main-red] molecule-ai/molecule-core: b9d2f02 curl status-capture pollution in e2e-chat #2198

New Issue
Closed
opened 2026-06-04 03:01:58 +00:00 by molecule-code-reviewer · 1 comment
molecule-code-reviewer commented 2026-06-04 03:01:58 +00:00
Member
Copy Link
Copy Source

MECHANISM: molecule-core main b9d2f023c8e4 is red in Lint curl status-code capture / Scan workflows for curl status-capture pollution after PR #2195 merged. The new/current .gitea/workflows/e2e-chat.yml:295 assigns CODE=$(curl -s -o /dev/null -w '%{http_code}' ... || echo 000). The lint rule in .gitea/scripts/lint-curl-status-capture.py:27-43 intentionally rejects that shape because curl -w can write a status to stdout before returning non-zero, then the fallback appends 000, producing polluted values such as a concatenated status string rather than one code.

EVIDENCE: Gitea job 273512 (run 205391, head b9d2f023c8e4498dda24cde00e3ff2e3ec133606) completed failure. Log excerpt: Found 1 curl-status-capture pollution site(s). The reported file is .gitea/workflows/e2e-chat.yml and the matched command is the canvas readiness probe at line 295. git log identifies the head as merge PR #2195: persist push-mode chat round-trip synchronously.

RECOMMENDED FIX SHAPE: responsible repo/file is molecule-core/.gitea/workflows/e2e-chat.yml. Change the readiness probe to the lint-approved status tempfile pattern: run curl ... -w '%{http_code}' with set +e and redirect status into a temp file, restore set -e, read the file, and default empty/missing content to 000. Do not weaken .gitea/scripts/lint-curl-status-capture.py; it is catching the intended class.

MECHANISM: molecule-core main `b9d2f023c8e4` is red in `Lint curl status-code capture / Scan workflows for curl status-capture pollution` after PR #2195 merged. The new/current `.gitea/workflows/e2e-chat.yml:295` assigns `CODE=$(curl -s -o /dev/null -w '%{http_code}' ... || echo 000)`. The lint rule in `.gitea/scripts/lint-curl-status-capture.py:27-43` intentionally rejects that shape because `curl -w` can write a status to stdout before returning non-zero, then the fallback appends `000`, producing polluted values such as a concatenated status string rather than one code. EVIDENCE: Gitea job `273512` (`run 205391`, head `b9d2f023c8e4498dda24cde00e3ff2e3ec133606`) completed `failure`. Log excerpt: `Found 1 curl-status-capture pollution site(s)`. The reported file is `.gitea/workflows/e2e-chat.yml` and the matched command is the canvas readiness probe at line 295. `git log` identifies the head as merge PR #2195: `persist push-mode chat round-trip synchronously`. RECOMMENDED FIX SHAPE: responsible repo/file is `molecule-core/.gitea/workflows/e2e-chat.yml`. Change the readiness probe to the lint-approved status tempfile pattern: run `curl ... -w '%{http_code}'` with `set +e` and redirect status into a temp file, restore `set -e`, read the file, and default empty/missing content to `000`. Do not weaken `.gitea/scripts/lint-curl-status-capture.py`; it is catching the intended class.
molecule-code-reviewer commented 2026-06-04 03:41:38 +00:00
Author
Member
Copy Link
Copy Source

Status update: fix PR #2201 is open at head 0d86dbf and validates the intended remediation path. On that PR head, Lint curl status-code capture / Scan workflows for curl status-capture pollution is success, and E2E Chat / E2E Chat is also success. Remaining blockers are review/ceremony plus unrelated pending lint/status contexts, not this issue's curl-status-capture mechanism.

Status update: fix PR #2201 is open at head `0d86dbf` and validates the intended remediation path. On that PR head, `Lint curl status-code capture / Scan workflows for curl status-capture pollution` is `success`, and `E2E Chat / E2E Chat` is also `success`. Remaining blockers are review/ceremony plus unrelated pending lint/status contexts, not this issue's curl-status-capture mechanism.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2198
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?