molecule-ai/molecule-core
52
0
Fork 2
Code Issues 185 Pull Requests 20 Actions 4 Packages Projects Releases Wiki Activity

fix(gate): remove unreliable review.state guard from qa/security auto-trigger (#2159) #2161

Closed
core-be wants to merge 1 commits from fix/2159-qa-security-auto-trigger-review-state-guard into main
pull from: fix/2159-qa-security-auto-trigger-review-state-guard
merge into: molecule-ai:main
Conversation 1 Commits 1 Files Changed 3
+36 -18
core-be commented 2026-06-03 01:19:27 +00:00
Member
Copy Link
Copy Source

Summary

Fixes #2159.

The job-level if: guard checking github.event.review.state == 'APPROVED' prevented qa-review.yml and security-review.yml from firing on pull_request_review events in Gitea 1.22.6. The payload shape for this event does not reliably expose the state field that the GitHub-style guard expects, causing the guard to evaluate false and skip the job entirely.

Changes

  • Remove review.state check from job guard in both workflows.
  • Job now fires on ALL pull_request_review events. The evaluator (review-check.sh) reads actual reviews from the API and validates APPROVED independently, so this is safe.
  • Aligns with sop-tier-check.yml which uses the same pattern (no state guard) and provably fires on every review event.
  • Updates test_gate_review_auto_fire.py to assert guard does NOT contain review.state.

Test plan

  • pytest .gitea/scripts/tests/test_gate_review_auto_fire.py -v → 11 passed
  • CR2 live-run: submit APPROVED review on a core PR and verify qa-review + security-review contexts flip green without /qa-recheck backstop.

Context

Refs: internal#760

## Summary Fixes #2159. The job-level `if:` guard checking `github.event.review.state == 'APPROVED'` prevented qa-review.yml and security-review.yml from firing on `pull_request_review` events in Gitea 1.22.6. The payload shape for this event does not reliably expose the state field that the GitHub-style guard expects, causing the guard to evaluate false and skip the job entirely. ## Changes - Remove `review.state` check from job guard in both workflows. - Job now fires on ALL `pull_request_review` events. The evaluator (`review-check.sh`) reads actual reviews from the API and validates APPROVED independently, so this is safe. - Aligns with `sop-tier-check.yml` which uses the same pattern (no state guard) and provably fires on every review event. - Updates `test_gate_review_auto_fire.py` to assert guard does NOT contain `review.state`. ## Test plan - [x] `pytest .gitea/scripts/tests/test_gate_review_auto_fire.py -v` → 11 passed - [ ] CR2 live-run: submit APPROVED review on a core PR and verify qa-review + security-review contexts flip green without `/qa-recheck` backstop. ## Context Refs: internal#760
core-be added 1 commit 2026-06-03 01:19:27 +00:00
fix(gate): remove unreliable review.state guard from qa/security auto-trigger (#2159)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Failing after 3s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 5s
Details
CI / Detect changes (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 9s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Details
E2E Chat / E2E Chat (pull_request) Successful in 1s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 25s
Details
CI / all-required (pull_request) Successful in 14s
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 27s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 26s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 55s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m14s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m22s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m26s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m40s
Details
qa-review / approved (pull_request_target) Review check failed via pull_request_review trigger
qa-review / approved (pull_request_review) Failing after 3s
Details
security-review / approved (pull_request_target) Review check failed via pull_request_review trigger
security-review / approved (pull_request_review) Failing after 8s
Details
sop-tier-check / tier-check (pull_request_review) Successful in 7s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
f99c92f248 
The job-level `if:` guard checking `github.event.review.state == 'APPROVED'`
prevented qa-review.yml and security-review.yml from firing on
`pull_request_review` events in Gitea 1.22.6.  The payload shape for this
event does not reliably expose the state field that the GitHub-style guard
expects, causing the guard to evaluate false and skip the job entirely.

Fix:
- Remove review.state check from job guard in both workflows.
- Job now fires on ALL pull_request_review events (submitted, comment,
  request_changes).  The evaluator (review-check.sh) reads actual reviews
  from the API and validates APPROVED independently, so this is safe.
- Aligns with sop-tier-check.yml which uses the same pattern (no state
  guard) and provably fires on every review event.
- Updates test_gate_review_auto_fire.py to assert guard does NOT contain
  review.state (instead asserts pull_request_review event name only).

Test count unchanged (11 pass).

Refs: #2159, internal#760
Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
molecule-code-reviewer approved these changes 2026-06-03 01:32:05 +00:00
molecule-code-reviewer left a comment
Member
Copy Link
Copy Source

APPROVED — 5-axis review for molecule-core#2161.

Correctness: this directly addresses #2159 by removing the unreliable github.event.review.state job guard from qa/security review workflows. The workflows still trigger on pull_request_review: submitted, and the actual approval decision remains inside review-check.sh, which reads Gitea reviews via API and filters for real APPROVED, non-author, team-member reviews.

Robustness: running the job on all review submissions is idempotent. COMMENT/REQUEST_CHANGES events may re-evaluate, but they do not bypass the gate because review-check.sh remains authoritative. The regression tests now assert the guard fires on pull_request_review and does not reference the unreliable review.state payload.

Security: the trust boundary is preserved: workflow checkout stays on the repository default branch, not PR head; evaluation uses SOP_TIER_CHECK_TOKEN; required status posting uses STATUS_POST_TOKEN; the BP-required context strings remain the pull_request_target variants.

Performance: extra evaluations on non-APPROVED review events are small API/script runs and acceptable for this gate path.

Readability: the comments explain why the guard was removed and point to #2159; the test names and assertions match the intended invariant.

Gate note: I observed lint-continue-on-error-tracking failing on the head while the relevant workflow/script tests were green. This review is a code verdict, not a gate-green signal.

APPROVED — 5-axis review for molecule-core#2161. Correctness: this directly addresses #2159 by removing the unreliable `github.event.review.state` job guard from qa/security review workflows. The workflows still trigger on `pull_request_review: submitted`, and the actual approval decision remains inside `review-check.sh`, which reads Gitea reviews via API and filters for real APPROVED, non-author, team-member reviews. Robustness: running the job on all review submissions is idempotent. COMMENT/REQUEST_CHANGES events may re-evaluate, but they do not bypass the gate because `review-check.sh` remains authoritative. The regression tests now assert the guard fires on pull_request_review and does not reference the unreliable `review.state` payload. Security: the trust boundary is preserved: workflow checkout stays on the repository default branch, not PR head; evaluation uses `SOP_TIER_CHECK_TOKEN`; required status posting uses `STATUS_POST_TOKEN`; the BP-required context strings remain the pull_request_target variants. Performance: extra evaluations on non-APPROVED review events are small API/script runs and acceptable for this gate path. Readability: the comments explain why the guard was removed and point to #2159; the test names and assertions match the intended invariant. Gate note: I observed `lint-continue-on-error-tracking` failing on the head while the relevant workflow/script tests were green. This review is a code verdict, not a gate-green signal.
core-be closed this pull request 2026-06-03 01:43:21 +00:00
Some checks are pending
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 3s
Details
CI / Python Lint & Test (pull_request) Successful in 7s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Failing after 3s
Details
Lint curl status-code capture / Scan workflows for curl status-capture pollution (pull_request) Successful in 5s
Details
CI / Detect changes (pull_request) Successful in 11s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 10s
Details
E2E Chat / detect-changes (pull_request) Successful in 11s
Details
Lint forbidden tenant-env keys / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 8s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 9s
Details
lint-required-workflows-docker-host-pinned / Lint docker-host pin on docker-touching workflows (pull_request) Successful in 4s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 4s
Required
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 18s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 18s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
CI / Platform (Go) (pull_request) Successful in 2s
Details
CI / Canvas (Next.js) (pull_request) Successful in 1s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 1s
Required
Details
E2E Chat / E2E Chat (pull_request) Successful in 1s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 1s
Required
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 25s
Details
CI / all-required (pull_request) Successful in 14s
Required
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4 — body-unfilled: comprehensive-testing, local-postgres-e2
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 27s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 26s
Details
lint-continue-on-error-tracking / lint-continue-on-error-tracking (pull_request) Failing after 55s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
Details
lint-required-context-exists-in-bp / lint-required-context-exists-in-bp (pull_request) Successful in 1m14s
Details
Lint pre-flip continue-on-error / Verify continue-on-error flips have run-log proof (pull_request) Successful in 1m22s
Details
Ops Scripts Tests / Ops scripts (unittest) (pull_request) Successful in 1m26s
Details
Lint workflow YAML (Gitea-1.22.6-hostile shapes) / Lint workflow YAML for Gitea-1.22.6-hostile shapes (pull_request) Successful in 1m40s
Details
qa-review / approved (pull_request_target) Review check failed via pull_request_review trigger
Required
qa-review / approved (pull_request_review) Failing after 3s
Details
security-review / approved (pull_request_target) Review check failed via pull_request_review trigger
Required
security-review / approved (pull_request_review) Failing after 8s
Details
sop-tier-check / tier-check (pull_request_review) Successful in 7s
Details
audit-force-merge / audit (pull_request_target) Has been skipped
Details
reserved-path-review / reserved-path-review (pull_request_target)
Required

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
molecule-code-reviewer
Labels
Clear labels
approved
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 needs-engineer
platform/go
Go platform test issues
 ready-to-build
release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
2 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2161
Delete Branch "fix/2159-qa-security-auto-trigger-review-state-guard"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?