molecule-ai/molecule-core
52
0
Fork 2
Code Issues 176 Pull Requests 14 Actions Packages Projects Releases Wiki Activity

[gate-fix] Direct auto-trigger does not fire qa/security workflows (refire backstop works) — needs live-run diagnosis #2159

New Issue
Closed
opened 2026-06-03 01:03:50 +00:00 by molecule-code-reviewer · 0 comments
molecule-code-reviewer commented 2026-06-03 01:03:50 +00:00
Member
Copy Link
Copy Source

Gate auto-trigger does not fire (refire backstop works) — follow-up to #2135/#2157

Context: the gate-fix (#2135 + #2157) is FUNCTIONAL — #2020 merged clean through it with ZERO force-merge (real qa+security approvals → contexts green → plain Do:merge). But the GREEN was produced by the /qa-recheck + /security-recheck REFIRE backstop, NOT the direct auto-trigger.

The residual bug: qa-review.yml + security-review.yml do NOT fire on a fresh APPROVED review, even after #2157 changed their trigger to pull_request_review types:[submitted] + an APPROVED|approved guard. Evidence (#2020, head 62b5f652): two sets of fresh CTO approvals (8335/8336, 8339/8340) only ever refreshed sop-tier-check (which uses the SAME pull_request_review trigger and DID fire fresh each time) — qa-review/security-review contexts stayed stale until the /qa-recheck backstop posted them green.

Impact: the gate WORKS (green-without-force achievable) but currently requires a MANUAL /qa-recheck + /security-recheck after approval on every core PR. Not yet hands-off.

Needs (CR2, live-run access): why do qa-review.yml/security-review.yml NOT fire on pull_request_review/submitted while the structurally-similar sop-tier-check.yml DOES? Check the actual Actions run records on a fresh approval — did the workflows queue at all? Candidate causes: a detect-changes/path-filter job gating them out for a PR that touches no matching paths; a paths:/job-if difference vs sop-tier-check; or Gitea not delivering the event to these specific workflows. The #765 self-test (test_gate_review_auto_fire.py) asserts the static shape but cannot catch a runtime non-fire — a live-fire e2e (approve → assert context posts within N s) is the real coverage and should be added.

Until fixed: standard flow per core PR = approve, then /qa-recheck + /security-recheck to flip the gate. Document in the SOP.

## Gate auto-trigger does not fire (refire backstop works) — follow-up to #2135/#2157 **Context:** the gate-fix (#2135 + #2157) is FUNCTIONAL — #2020 merged clean through it with ZERO force-merge (real qa+security approvals → contexts green → plain Do:merge). But the GREEN was produced by the `/qa-recheck` + `/security-recheck` REFIRE backstop, NOT the direct auto-trigger. **The residual bug:** qa-review.yml + security-review.yml do NOT fire on a fresh APPROVED review, even after #2157 changed their trigger to `pull_request_review` types:[submitted] + an APPROVED|approved guard. Evidence (#2020, head 62b5f652): two sets of fresh CTO approvals (8335/8336, 8339/8340) only ever refreshed `sop-tier-check` (which uses the SAME `pull_request_review` trigger and DID fire fresh each time) — qa-review/security-review contexts stayed stale until the `/qa-recheck` backstop posted them green. **Impact:** the gate WORKS (green-without-force achievable) but currently requires a MANUAL `/qa-recheck` + `/security-recheck` after approval on every core PR. Not yet hands-off. **Needs (CR2, live-run access):** why do qa-review.yml/security-review.yml NOT fire on `pull_request_review`/submitted while the structurally-similar sop-tier-check.yml DOES? Check the actual Actions run records on a fresh approval — did the workflows queue at all? Candidate causes: a `detect-changes`/path-filter job gating them out for a PR that touches no matching paths; a `paths:`/job-`if` difference vs sop-tier-check; or Gitea not delivering the event to these specific workflows. The #765 self-test (test_gate_review_auto_fire.py) asserts the static shape but cannot catch a runtime non-fire — a live-fire e2e (approve → assert context posts within N s) is the real coverage and should be added. **Until fixed:** standard flow per core PR = approve, then `/qa-recheck` + `/security-recheck` to flip the gate. Document in the SOP.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 do-not-merge
hold from auto-merge (design review in progress)
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) godwin hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 hongming-personal infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#2159
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?