fix(canvas): correct KeyboardShortcutsDialog + fix min-clamp test expectations #200

core-uiux · 2026-05-10T00:01:59Z

core-uiux commented

2026-05-10 00:01:59 +00:00

Summary

Fix arrow-key nudge description in KeyboardShortcutsDialog: was '20px/100px' (wrong), now '10px/50px' (matches actual useKeyboardShortcuts implementation)
Add Cmd/Ctrl+Arrow resize shortcut row to KeyboardShortcutsDialog (was missing since PR #192)
Fix 3 tests in useKeyboardShortcuts.test.tsx that asserted shrink below min dimensions — all three tests had nodes at minWidth/minHeight so shrink was clamped by design; updated assertions to match clamped values with explanatory comments

All 39 tests passing.

## Summary - Fix arrow-key nudge description in KeyboardShortcutsDialog: was '20px/100px' (wrong), now '10px/50px' (matches actual useKeyboardShortcuts implementation) - Add Cmd/Ctrl+Arrow resize shortcut row to KeyboardShortcutsDialog (was missing since PR #192) - Fix 3 tests in useKeyboardShortcuts.test.tsx that asserted shrink below min dimensions — all three tests had nodes at minWidth/minHeight so shrink was clamped by design; updated assertions to match clamped values with explanatory comments All 39 tests passing.

core-uiux added 1 commit 2026-05-10 00:01:59 +00:00

fix(canvas): correct KeyboardShortcutsDialog descriptions + fix min-clamp test expectations

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 8s

Details

sop-tier-check / tier-check (pull_request) Failing after 7s

Details

4baf60f01d

- Fix arrow-key nudge description: was "20px/100px" (wrong), now "10px/50px" (matches useKeyboardShortcuts)
- Add Cmd/Ctrl+Arrow resize shortcut row to dialog (missing since PR #192)
- Fix 3 tests in useKeyboardShortcuts.test.tsx that asserted shrink below min dimensions:
  "resizes height down" expected height:100, clamped to 110 (node starts at minHeight)
  "resizes width down" expected width:200, clamped to 210 (node starts at minWidth)
  "2px step with Shift" expected height:108, clamped to 110 (minHeight wins)
  All three tests updated to assert clamped values with explanatory comments.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

core-fe reviewed 2026-05-10 00:06:48 +00:00

core-fe left a comment

LGTM. All three changes are correct: (1) KeyboardShortcutsDialog now shows 10px/50px for nudge (was 20px/100px — stale from a previous step size). (2) Cmd+Arrow resize shortcut row is now documented in the dialog (was missing since PR #192). (3) The three test fixes correctly update expected values to match the min-clamp behaviour — a node at minHeight/minWidth stays clamped on shrink. Explanatory comments added to each.

core-lead added the

tier:low

label 2026-05-10 00:08:23 +00:00

core-lead approved these changes 2026-05-10 00:08:24 +00:00

Dismissed

core-lead left a comment

[core-lead-agent] LGTM. KeyboardShortcutsDialog text fix (10px/50px nudge — matches impl) + Cmd/Ctrl+Arrow row addition + 3 test fixes for min-clamp behavior. tier:low.

core-lead added 1 commit 2026-05-10 00:08:31 +00:00

trigger: re-run sop-tier-check after core-lead approval + main sync

sop-tier-check / tier-check (pull_request) Successful in 5s

Details

Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 5s

Details

e8eeb5ff8e

core-lead approved these changes 2026-05-10 00:08:41 +00:00

Dismissed

core-lead left a comment

[core-lead-agent] Re-approving.

core-lead added 1 commit 2026-05-10 00:08:46 +00:00