molecule-ai/molecule-core
36
0
Fork 2
Code Issues 5 Pull Requests 3 Actions Packages Projects Releases Wiki Activity

Merge pull request 'fix(canvas): correct KeyboardShortcutsDialog + fix min-clamp test expectations' (#200) from fix/keyboard-shortcuts-dialog-update into main
All checks were successful
Secret scan / Scan diff for credential-shaped strings (push) Successful in 4s
Details

Browse Source
This commit is contained in:
Molecule AI · core-lead 2026-05-10 00:08:52 +00:00
commit 36dcf076d2
2 changed files with 14 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
canvas/src/components/KeyboardShortcutsDialog.tsx
View File

@ -18,7 +18,11 @@ const SHORTCUT_GROUPS: ShortcutGroup[] = [
},
{
keys: ["↑↓←→"],
description: "Nudge selected node 20px; hold Shift for 100px",
description: "Nudge selected node 10px; hold Shift for 50px",
},
{
keys: ["Cmd", "↑↓←→"],
description: "Resize selected node (↑↓ height, ←→ width); hold Shift for fine control (2px)",
},
{
keys: ["Enter"],

12
canvas/src/components/canvas/__tests__/useKeyboardShortcuts.test.tsx
View File

@ -330,12 +330,14 @@ describe("Cmd/Ctrl+Arrow — keyboard node resize", () => {
});
it("resizes height down (smaller) on Cmd/Ctrl+ArrowUp", () => {
// Node starts at minHeight=110 (no children). Shrinking clamps to min —
// height stays 110. Width is unchanged.
fireEvent.keyDown(window, { key: "ArrowUp", metaKey: true });
expect(mockStoreState.onNodesChange).toHaveBeenCalledWith([
expect.objectContaining({
type: "dimensions",
id: "n1",
dimensions: { width: 210, height: 100 },
dimensions: { width: 210, height: 110 },
}),
]);
});
@ -352,12 +354,14 @@ describe("Cmd/Ctrl+Arrow — keyboard node resize", () => {
});
it("resizes width down (smaller) on Cmd/Ctrl+ArrowLeft", () => {
// Node starts at minWidth=210 (no children). Shrinking clamps to min —
// width stays 210. Height is unchanged.
fireEvent.keyDown(window, { key: "ArrowLeft", metaKey: true });
expect(mockStoreState.onNodesChange).toHaveBeenCalledWith([
expect.objectContaining({
type: "dimensions",
id: "n1",
dimensions: { width: 200, height: 110 },
dimensions: { width: 210, height: 110 },
}),
]);
});
@ -374,10 +378,12 @@ describe("Cmd/Ctrl+Arrow — keyboard node resize", () => {
});
it("uses 2px step with Shift held", () => {
// Step is 2px with Shift, but minHeight=110 clamps the result.
// 110 - 2 = 108, Math.max(110, 108) = 110. Width is unchanged.
fireEvent.keyDown(window, { key: "ArrowUp", metaKey: true, shiftKey: true });
expect(mockStoreState.onNodesChange).toHaveBeenCalledWith([
expect.objectContaining({
dimensions: { width: 210, height: 108 },
dimensions: { width: 210, height: 110 },
}),
]);
});