molecule-ai/molecule-core
51
0
Fork 2
Code Issues 157 Pull Requests 160 Actions 12 Packages Projects Releases Wiki Activity

fix(registry,discovery,mcp): prevent cross-tenant peer metadata leak (#1953) #1956

Closed
agent-pm wants to merge 1 commits from fix/cross-tenant-isolation-1953 into main
pull from: fix/cross-tenant-isolation-1953
merge into: molecule-ai:main
Conversation 2 Commits 1 Files Changed 8
+65 -83
agent-pm commented 2026-05-27 16:02:49 +00:00
Member
Copy Link
Copy Source

Fixes #1953.

Three code paths used parent_id IS NULL to identify siblings of a root-level workspace. Because every org root has parent_id IS NULL, this predicate matched ALL org roots across ALL tenants, leaking peer metadata and allowing cross-tenant A2A delegation.

Changes

  • registry/access.go: Remove the root-level sibling fast-path in CanCommunicate. Two distinct workspaces with parent_id = NULL are in different orgs and must not communicate.
  • discovery.go: Skip the sibling query entirely when the caller is an org root (parent_id IS NULL). Each org has exactly one root.
  • mcp_tools.go: Same fix for the MCP list_peers tool path.

Test updates

  • TestCanCommunicate_RootSiblings → TestCanCommunicate_Denied_RootCrossTenant
  • Tests that mocked root-root communication now use parent-child or shared-parent relationships so they continue to test allowed paths.

Verification

All 695 workspace-server tests pass with -race.

🤖 Generated with Claude Code

Fixes #1953. Three code paths used `parent_id IS NULL` to identify siblings of a root-level workspace. Because every org root has `parent_id IS NULL`, this predicate matched ALL org roots across ALL tenants, leaking peer metadata and allowing cross-tenant A2A delegation. ### Changes - **registry/access.go**: Remove the root-level sibling fast-path in `CanCommunicate`. Two distinct workspaces with `parent_id = NULL` are in different orgs and must not communicate. - **discovery.go**: Skip the sibling query entirely when the caller is an org root (`parent_id IS NULL`). Each org has exactly one root. - **mcp_tools.go**: Same fix for the MCP `list_peers` tool path. ### Test updates - `TestCanCommunicate_RootSiblings` → `TestCanCommunicate_Denied_RootCrossTenant` - Tests that mocked root-root communication now use parent-child or shared-parent relationships so they continue to test allowed paths. ### Verification All 695 workspace-server tests pass with `-race`. --- 🤖 Generated with [Claude Code](https://claude.com/claude-code)
agent-pm added 2 commits 2026-05-27 16:02:49 +00:00
docs: fix stale molecule-monorepo references (#1837)
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 46s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 1m24s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m12s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 8m4s
Details
qa-review / approved (pull_request) Refired via /qa-recheck by unknown
Details
security-review / approved (pull_request) Refired via /security-recheck; security-review failed
Details
gate-check-v3 / gate-check (pull_request) Successful in 15s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 8s
Details
sop-tier-check / tier-check (pull_request_review) Successful in 6s
Details
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
CI / Python Lint & Test (pull_request) Successful in 2s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 5s
Details
CI / Detect changes (pull_request) Successful in 5s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 9s
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
E2E Chat / detect-changes (pull_request) Successful in 14s
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 14s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 9s
Details
Harness Replays / detect-changes (pull_request) Successful in 5s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 5s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 4s
Details
qa-review / approved (pull_request_target) Successful in 3s
Details
Secret scan / Scan diff for credential-shaped strings (pull_request) Successful in 6s
Details
sop-checklist / review-refire (pull_request_target) Has been skipped
Details
sop-checklist / all-items-acked (pull_request) acked: 0/7 — missing: comprehensive-testing, local-postgres-e2e, staging-smoke, +4
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request_target) Successful in 3s
Details
security-review / approved (pull_request_target) Successful in 3s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 1s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 1s
Details
CI / Platform (Go) (pull_request) Successful in 6s
Details
Harness Replays / Harness Replays (pull_request) Successful in 1s
Details
gate-check-v3 / gate-check (pull_request_target) Successful in 15s
Details
sop-tier-check / tier-check (pull_request_target) Successful in 9s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Successful in 6s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Successful in 10s
Details
E2E Chat / E2E Chat (pull_request) Successful in 11s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 56s
Details
CI / Canvas (Next.js) (pull_request) Successful in 6m18s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
CI / all-required (pull_request) Successful in 7m23s
Details
audit-force-merge / audit (pull_request_target) Successful in 4s
Details
2a04e9bec1 
Replace remaining user-facing references to the old repo name
molecule-monorepo with molecule-core in clone instructions,
documentation links, path examples, and source links.

Affected files:
- README.md (clone commands in Quick Start)
- docs/quickstart.md (clone commands in one-command and manual paths)
- docs/architecture/molecule-technical-doc.md (repo links)
- docs/development/local-development.md (path example)
- docs/infra/workspace-terminal.md (factually incorrect rename claim)
- docs/integrations/opencode.md (task example)
- docs/internal-content-policy.md (repo name and path references)
- canvas/src/app/pricing/page.tsx (source code link)
- .env.example (repo name in comment)
- tools/check-template-parity.sh (path example in comment)

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
fix(registry,discovery,mcp): prevent cross-tenant peer metadata leak (#1953)
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 13s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 55s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 48s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
Harness Replays / detect-changes (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 9s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 13s
Details
qa-review / approved (pull_request) Failing after 4s
Details
security-review / approved (pull_request) Failing after 4s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 3s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m15s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 6m22s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 14s
Details
E2E Chat / E2E Chat (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 13s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m44s
Details
Harness Replays / Harness Replays (pull_request) Successful in 11s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 2m18s
Details
CI / Platform (Go) (pull_request) Successful in 6m54s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m20s
Details
CI / all-required (pull_request) Successful in 33m31s
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Waiting to run
Details
c8e19bbdcd 
Three code paths used `parent_id IS NULL` to identify 'siblings' of a
root-level workspace. Because every org root has `parent_id IS NULL`,
this predicate matched ALL org roots across ALL tenants, leaking peer
metadata and allowing cross-tenant A2A delegation.

Fixes:
- registry/access.go: Remove the root-level sibling fast-path in
  `CanCommunicate`. Two distinct workspaces with `parent_id = NULL`
  are in different orgs and must not communicate.
- discovery.go: Skip the sibling query entirely when the caller is an
  org root (parent_id IS NULL). Each org has exactly one root.
- mcp_tools.go: Same fix for the MCP `list_peers` tool path.

Tests updated to reflect the new security boundary:
- TestCanCommunicate_RootSiblings → TestCanCommunicate_Denied_RootCrossTenant
- Tests that mocked root-root communication now use parent-child or
  shared-parent relationships so they continue to test allowed paths.

All 695 workspace-server tests pass with -race.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
agent-pm commented 2026-05-27 16:08:29 +00:00
Author
Member
Copy Link
Copy Source

Note: PR #1954 (core-be) already fixes the three leaking paths (discovery.Peers, mcp_tools.toolListPeers, a2a_proxy) via org_scope.go CTE scoping. This PR (#1956) closes the residual weakness filed as #1955 — registry.CanCommunicate itself still treats any two org-roots as siblings.\n\nThis PR is smaller and can land independently of #1954, or be merged after #1954 to close the full class. Either order is safe.

Note: PR #1954 (core-be) already fixes the three leaking paths (discovery.Peers, mcp_tools.toolListPeers, a2a_proxy) via `org_scope.go` CTE scoping. This PR (#1956) closes the **residual weakness** filed as #1955 — `registry.CanCommunicate` itself still treats any two org-roots as siblings.\n\nThis PR is smaller and can land independently of #1954, or be merged after #1954 to close the full class. Either order is safe.
agent-pm closed this pull request 2026-05-27 17:46:36 +00:00
agent-pm commented 2026-05-27 17:46:50 +00:00
Author
Member
Copy Link
Copy Source

Closing as superseded by #1954 (canonical cross-tenant fix with broader coverage: org_scope.go, a2a_proxy.go hardening, E2E test update, integration tests).

Closing as superseded by #1954 (canonical cross-tenant fix with broader coverage: org_scope.go, a2a_proxy.go hardening, E2E test update, integration tests).
Some required checks failed
ci-arm64-advisory / fast-checks (pull_request) Waiting to run
Details
Lint shellcheck (arm64 pilot) / shellcheck-arm64 (pilot) (pull_request) Successful in 11s
Details
Block internal-flavored paths / Block forbidden paths (pull_request) Successful in 13s
Details
CI / Detect changes (pull_request) Successful in 13s
Details
CI / Python Lint & Test (pull_request) Successful in 9s
Details
E2E API Smoke Test / detect-changes (pull_request) Successful in 19s
Details
E2E Chat / detect-changes (pull_request) Successful in 15s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (pull_request) Has been skipped
Details
E2E Staging Canvas (Playwright) / detect-changes (pull_request) Successful in 10s
Details
E2E Peer Visibility (literal MCP list_peers) / E2E Peer Visibility (local) (pull_request) Successful in 55s
Details
E2E Staging SaaS (full lifecycle) / pr-validate (pull_request) Successful in 48s
Details
Handlers Postgres Integration / detect-changes (pull_request) Successful in 14s
Details
Harness Replays / detect-changes (pull_request) Successful in 9s
Details
Lint forbidden tenant-env keys / Scan workspace_secrets writers for forbidden env keys (pull_request) Successful in 9s
Details
Lint no tenant GITEA or GITHUB token write / Scan for repo-host token write into tenant workspace surface (pull_request) Successful in 6s
Details
gate-check-v3 / gate-check (pull_request) Successful in 13s
Details
qa-review / approved (pull_request) Failing after 4s
Details
security-review / approved (pull_request) Failing after 4s
Details
sop-checklist / na-declarations (pull_request) N/A: (none)
Details
sop-checklist / all-items-acked (pull_request) Successful in 3s
Details
sop-checklist / review-refire (pull_request) Has been skipped
Details
sop-tier-check / tier-check (pull_request) Successful in 5s
Details
lint-required-no-paths / lint-required-no-paths (pull_request) Successful in 1m4s
Details
E2E Staging External Runtime / E2E Staging External Runtime (pull_request) Successful in 5m15s
Details
E2E Staging SaaS (full lifecycle) / E2E Staging SaaS (pull_request) Successful in 6m22s
Details
CI / Shellcheck (E2E scripts) (pull_request) Successful in 14s
Details
E2E Chat / E2E Chat (pull_request) Successful in 7s
Details
E2E Staging Canvas (Playwright) / Canvas tabs E2E (pull_request) Successful in 13s
Details
E2E API Smoke Test / E2E API Smoke Test (pull_request) Failing after 1m44s
Required
Details
Harness Replays / Harness Replays (pull_request) Successful in 11s
Details
Handlers Postgres Integration / Handlers Postgres Integration (pull_request) Failing after 2m18s
Required
Details
CI / Platform (Go) (pull_request) Successful in 6m54s
Details
CI / Canvas (Next.js) (pull_request) Successful in 7m20s
Details
CI / all-required (pull_request) Successful in 33m31s
Required
Details
CI / Canvas Deploy Reminder (pull_request) Has been skipped
Details
audit-force-merge / audit (pull_request) Waiting to run
Details

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1956
Delete Branch "fix/cross-tenant-isolation-1953"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?