molecule-ai/molecule-core
51
0
Fork 2
Code Issues 165 Pull Requests 155 Actions 6 Packages Projects Releases Wiki Activity

security(follow-up): registry.CanCommunicate treats any two org-roots as siblings (Discover/CheckAccess org-root<->org-root) — residual of #1953 #1955

New Issue
Closed
opened 2026-05-27 15:47:58 +00:00 by hongming · 0 comments
hongming commented 2026-05-27 15:47:58 +00:00
Owner
Copy Link
Copy Source

Residual cross-tenant weakness found while fixing #1953 (PR #1954).

#1954 scopes the three leaking paths (discovery.Peers, mcp_tools.toolListPeers, a2a_proxy) to the caller org via the org-root parent_id CTE. But registry.CanCommunicate itself still treats ANY two org-roots as siblings (parent_id IS NULL = all roots), so discovery.Discover and CheckAccess retain the same root-sibling weakness for the org-root<->org-root case (two top-level workspaces in different orgs can pass CanCommunicate).

Fix options: (a) scope CanCommunicate itself with the same org-root CTE (orgRootID/sameOrg in the new org_scope.go), or (b) the pending org_id column on workspaces (denormalized) so org checks are a cheap WHERE org_id=? everywhere. Option (b) is the deferred architecture decision; (a) is a contained fix in the meantime.

Related: #1953, PR #1954, OFFSEC-015 (5a05302c). Filed per CTO directive to file follow-ups for problems found.

Residual cross-tenant weakness found while fixing #1953 (PR #1954). #1954 scopes the three leaking paths (discovery.Peers, mcp_tools.toolListPeers, a2a_proxy) to the caller org via the org-root parent_id CTE. But registry.CanCommunicate itself still treats ANY two org-roots as siblings (parent_id IS NULL = all roots), so discovery.Discover and CheckAccess retain the same root-sibling weakness for the org-root<->org-root case (two top-level workspaces in different orgs can pass CanCommunicate). Fix options: (a) scope CanCommunicate itself with the same org-root CTE (orgRootID/sameOrg in the new org_scope.go), or (b) the pending org_id column on workspaces (denormalized) so org checks are a cheap WHERE org_id=? everywhere. Option (b) is the deferred architecture decision; (a) is a contained fix in the meantime. Related: #1953, PR #1954, OFFSEC-015 (5a05302c). Filed per CTO directive to file follow-ups for problems found.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
Labels
Clear labels
area/ci
CI/CD pipeline issues
 do-not-auto-merge
Opt out of autonomous merge-queue merging
 kind/infrastructure
Infrastructure-related issues
 merge-queue
Ready for serialized Gitea merge queue
 merge-queue-hold
Temporarily hold PR in merge queue
 platform/go
Go platform test issues
 release-blocker
Blocks the staging→main promotion / a release
 release-test
security
test-label-sre
tier:high
High risk per dev-sop §SOP-6 — ceo only, 24h cooldown
 tier:low
Low risk per dev-sop §SOP-6 — engineers/managers/ceo can approve
 tier:medium
Medium risk per dev-sop §SOP-6 — managers/ceo can approve
 triage-test
test
 wip
Work in progress — do not auto-merge
No Label
Milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
agent-dev-a agent-dev-b agent-pm agent-researcher agent-reviewer agent-reviewer-1 agent-reviewer-cr2 app-fe (Molecule AI · app-fe) app-lead (Molecule AI · app-lead) app-qa (Molecule AI · app-qa) claude-ceo-assistant claude-ci-reader claude-status-reaper core-be (Molecule AI · core-be) core-devops (Molecule AI · core-devops) core-fe (Molecule AI · core-fe) core-lead (Molecule AI · core-lead) core-offsec (Molecule AI · core-offsec) core-qa (Molecule AI · core-qa) core-security (Molecule AI · core-security) core-uiux (Molecule AI · core-uiux) cp-be (Molecule AI · cp-be) cp-lead (Molecule AI · cp-lead) cp-qa (Molecule AI · cp-qa) cp-security (Molecule AI · cp-security) cui (Zhanlin Cui) dev-lead (Molecule AI · dev-lead) devops-engineer documentation-specialist (Molecule AI · documentation-specialist) fullstack-engineer (Molecule AI · fullstack-engineer) hongming hongming-ceo-delegated hongming-codex-laptop hongming-kimi-laptop hongming-pc2 infra-lead (Molecule AI · infra-lead) infra-runtime-be (Molecule AI · infra-runtime-be) infra-sre (Molecule AI · infra-sre) integration-tester (Molecule AI · integration-tester) mc-drift-bot molecule-code-reviewer plugin-dev (Molecule AI · plugin-dev) pm publish-runtime-bot pypi-publisher (Molecule AI PyPI Publisher (RFC#596)) release-manager (Molecule AI · release-manager) sdk-dev (Molecule AI · sdk-dev) sdk-lead (Molecule AI · sdk-lead) sop-drift-bot sop-tier-bot (SOP Tier-Check Bot) technical-writer (Molecule AI · technical-writer) triage-operator (Molecule AI · triage-operator)
No Assignees
1 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: molecule-ai/molecule-core#1955
Delete Branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?